Frame owner S4: terminals follow their pane in every frame of a key resize (switch-on path; default stays off) by lawrencecchen · Pull Request #35470 · manaflow-ai/cmux

test(next): S4 ON a drag shows each terminal size no later with motion.frameOwner.terminals on than off (red)

lawrencecchen

committed

f355d15

test(next): S4 ON a kept frame stays on the edges its S3 hold names (trailing, bottom) while its new size waits (red)

lawrencecchen

committed

6b3e6c3

fix(next): S4 ON a kept frame rides the still edges of the S3 hold its host follows (trailing, bottom)

lawrencecchen

committed

b0a6f60

test(next): S4 ON the row-drag lag test drives the real layout path (the bare-window version did not reproduce)

lawrencecchen

committed

f863559

debug(next): S4 the debug.motion trace records each terminal's present path per frame (for the ON row-drag film)

lawrencecchen

committed

bda9658

test(next): cmux-ad m6 1a: in a key resize each terminal shows its pane's size in every frame, and its program resizes once per press (red)

lawrencecchen

committed

418d4a8

test(next): cmux-ad m6 1a: the key-resize frame test samples 1.5 s of wall-clock time (idle run-loop turns ended it before the spring moved)

lawrencecchen

committed

73c411a

test(next): cmux-ad m6 1a: the key-resize frame test steps the spring itself (the display-link spring gave 2 states)

lawrencecchen

committed

6cf19a0

test(next): cmux-ad m6 1a: the key-resize frame test checks each terminal's top-left on its pane's (the film gate), and sizes the pane has had

lawrencecchen

committed

1a88bac

test(next): cmux-ad m6 1a: the S3-hold kept-frame case expects the top-left anchor (scenario kept from S4 defect (b))

lawrencecchen

committed

0ffa721

test(next): cmux-ad m6 1a: the key-resize frame test uses the app's PaneContentView, so the key hold follows the pane as in the app (red)

lawrencecchen

committed

b367fad

fix(next): cmux-ad m6 1a: with motion.frameOwner.terminals on, a key resize shows each terminal at its pane's size in every frame; the PTY gets one grid per press

lawrencecchen

committed

51d5c39

Merge remote-tracking branch 'origin/feat-cmux-next' into scratch/frame-owner-s4-on-merge

lawrencecchen

committed

e37c317

test: remove TerminalFrameOwnerDragCadenceTests (it never reproduced the drag's +1 refresh)

lawrencecchen

committed

530c225

feat(next): motion.frameOwner.terminals on by default (FRAME OWNER S4 ON step)

lawrencecchen

committed

b3ab63b

test(next): S4 kept-frame test builds after the feat merge (PaneMotionHold lost containersFollow in #35161)

lawrencecchen

committed

c642350

revert(next): motion.frameOwner.terminals back to off until the key-resize tests check the m6 contract

lawrencecchen

committed

f231b3c

test(next): cmux-ad m6 (c): the key-resize terminal tests check pixels per frame and one grid per press (red with the switch off)

lawrencecchen

committed

2da280e

feat(next): motion.frameOwner.terminals on by default (FRAME OWNER S4 ON step)

lawrencecchen

committed

1e0df52

release-notes: the key-resize terminal highlight is a fix (dogfood 363e39f2: terminals stopped following their pane)

lawrencecchen

committed

665b187

test(next): S4 ON review of #35470: one grid when a frame waits at the landing, a terminal must take new sizes, a low prompt rides the bottom (red)

lawrencecchen

committed

712df02

fix(next): S4 ON: a size in flight that is no longer wanted reports no grid; a low prompt rides the bottom of a pane a key grows down

lawrencecchen

committed

30eccfc

test(next): S4 ON review of #35470 (F3): a parked terminal shown during a key hold follows its pane from its first frame (red)

lawrencecchen

committed

bb46d44

fix(next): S4 ON: a terminal shown in a holding area mid-spring follows its pane (review of #35470, F3)

lawrencecchen

committed

5d62688

test(next): S4 ON F1 test: p1 keeps holding its frames through the spring; check the wait per frame, not the presenter's keeps

lawrencecchen

committed

ec9992f

revert(next): take back the F3 change (5d62688a264): no frame shows it, and its red test passed without it

lawrencecchen

committed

cc2c26e

chore(next): S4 ON review items: debugState is debug-only, frame-owner hot paths marked, contract docs say what each switch state does

lawrencecchen

committed

738ab41

test(next): cmux-ad m6 (c): TabStripFollowsPaneTickTests (b) with terminals: the strip and the terminal follow the pane in every frame, one grid per press

lawrencecchen

committed

ded0cb0

feat(next): S4 ON PR lands with motion.frameOwner.terminals off by default; the key-resize contract tests turn it on

lawrencecchen

committed

447f784

test(next): S4 review of #35470 at 447f784c3cf (G1): the newest press's anchor wins over an older surface hold (red)

lawrencecchen

committed

7abac06

fix(next): S4 ON: the newest key press's anchor wins over an older surface hold (review of #35470 at 447f784c3cf, G1)

lawrencecchen

committed

5aab496

test(next): S4 G1 (b) test takes the parked-tab path the review named (the new-tab version passed without the fix)

lawrencecchen

committed

c4d6c93

test(next): S4 keeps the default path's one-surface-size-per-press checks, with the switch off

lawrencecchen

committed

c0c7f9b

docs(next): S4 comments and the switch's help say what each state does in a key resize

lawrencecchen

committed

162ea37

test(next): S4 key-resize tests run with motion.frameOwner.terminals off and on

lawrencecchen

committed

6522020

Navigation Menu

Repository navigation

Frame owner S4: terminals follow their pane in every frame of a key resize (switch-on path; default stays off) - #35470

Frame owner S4: terminals follow their pane in every frame of a key resize (switch-on path; default stays off)#35470
lawrencecchen merged 35 commits into
feat-cmux-nextfrom
fix/frame-owner-s4-on

Commits on Nov 4, 2026

test(next): S4 ON a drag shows each terminal size no later with motion.frameOwner.terminals on than off (red)

test(next): S4 ON a kept frame stays on the edges its S3 hold names (trailing, bottom) while its new size waits (red)

fix(next): S4 ON a kept frame rides the still edges of the S3 hold its host follows (trailing, bottom)

test(next): S4 ON the row-drag lag test drives the real layout path (the bare-window version did not reproduce)

debug(next): S4 the debug.motion trace records each terminal's present path per frame (for the ON row-drag film)

test(next): cmux-ad m6 1a: in a key resize each terminal shows its pane's size in every frame, and its program resizes once per press (red)

test(next): cmux-ad m6 1a: the key-resize frame test samples 1.5 s of wall-clock time (idle run-loop turns ended it before the spring moved)

test(next): cmux-ad m6 1a: the key-resize frame test steps the spring itself (the display-link spring gave 2 states)

test(next): cmux-ad m6 1a: the key-resize frame test checks each terminal's top-left on its pane's (the film gate), and sizes the pane has had

test(next): cmux-ad m6 1a: the S3-hold kept-frame case expects the top-left anchor (scenario kept from S4 defect (b))

test(next): cmux-ad m6 1a: the key-resize frame test uses the app's PaneContentView, so the key hold follows the pane as in the app (red)

fix(next): cmux-ad m6 1a: with motion.frameOwner.terminals on, a key resize shows each terminal at its pane's size in every frame; the PTY gets one grid per press

Merge remote-tracking branch 'origin/feat-cmux-next' into scratch/frame-owner-s4-on-merge

test: remove TerminalFrameOwnerDragCadenceTests (it never reproduced the drag's +1 refresh)

feat(next): motion.frameOwner.terminals on by default (FRAME OWNER S4 ON step)

test(next): S4 kept-frame test builds after the feat merge (PaneMotionHold lost containersFollow in #35161)

revert(next): motion.frameOwner.terminals back to off until the key-resize tests check the m6 contract

test(next): cmux-ad m6 (c): the key-resize terminal tests check pixels per frame and one grid per press (red with the switch off)

feat(next): motion.frameOwner.terminals on by default (FRAME OWNER S4 ON step)

release-notes: the key-resize terminal highlight is a fix (dogfood 363e39f2: terminals stopped following their pane)

test(next): S4 ON review of #35470: one grid when a frame waits at the landing, a terminal must take new sizes, a low prompt rides the bottom (red)

fix(next): S4 ON: a size in flight that is no longer wanted reports no grid; a low prompt rides the bottom of a pane a key grows down

test(next): S4 ON review of #35470 (F3): a parked terminal shown during a key hold follows its pane from its first frame (red)

fix(next): S4 ON: a terminal shown in a holding area mid-spring follows its pane (review of #35470, F3)

test(next): S4 ON F1 test: p1 keeps holding its frames through the spring; check the wait per frame, not the presenter's keeps

revert(next): take back the F3 change (5d62688a264): no frame shows it, and its red test passed without it

chore(next): S4 ON review items: debugState is debug-only, frame-owner hot paths marked, contract docs say what each switch state does

test(next): cmux-ad m6 (c): TabStripFollowsPaneTickTests (b) with terminals: the strip and the terminal follow the pane in every frame, one grid per press

feat(next): S4 ON PR lands with motion.frameOwner.terminals off by default; the key-resize contract tests turn it on

test(next): S4 review of #35470 at 447f784c3cf (G1): the newest press's anchor wins over an older surface hold (red)

fix(next): S4 ON: the newest key press's anchor wins over an older surface hold (review of #35470 at 447f784c3cf, G1)

test(next): S4 G1 (b) test takes the parked-tab path the review named (the new-tab version passed without the fix)

test(next): S4 keeps the default path's one-surface-size-per-press checks, with the switch off

docs(next): S4 comments and the switch's help say what each state does in a key resize

test(next): S4 key-resize tests run with motion.frameOwner.terminals off and on