Repository navigation
Keep Claude NODE_OPTIONS restore module out of temp cleanup #3526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
1c40a42
Prove NODE_OPTIONS restore module needs durable storage
austinywang ce718c7
Keep Claude NODE_OPTIONS preload out of temp cleanup
austinywang aa37279
Merge remote-tracking branch 'origin/main' into issue-3512-node-optio…
austinywang 67aaf4a
Share NODE_OPTIONS parsing across Swift targets
austinywang 4d14ef9
Keep NODE_OPTIONS regressions inside Swift file budgets
austinywang c0099d9
Prove NODE_OPTIONS tokenizers must respect quoted paths
austinywang c3af32b
Tokenize NODE_OPTIONS consistently outside Swift
austinywang 0050f72
Close NODE_OPTIONS review gaps across launch surfaces
austinywang 09f3a01
Fail fast in NODE_OPTIONS regression helpers
austinywang 0b5cddb
Preserve independent build graph additions during main merge
austinywang 8e0437c
Keep restore overrides sanitizer-visible
austinywang 3911a9e
Keep wrapper arrays safe on macOS bash
austinywang 68f76d3
Preserve launch refactor while hardening node restore sanitization
austinywang fd529be
Run restore override wrapper regression
austinywang 15cdd21
Prove NODE_OPTIONS keeps apostrophes
austinywang 48f1e3b
Treat apostrophes as NODE_OPTIONS literals
austinywang 6834041
Sync PR branch with current release base
austinywang ed48c70
Preserve literal backslashes in NODE_OPTIONS
austinywang 3075dd6
Sync NODE_OPTIONS PR with v0.64.1 base
austinywang 9122d3b
Prevent stale cmux NODE_OPTIONS preloads from surviving reinjection
austinywang 5f24f5f
Keep CLI NODE_OPTIONS reinjection from retaining stale preloads
austinywang 224302e
Share NODE_OPTIONS token helpers across Swift launch paths
austinywang 0290df4
Normalize restored Go NODE_OPTIONS heap flags
austinywang 2e13071
Require exact cmux path components in bash preload cleanup
austinywang 9b9e994
Preserve user NODE_OPTIONS heap caps during reinjection
austinywang a3f6fd0
Retry CI after transient Zig download failure
austinywang 84dfcab
Cover inline user heap caps during wrapper reinjection
austinywang 501b58b
Retry transient Zig downloads in CircleCI
austinywang 3546372
Resume Zig downloads across CircleCI retries
austinywang 72d300e
Prefer Homebrew Zig on CircleCI macOS
austinywang 0793b6a
Use bottled Zig before CircleCI tarball fallback
austinywang f25e107
Avoid corrupt Zig tarball retries
austinywang 396a187
Merge main to keep PR current
austinywang 24292b8
Merge latest main for Hermes agent updates
austinywang 67fde3f
Keep CLI NODE_OPTIONS logic under file budget
austinywang 5560937
Keep NODE_OPTIONS PR current with main
austinywang 340eec3
Link NODE_OPTIONS package into CLI test builds
austinywang 76583ef
Merge origin/main into issue-3512-node-options-tmpdir
austinywang fc3059d
Merge origin/main into issue-3512-node-options-tmpdir
austinywang 2e45f21
Share cmux NODE_OPTIONS stripping in Swift
austinywang aba1956
Share NODE_OPTIONS sanitizer policy
austinywang d3ef942
Treat stale cmux NODE_OPTIONS as absent
austinywang de13a27
Merge origin/main into issue-3512-node-options-tmpdir
austinywang c9dae9d
Fix NODE_OPTIONS review feedback
austinywang bce868d
Fix NODE_OPTIONS fallback temp reuse
austinywang 8673ad4
Merge remote-tracking branch 'origin/main' into issue-3512-node-optio…
austinywang a0d68d3
Fix remote daemon test import
austinywang bdaf095
Merge origin/main and harden NODE_OPTIONS restore dirs
austinywang 1edefd8
Merge remote-tracking branch 'origin/main' into issue-3512-node-optio…
austinywang 8567191
Merge branch 'main' of https://github.com/manaflow-ai/cmux into issue…
austinywang b9df3ac
Fix NODE_OPTIONS restore directory validation
austinywang 4a3aac3
Align NODE_OPTIONS restore normalization guard
austinywang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import Foundation | ||
| import CMUXNodeOptions | ||
|
|
||
| extension CMUXCLI { | ||
| func mergedNodeOptions(existing: String?, restoreModulePath: String) -> String { | ||
| let requireOption = "--require=\(NodeOptionsSupport.requirePath(restoreModulePath))" | ||
| let memoryOption = "--max-old-space-size=4096" | ||
| guard let cleanedExisting = NodeOptionsSupport.sanitizedNodeOptions(existing) else { | ||
| return "\(requireOption) \(memoryOption)" | ||
| } | ||
| return "\(requireOption) \(memoryOption) \(cleanedExisting)" | ||
| } | ||
|
|
||
| func normalizedNodeOptionsForRestore(_ existing: String) -> String? { | ||
| NodeOptionsSupport.normalizedNodeOptionsForRestore(existing) | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // swift-tools-version: 5.9 | ||
|
|
||
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "CMUXNodeOptions", | ||
| platforms: [ | ||
| .macOS(.v13), | ||
| ], | ||
| products: [ | ||
| .library( | ||
| name: "CMUXNodeOptions", | ||
| targets: ["CMUXNodeOptions"] | ||
| ), | ||
| ], | ||
| targets: [ | ||
| .target( | ||
| name: "CMUXNodeOptions", | ||
| path: "Sources/CMUXNodeOptions" | ||
| ), | ||
| ] | ||
| ) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.