[teamleaderleo]

Summary

The feat-cmux-next copy of #35081's classic API guard. Leo, 2026-11-04: "apparently the api if we change it it'll auto deploy so we wanna make extra sure we dont change it for clasisc".

Into feat-cmux-next the check only warns. This branch deploys nothing classic: its merge-base with main is 2026-10-19 and nothing merges or syncs one into the other. The warning keeps such changes visible in case the branches are merged for a release. The files are identical to #35081's head (53026e9); the test is registered in tests/test-execution.toml and run from ci-guards.yml.

Testing

python3 tests/test_classic_api_guard.py (13 OK), test_ci_warm_sources.py, test_ci_label_events_skip_full_ci.py, test_ci_runs_on_values.py and validate_test_execution_registry.py --base-sha origin/feat-cmux-next: all pass locally.

Observed / Not run

Observed: the tests above. Not run: a live PR event.

Changelog

none

Agent session: agent session

[blacksmith-sh]

Found 6 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmp_u7y5gnw/summary-missing.json (live):/summary-missing.json (live):	View Logs
/tmp/tmpfmtqe33_/summary-fail.json (live):/summary-fail.json (live):	View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/ [new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows	View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 7460c20: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35126 -f ref=lane/classic-api-guard-next -f platform=macos -f backend_mode=local

web and size checks: green

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4182499138501 (e0aa712b3b)
• cmux NEXT nightly 1.0.0-nightly.4184087390301 (08052d331e)
• cmux NEXT nightly 1.0.0-nightly.4184224384601 (a3abfc4160)
• cmux NEXT nightly 1.0.0-nightly.4184409870901 (78ee0e108e)

[teamleaderleo]

Review (subagent, opus medium, correctness): SHIP at f4c0dde

Visual verdict: unchanged by this diff (no UI).

Checked the rename of the deploy map to scripts/ci/ (every reference updated), the guard test, actionlint, and the runner and registry guard tests (the RUNNER_POOLS runs-on fixes test_ci_linux_single_size). The remaining test_ci_* reds name other workflows and are red on base.

Follow-ups: #35120 (rename-aware truncation count; required check).

[teamleaderleo]

Review (codex, router-review): SHIP at 7460c20

Reviewer: codex gpt-6-astra high, fast tier.

Follow-ups: 2. They land as checklist items in this PR's one follow-up tracking issue in this repo (Follow-ups: #N ..., label follow-up; add to an open one before filing, never one issue per finding), linking this receipt; the lane that opened the PR fixes them forward.

SHIP at 7460c20
Visual verdict: no images; Leo tries the build

1. [P2] [follow-up] [category:correctness] [finding:F1] [outcome:pending] scripts/ci/classic_api_guard.py:88: Count API file records separately from rename paths. With 3,001 changed files, GitHub returns 3,000 records; one rename supplies an extra path, hiding truncation. Reproduced: both branches report no classic API changes even when the omitted record could be guarded. Add a truncation test containing renames.

2. [P2] [follow-up] [category:correctness] [finding:F2] [outcome:pending] scripts/ci/classic-auto-deploy.json:23: Include web/data/model-catalog/snapshot.json among guarded API inputs. web/services/model-catalog/store.ts loads it for /api/models/v1 and /api/agent-models, but changing it currently produces no warning. Add coverage for this production data dependency.

Follow-ups:

• F1: Preserve the returned file-record count when expanding renames.
• F2: Guard the model-catalog snapshot.

[cmux-bot]

cmux-bot approves 7460c20: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.