Repository navigation
cmux NEXT: Invite People hides the empty link row from VoiceOver; Copied clears with the link - #35119
teamleaderleo wants to merge 7 commits into
Conversation
…py width, Copied clears with the link Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b443a4be4f9b3a1f457e
…ied clears with the link; zh-Hans 复制 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b443a4be4f9b3a1f457e
|
Review (subagent claude-opus-5-5 medium): SHIP at 2741c67 Visual verdict: unchanged by this diff (accessibility state, two zh-Hans values, a model flag and tests; layout and alpha as on base). Checked the NSView accessibility API names, Follow-ups:
|
…width constraint on it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b443a4be4f9b3a1f457e
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green |
|
Found 4 test failures on Blacksmith runners: Failures
|
|
Review (subagent claude-opus-5-5 medium): SHIP at ae53f06 Visual verdict: unchanged by this diff (test only). The new commit narrows the fixed-width check to the button's own required constant width (the old count also caught its subviews' width constraints, the CI red at line 464); it compiles and the frame-width checks across Copied still guard the behaviour. Compile check passed at this head. Follow-ups: [follow-up] F1 (test, outcome:pending): |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Follow-ups from the review of #34656 on the Invite People sheet (listed on #33746):
copied(and its reset timer) when there is no link.Commit 1 adds the tests (the accessibility and Copied checks fail on base), commit 2 the fix. Design spec: design/chat-multiplayer.md (Invite people); no design change. Localization audit: only the two zh-Hans values changed; no new strings.
Refs #33746
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Updates the Invite People sheet so VoiceOver skips the empty invite-link row, and the Copied confirmation clears when the link disappears.
Written for commit 1f03386. Summary will update on new commits.