Repository navigation
Agent pane: the live line stays shown while a reply streams - #35028
Conversation
Leo: "it appears and disappears????" The running turn's live line hid (visibility: hidden) whenever the reply above it streamed, and came back only after the text held still 1.2s (useQuiet/QUIET_MS). Text streams in bursts, so the line blinked in and out at every pause. It now stays where it is and reads "Writing" while the text moves, then "Thinking" after WRITING_MS, as liveState already labelled it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7d67f298e4a2e1076c0f
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
|
Review (subagent claude-opus-5-5 medium): SHIP at 7981b43 Visual verdict: no images; the live line stays where it was and reads "Writing" instead of hiding while text streams. Checked: codexLiveTurn sets quietKey/quietAt/liveState "writing" for a streaming reply, so the line reads "Writing" from the first token (useLayoutEffect, no "Thinking" frame under it); no remaining references to QUIET_MS, live_line_shown or liveLineShown; Follow-ups:
|
|
Found 6 test failures on Blacksmith runners: Failures
|
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (codex gpt-6-astra high, next-review, since=20261104T074607Z): SHIP at 7981b43
SHIP at 7981b43
Visual verdict: all 16 supplied before/after pairs reviewed; no introduced layout regressions.
No actionable correctness findings. Tests could not run because Bun and dependencies are unavailable in this box.
Follow-ups: none
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (gpt-6-astra): SHIP at 0a2f13c
|
Review (codex gpt-6-astra high, router-review job 9ffac2453036d627f16edb053c5e21a4, carried: its --post hit the spent REST quota): SHIP at 0a2f13c Visual verdict: no images; Leo tries the build Follow-ups:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo: "it appears and disappears????" (with a capture of a running agent chat where the spot under his message showed nothing)
Leo-ask: ask-245840dfaf
What was wrong
The running turn's live line (the Codex-style line at the bottom of the turn) hid itself with
visibility: hiddenwhenever the reply above it streamed, and came back only once the text had held still for 1.2s (useQuietwithQUIET_MS,.cv-worked.is-quiet). Replies stream in bursts, so the line blinked in and out at every pause in the stream.Fix
The live line never hides mid-turn. While the reply's text moves it stays where it is and reads "Writing", then "Thinking" after
WRITING_MS(5s) of quiet, the labelsliveState: "writing"already gave it. Its height and place are unchanged, so nothing moves.Thinking.tsx: drops the quiet hide on the live line (and the now unusedQUIET_MS); theuseQuiettimer still drives Writing → Thinking.loadDebug.ts/agent-pane-stream-renders.test.ts: the stream harness now counts frames with the live line hidden while a reply streams and expects 0 (it used to count shown frames and expect 0).Thinking.test.tsx,transcript-codex-live-line.test.tsx: assert the line stays shown and reads Writing.Design spec:
design/chat-transcript.md(the live line keeps the Thinking line's id from send to the turn's end, so it never leaves and comes back). This undoes the hide-while-streaming behaviour from the live-line work (#34004's review kept it hidden while streaming); Leo's capture asks for the opposite.Risk: small, one component; no timers added (one fewer
useQuiettimer per live line).🤖 Generated with Claude Code
Agent session: agent session
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
The running turn's live line no longer hides while its reply streams, so it stops flickering in and out at every pause in the text (Leo, 2026-11-04: "it appears and disappears????"). The line used to hide itself with
visibility: hiddenas soon as the reply text above it moved and returned only after 1.2s of quiet; streamed text moves in bursts, so the line blinked constantly. It now stays where it is and reads "Writing" while the text moves, then "Thinking" after 5s of quiet, the labelsliveStatealready gave it.Bug Fixes
Thinking.tsxdrops the quiet hide on the live line and the now-unusedQUIET_MS; no timers added, one feweruseQuiettimer per live line.Written for commit 7981b43. Summary will update on new commits.