Skip to content

Transcript: give live Thinking the scaled run gap - #35002

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
lane/thinking-seam-gap
Nov 4, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
lane/thinking-seam-gap

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

The live Thinking line sat flush against the preceding tool or agent-message row. It now takes the existing scaled run gap, so live state is separate from completed activity in compact and comfortable modes.

Leo, 2026-11-04:

"this is now stacked up too tight"
"as in the gap between tool calls and thinking needs to be bigger"

The flush seam came from #31497, extended to the live footer slot by #31690 (git log -S on the gap rule). Activity rows keep their existing pitch. Claude keeps its per-run disclosures. Revert this PR to restore the prior seam.

Gallery: agent-pane.transcript-cohesion, variants live-peers, live-tools, live-status, both densities at Interface Size 1 and 1.25. Private references: claude/live/transcript-peer-session-message, chatgpt/live/status-working-thinking-and-tool-calls. Spec: leo-workspace design/transcript-spacing.md and design/chat-transcript.md.

Performance

Metric Before After Delta Harness
Activity → Thinking box gap at Interface Size 1, both densities 0px 16px +16px Same-harness fleet run, 12 cases per phase
Activity → Thinking box gap at Interface Size 1.25, both densities 0px 20px +20px Same run, 12 cases per phase

The layout uses the existing token during placement; no new observer, timer, animation or per-token pass.

Validation

Fleet run 41806478301 passed at 1a49f0a58a63b25a759f5c5e44bb3d524c6e859a: 40 layout/estimate tests, 40 gallery cases and 24 baseline measurements. The same browser harness measured the pre-fix rule and classification, then the change, across three activity types, both themes, both densities and both scales. All 24 after measurements were 16px or 20px as scaled. All Claude cases retained zero whole-turn folds. Downloaded and opened the compact and comfortable captures beside the private reference; both show the new separation. The existing finished reply footer remains 8px from activity.

Changelog

Fixed: Restore breathing room between tool calls and the live Thinking line.

🤖 Generated with Codex

Agent session: agent session

teamleaderleo and others added 2 commits November 4, 2026 06:55
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-7085149b0faf4181b8f6
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-7085149b0faf4181b8f6
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 0845a23: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35002 -f ref=lane/thinking-seam-gap -f platform=macos -f backend_mode=local

Gallery before/after for 1a49f0a: 6 states rendered, 7 images differ (picked by the Gallery: line in the PR body). Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41809246140 -R manaflow-ai/cmux -n gallery-advisory-35002-1a49f0a58a63b25a759f5c5e44bb3d524c6e859a (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.transcript-cohesion/live-peers Apple System Colors Light new 0% pr-body
agent-pane.transcript-cohesion/live-peers Apple System Colors new 0% pr-body
agent-pane.transcript-cohesion/live-tools Apple System Colors Light new 0% pr-body
agent-pane.transcript-cohesion/live-tools Apple System Colors new 0% pr-body
agent-pane.transcript-cohesion/live-status Apple System Colors Light new 0% pr-body
agent-pane.transcript-cohesion/live-status Apple System Colors new 0% pr-body
agent-pane.transcript-cohesion/codex-closed Apple System Colors Light unchanged 0% pr-body
agent-pane.transcript-cohesion/codex-closed Apple System Colors unchanged 0% pr-body
agent-pane.transcript-cohesion/codex-open Apple System Colors changed 0% pr-body
agent-pane.transcript-cohesion/codex-open Apple System Colors Light unchanged 0% pr-body
agent-pane.transcript-cohesion/claude Apple System Colors Light unchanged 0% pr-body
agent-pane.transcript-cohesion/claude Apple System Colors unchanged 0% pr-body

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

Yours to fix: transcript-cohesion.test.ts (a file this PR changes), transcript-cohesion.test.ts (a file this PR changes).

CI failed on 1a49f0a58a (run 41797183389 attempt 1): 1 code, 1 unknown.

Job Verdict Why
web / react-apps-base-check (7) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • yours transcript-cohesion.test.ts claude keeps the activity rhythm (light): failed (job)
  • yours transcript-cohesion.test.ts claude keeps the activity rhythm (dark): failed (job)
Matched log lines
web / react-apps-base-check (7): (fail) claude keeps the activity rhythm (light) [1421.82ms]

Not re-run automatically: web / react-apps-base-check (7), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 4c88252 to compare; do not merge until green; see lane-rules
red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / react-apps-base-check (5); NEW webview test reds: test/new-tab-live-resize.test.ts > webkit: the default page follows a live resize; test/new-tab-live-resize.test.ts > webkit: the composer page follows a live resize; test/new-tab-live-resize.test.ts > webkit: the cards page follows a live resize; do not merge until green; see lane-rules
red: web / react-apps-base-check (6); NEW webview test reds: test/transcript-cohesion.test.ts; do not merge until green; see lane-rules
red: web / react-apps-check; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-7085149b0faf4181b8f6
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-7085149b0faf4181b8f6
@teamleaderleo teamleaderleo added the leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel label Nov 4, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmphf0qig4r/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpw0xvruv5/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (codex gpt-6-astra high, next-review, since=20261104T074607Z): SHIP at 0845a23

SHIP at 0845a23

Visual verdict: live-state spacing is clear in both themes; all six existing before/after pairs are pixel-identical. No introduced visual regression found.

Reviewed layout classification, scaling, footer spacing, and affected assertions. Tests could not run locally because Bun and dependencies are unavailable.

Follow-ups: none

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 4, 2026 08:08 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 4, 2026 08:10 Inactive
@teamleaderleo
teamleaderleo merged commit a0fd4e7 into feat-cmux-next Nov 4, 2026
191 of 203 checks passed
@teamleaderleo
teamleaderleo deleted the lane/thinking-seam-gap branch November 4, 2026 09:34

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 1a49f0a5 Deployed Nov 4, 2026 by cmux-bot[bot] via wait for same-key tree publisher #110589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant