Tighten CodeRabbit Swift lint enforcement by lawrencecchen · Pull Request #3496 · manaflow-ai/cmux

lawrencecchen · 2026-05-04T08:27:36Z

Summary

Follow-up from the vendor lint evals after #3493 merged.

Switch CodeRabbit to assertive review profile
Enable CodeRabbit request_changes_workflow
Document that CodeRabbit error-mode checks can block through the review flow

Eval evidence

Temporary eval PRs:

Comprehensive fixture: TEMP vendor lint eval: comprehensive Swift fixture #3494
Architecture and @Concurrent fixture: TEMP vendor lint eval: architecture and concurrent #3495

Greptile caught the target rule families on both evals. CodeRabbit used .coderabbit.yaml after it landed on main, but mode: error was still advisory because request-changes workflow was not enabled.

Validation

jq empty .greptile/config.json .greptile/files.json
ruby -ryaml -rjson -e 'puts JSON.generate(YAML.load_file(".coderabbit.yaml"))' > /tmp/coderabbit-blocking-mode.json\n- bun x ajv-cli validate --strict=false -s /Users/lawrence/fun/cmuxterm-hq/worktrees/feat-deepseek-diff-lint/tmp/coderabbit-schema.json -d /tmp/coderabbit-blocking-mode.json

Summary by cubic

Enable blocking Swift lint via CodeRabbit by switching to the assertive review profile and turning on the request-changes workflow. Update the review-bot rules README to note Greptile inline findings/status check and that unresolved error‑mode findings in CodeRabbit can block merge.

^{Written for commit 5755057. Summary will update on new commits.}

Summary by CodeRabbit

Chores
- Enhanced code review automation configuration with more assertive review practices and streamlined request-changes workflow to strengthen quality assurance processes.
Documentation
- Updated review bot configuration documentation to reflect current system setup and workflow capabilities.

chatgpt-codex-connector · 2026-05-04T08:27:41Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

vercel · 2026-05-04T08:27:42Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmux	Ready	Preview, Comment	May 4, 2026 8:29am
cmux-staging	Building	Preview, Comment	May 4, 2026 8:29am

coderabbitai · 2026-05-04T08:28:00Z

Warning

Ignoring CodeRabbit configuration file changes. For security, only the configuration from the base branch is applied for open source repositories.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 39d7bcd0-1be3-41b1-b293-6f75d5d9d2ea

📥 Commits

Reviewing files that changed from the base of the PR and between 0d634c8 and 5755057.

📒 Files selected for processing (2)

.coderabbit.yaml
.github/review-bot-rules/README.md

📝 Walkthrough

Walkthrough

This PR configures CodeRabbit's review integration to use an assertive profile and enable request-changes workflow, then updates documentation to reflect these new settings.

Changes

CodeRabbit Review Configuration

Layer / File(s)	Summary
Configuration `.coderabbit.yaml`	Enables `reviews.profile: assertive` and `reviews.request_changes_workflow: true` to enforce stricter review enforcement.
Documentation `.github/review-bot-rules/README.md`	Documents that CodeRabbit now uses assertive review plus request-changes workflow, alongside existing custom pre-merge checks in error mode.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Use Greptile and CodeRabbit for Swift lint rules #3493: Modifies .coderabbit.yaml configuration for CodeRabbit review settings in the same repository.

Poem

🐰 Assertive now, this rabbit's review shall be,
Request changes flowing, stricter standards we decree,
The config whispers, the docs align,
CodeRabbit stands guard—all's fine! ✨

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Cmux Swift Blocking Runtime	❌ Error	PR introduces blocking/timing patterns (DispatchSemaphore, Task.sleep, asyncAfter) in production Swift code that violate swift-blocking-runtime.md rules.	Replace DispatchSemaphore with async/await, remove Task.sleep from production code, replace asyncAfter with proper state transitions, and consider actor isolation for NSLock usage.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Tighten CodeRabbit Swift lint enforcement' clearly summarizes the main change: enabling stricter CodeRabbit linting by switching to assertive profile and enabling request-changes workflow.
Description check	✅ Passed	The description includes a comprehensive summary of changes with rationale, references to evaluation PRs with evidence, validation steps, and context from prior work. All critical sections are well-documented.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Swift Actor Isolation	✅ Passed	PR contains no Swift code changes; only modifies .coderabbit.yaml and .github/review-bot-rules/README.md configuration files.
Cmux Swift Concurrency	✅ Passed	This PR contains no modifications to existing Swift source files. All changes are to configuration and documentation files (.coderabbit.yaml and .github/review-bot-rules/README.md), which set up the CodeRabbit review bot infrastructure and document concurrency rules.
Cmux Swift `@Concurrent`	✅ Passed	This PR contains only configuration and documentation changes with no Swift source code modifications.
Cmux Swift Logging	✅ Passed	PR configures CodeRabbit enforcement and documents Swift logging rules. Changes are to configuration and documentation files, not production Swift code, so custom check requirement is not applicable.
Cmux Swiftui State Layout	✅ Passed	PR only modifies configuration and documentation files with no SwiftUI source code changes, making the custom check not applicable.
Cmux Architecture Rethink	✅ Passed	PR contains only configuration and documentation changes to the review bot system with no modifications to Swift source code or architecture changes.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat-review-bot-blocking-mode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 6/8 reviews remaining, refill in 10 minutes and 46 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-05-04T08:28:43Z

Greptile Summary

This PR tightens CodeRabbit enforcement by switching its review profile to assertive and enabling request_changes_workflow: true, which allows the existing mode: error pre-merge checks to actually block merges through the review flow. The README is updated to accurately describe this new behaviour.

Confidence Score: 5/5

Safe to merge — configuration-only change with no Swift code modifications.

Both changed files are configuration/documentation. The YAML additions are valid, consistent with the schema, and the README accurately reflects the new state. No functional code is touched, and the custom Swift lint rules are unaffected.

No files require special attention.

Important Files Changed

Filename	Overview
.coderabbit.yaml	Adds `profile: assertive` and `request_changes_workflow: true` to the reviews block; all existing pre-merge checks (mode: error) and path instructions are unchanged.
.github/review-bot-rules/README.md	Documentation updated to reflect the new assertive profile, request-changes workflow, and blocking behaviour; accurately matches the updated .coderabbit.yaml.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR opened] --> B[CodeRabbit review triggered]
    B --> C{profile: assertive}
    C --> D[Run error-mode custom checks]
    D --> E{Any check fails?}
    E -- Yes --> F[Request changes workflow\nblocks merge]
    E -- No --> G[Review approved\nMerge unblocked]

    style F fill:#f87171,color:#fff
    style G fill:#4ade80,color:#fff

_{Reviews (1): Last reviewed commit: "Tighten CodeRabbit review bot enforcemen..." | Re-trigger Greptile}

Tighten CodeRabbit review bot enforcement

5755057

This was referenced May 4, 2026

TEMP vendor lint eval: comprehensive Swift fixture #3494

Closed

TEMP vendor lint eval: architecture and concurrent #3495

Closed

vercel Bot deployed to Preview – cmux May 4, 2026 08:29 View deployment

lawrencecchen merged commit 890686f into main May 4, 2026
19 of 21 checks passed

lawrencecchen deleted the feat-review-bot-blocking-mode branch May 4, 2026 08:32

lawrencecchen mentioned this pull request May 4, 2026

TEMP vendor lint eval: CodeRabbit enforcement #3497

Closed

This was referenced May 4, 2026

Add review bot file boundary rule #3498

Merged

Add review rule against hacky sleeps #3633

Merged

coderabbitai Bot mentioned this pull request May 13, 2026

Improve Cloud VM error guidance #4094

Merged

coderabbitai Bot mentioned this pull request Jun 18, 2026

Add CodeRabbit config focused on quality, memory, and test coverage singnet/das#1153

Merged

coderabbitai Bot mentioned this pull request Jul 10, 2026

chore(coderabbit): align review rules with decoder purity; enable blocking reviews tsouza/purecard#2

Merged

Navigation Menu

Repository navigation

Tighten CodeRabbit Swift lint enforcement - #3496

Tighten CodeRabbit Swift lint enforcement#3496
lawrencecchen merged 1 commit into
mainfrom
feat-review-bot-blocking-mode

lawrencecchen commented May 4, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented May 4, 2026

Uh oh!

vercel Bot commented May 4, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 4, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks failed

Uh oh!

greptile-apps Bot commented May 4, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

lawrencecchen commented May 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Eval evidence

Validation

Summary by cubic

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented May 4, 2026

Uh oh!

vercel Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks failed

❌ Failed checks (1 error)

Uh oh!

greptile-apps Bot commented May 4, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lawrencecchen commented May 4, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented May 4, 2026 •

edited

Loading

coderabbitai Bot commented May 4, 2026 •

edited

Loading