Skip to content

ci: correct owned rescue token-route explanation - #34907

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/owned-rescue-token-note
Nov 4, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/owned-rescue-token-note

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Correct the owned-pool rescue polling allowlist explanation after #34787: Actions reads and mutations now share the existing cmux-bot token with github.token fallback, and never use the runner-routing App. This completes the feature-branch half of #34811; the default-branch copy follows its token-route carry.

Leo asked: “how's ci? we still have bigger wins we can get? what's the state of it all? more things we can skip/do better”.

Validation: parsed the Python source successfully. The only change is one explanatory string; behavior and allowlist matching stay unchanged.

Prior art: #30608, #25929, #25204 and #25812 read. The held nightly-capture PR touches a separate allowlist entry.

🤖 Generated with Codex

Agent session: agent session


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Corrects the owned-pool rescue allowlist explanation to match the token routing from #34787: reads and mutations now use the existing cmux-bot token with github.token fallback, and the routing App token is never used. This is a comment-only change in the test file; behavior is unchanged.

Written for commit e550a02. Summary will update on new commits.

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review e550a02: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr34907 -f ref=lane/owned-rescue-token-note -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 4, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpccj2tlob/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpkstnu3qs/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent codex gpt-6.1-sol token_note_review): SHIP at e550a02

Only one explanatory string changes. The unchanged workflow passes the existing cmux-bot/github.token choice to both read and mutation tokens; allowlist matching stays unchanged. Python AST, YAML parsing and diff whitespace checks pass.

Visual verdict: unchanged by this diff.
Follow-ups: none.

@teamleaderleo
teamleaderleo merged commit ec717b3 into feat-cmux-next Nov 4, 2026
154 of 169 checks passed
@teamleaderleo
teamleaderleo deleted the lane/owned-rescue-token-note branch November 4, 2026 06:17

This branch was previously deployed

1 inactive deployment
ci-routing-agent — e550a02d Deployed Nov 4, 2026 by teamleaderleo via wait for same-key tree publisher #109959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant