Repository navigation
Keep release publishing on WarpBuild - #3483
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (3)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughCircleCI macOS nightly/release workflows and supporting release scripts were removed; the CircleCI ChangesCI/CD Migration: CircleCI → GitHub Actions
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/8 reviews remaining, refill in 59 minutes and 33 seconds.Comment |
Greptile SummaryThis PR migrates nightly and release publishing from CircleCI back to GitHub Actions/WarpBuild by re-enabling Confidence Score: 4/5Safe to merge; P2 findings only — no build-correctness or security issues. The migration is structurally sound: idempotency guards are intact, secrets usage is correct, and the CircleCI config is cleanly trimmed. Two P2 style concerns: rapid pushes to main can queue many nightly builds (no cancel-in-progress), and the
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph GHA["GitHub Actions / WarpBuild (restored)"]
P1[push to main] --> N1[nightly.yml\ndecide job]
WD1[workflow_dispatch] --> N1
N1 -->|should_build=false| SKIP1[Skip — nightly tag current]
N1 -->|should_build=true| N2[build-sign-notarize-nightly\nwarp-macos-26-arm64-6x]
N2 --> N3[Notarize + DMG]
N3 -->|should_publish=true| N4[Publish nightly release\n+ push nightly tag]
N3 -->|should_publish=false| N5[Upload branch artifact]
P2[push tag v*] --> R1[release.yml\nguard_release_assets]
WD2[workflow_dispatch] --> R1
R1 -->|skip_all=true| SKIP2[Skip — assets already exist]
R1 -->|skip_all=false| R2[build-sign-notarize\nwarp-macos-26-arm64-6x]
R2 --> R3[Notarize + DMG + Appcast]
R3 -->|push event| R4[Publish release assets\n+ R2 appcast]
R3 -->|workflow_dispatch| R5[Upload dry-run artifact]
end
subgraph CCI["CircleCI (CI checks only)"]
B1[push to branch] --> C1[macos-unit-tests]
B1 --> C2[macos-debug-build]
B1 --> C3[macos-release-build]
end
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| on: | ||
| push: | ||
| branches: [main] |
There was a problem hiding this comment.
The new push: branches: [main] trigger fires a nightly run for every commit to main. Because cancel-in-progress: false, consecutive pushes within a single build window (≈20 min) queue behind each other rather than being collapsed. The decide job re-fetches the latest main HEAD at queue time so intermediate commits aren't built twice, but a burst of 5 pushes still queues 5 workflow runs. Consider adding a schedule (e.g. schedule: - cron: '0 7 * * *') as a complement or switching cancel-in-progress: true to drop superseded queued runs.
e0a0c01 to
75c0f78
Compare
This branch was successfully deployed
1 participant
Summary
Verification
Notes
CircleCI release publishing would need secrets copied out of GitHub Actions. Local ~/.secrets files do not appear to contain the Apple signing or Sparkle release secrets by name, so leaving publishing on GitHub Actions is safer.
Summary by cubic
Keep macOS publishing on WarpBuild (GitHub Actions) and drop CircleCI publishing. Nightly runs on
mainpushes; taggedv*releases publish via Actions; CircleCI now only runs macOS checks.Refactors
nightly.yml(push tomain) andrelease.yml(push tagsv*)..circleci/config.ymlto onlymacos-unit-tests,macos-debug-build, andmacos-release-build; removed CircleCI nightly/release workflows and all publishing scripts.Bug Fixes
release.yml: guard now supportsworkflow_dispatchwithout a tag by running in dry-run mode and not failing.Written for commit 75c0f78. Summary will update on new commits.
Summary by CodeRabbit