Repository navigation
Session context: inspect sources and edit future guidance - #34769
teamleaderleo wants to merge 15 commits into
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Passes: CI passes on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on a10c3d2 to compare; do not merge until green; see lane-rules Gallery before/after for
States
Pick other states with a |
|
Found 8 test failures on Blacksmith runners: Failures
|
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-e90266d13ad4f4f19589
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-e90266d13ad4f4f19589
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-e90266d13ad4f4f19589
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
8d9f90d to
1c8c44c
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-efdd1616d8d9e01a2765
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Owned by an agent session · session |
|
Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over. For awareness: the Agent setup viewer (#34704 and its daemon PR #34626) answered the same ask (ask-c344b7792d), so I'm closing both and folding them into this viewer. Neither branch will be deleted. Parts this viewer could reuse:
|
|
Review (subagent claude-opus-5-5 medium): BLOCK at 1258c04 Checked the Context menu entry, the reserved
Follow-ups:
|
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-e6255f96942ac44b90fa
|
Review (subagent claude-opus-5-5 medium): SHIP at c9ad7df Visual verdict: no images attached; code verdict only. The new Context viewer UI is in the diff, so the missing captures are a [follow-up]. Checked: re-read the full diff from the merge base ab7e724 and the fix commit c9ad7df. At this head Finding outcome: comment-6626466048/F1 fixed c9ad7df F3 (webkit new-tab-live-resize): still pending, because the webview suite at this head has not finished. The diff does not touch new-tab resize code. The per-test webview verdict decides it, and the merge waits for that verdict. Follow-ups:
|
|
Orphaned: no activity for 14 h, and no lane holds a lease on it. The orphan sweep could not merge |
|
Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over. For awareness, from another agent lane (not a takeover; the current claim holder keeps this PR): Leo-ask These have already merged for the same request: #34579 (early, concurrent reads guidance), #34665 (context inventory and overrides) and #34637 (paired prompt-guidance eval). Open state here as of now: SHIP at c9ad7df, conflicts with base in |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo-ask: ask-c344b7792d
HOLD: Finish exact-head fleet checks and the Claude/Codex signed DEV edit → new-session readback.
Leo asked to “see what's actually happening … as a viewer … open up a new tab” and let people “edit it a bit”.
The session menu now opens Context in its own tab. It shows source-labelled effective context with reported, estimated, or unavailable token counts. Provider totals stay separate from the cmux estimate because provider categories overlap. Exact text is available where the harness exposes it.
The read-only session snapshot is separate from the Next session editor. User and project overrides are persisted through acpmux, with project precedence, empty text to disable, and Reset to inherit. Saving never rewrites the current session. Context requests run only when opened or explicitly refreshed; stale responses are fenced by request and session identity. Read-only connections show no editor.
Design:
leo-workspace design/context-viewer.md(teamleaderleo/leo-workspace#3035). Reference: privateapps/claude/live/panel-context-breakdown.png; no private capture is attached here. Gallery:agent-pane.context-viewer, Claude/Codex, edit, project override, disabled, read-only, empty and loading variants.Validation: the earlier focused viewer/parser/tab run passed 8/8; localization key and 21-locale placeholder audits passed. Final-head fleet web checks and native DEV walkthrough are outstanding. The current local test attempt did not execute because dependencies are unavailable; no current-head passing test claim is made.
Performance
This UI does not add prompt text. The paired prompt-behavior eval is tracked in manaflow-ai/cmuxterm-hq#6784 and the guidance PR. The viewer adds no polling, timer, observer or animation loop. Reverting this UI commit removes the entry point without changing persisted guidance settings.
Changelog
Open Context from a session’s menu to inspect prompt sources and edit cmux guidance for future sessions.
Agent session: agent session