Repository navigation
Add task manager workspace and terminal jumps #3471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lawrencecchen
merged 16 commits into
main
from
task-task-manager-open-workspace-terminal
May 5, 2026
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
47fa5e4
Add task manager navigation actions
lawrencecchen 1b33c9d
Merge remote-tracking branch 'origin/main' into task-task-manager-ope…
lawrencecchen 1e74b4f
Fix task manager process ownership for agent terminals
lawrencecchen 2a30ecd
Address task manager review feedback
lawrencecchen ec02017
Clarify debug logging review policy
lawrencecchen 21b10a4
Make task manager process kills graceful
lawrencecchen 2e7cca7
Merge remote-tracking branch 'origin/main' into task-task-manager-ope…
lawrencecchen 4b6c433
Address task manager review findings
lawrencecchen 826cee9
Refresh task manager after kill failures
lawrencecchen c642bc3
Split task manager UI from window controller
lawrencecchen 0ab22a0
Send graceful signal before force kill
lawrencecchen d82e089
Fix task manager review follow-ups
lawrencecchen 47db5b5
Address task manager kill fallback review
lawrencecchen 690e0eb
Cache task manager cmux scope lookups
lawrencecchen e9b1099
Address task manager scope cache review
lawrencecchen 395ee82
Document process scope cache synchronization
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taskManager.killProcess.errorxcstrings entries use two C-format specifiers (%lldfor the PID and%@for the error message), but the Swift call site builds a single pre-joineddetailstring and passes it as oneString.LocalizationValueinterpolation argument. Swift'sString(localized:defaultValue:)substitutes positional arguments from thedefaultValueinterpolation list into the resolved xcstrings template by position. With only one argument supplied and two specifiers in the template, the first specifier (%lld) receives a String where an Int64 is expected, and the second (%@) gets nothing — producing a malformed or literally un-substituted error string in bothenandjalocales. The xcstrings entry should use a single%@to match the one pre-formatted String argument the Swift code actually passes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. The error localization now has one %@ placeholder and the call sites format it with the prebuilt error detail string.
— Claude Code