Repository navigation
Prompt rail: one Codex-sized height that nothing changes; the wave keeps up with a sweep - #34666
Conversation
… no holes (red) Leo-ask: ask-0eea9d95e5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-6db3c1673d18051baad7
…eps up with a sweep Leo, 2026-11-04: "the left side session rail should just be having a nicer max height instead of going all the way up and down. make it look like codex's size." and "the height of the left scroll rail should never be affected by anything" and "the missing chunks of the wave bother me". The rail's box is a fixed 240 px (fixed-240 arm, with 200 and 280 to compare); past 24 prompts its list scrolls. Growing ticks in the zipper ease over the quick step instead of the standard one, so the rows ahead of the pointer are up as it arrives; shrinking ticks keep the tail. Leo-ask: ask-0eea9d95e5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-6db3c1673d18051baad7
|
Review (subagent claude-opus-5-5 medium): SHIP at 8a21b18 Visual verdict: no images; code verdict only [follow-up]. Follow-ups:
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Stale: these images are of Gallery before/after for
States
Pick other states with a Unclear: CI failed on
Not re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); do not merge until green; see lane-rules Shipped in:
|
…composer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-6db3c1673d18051baad7
A fixed arm no longer grows to the prompts on screen; its list scrolls to keep them. A stack grown into it lifts the whole rail clear instead of shortening it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-6db3c1673d18051baad7
…ave-fast-codex-height
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-6db3c1673d18051baad7
…oving it Leo, 2026-11-03: "i just don't like it when the thing shifts". The fixed rail keeps its rest box for every stack; the height gallery notes describe the fixed arms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-6db3c1673d18051baad7
|
Review (subagent claude-opus-5-5 medium): SHIP at c55d741 Delta since the SHIP at 06971b0 (itself a delta from 8a21b18): a fixed arm (default fixed-240) is one height whatever the band or bottom stack, and a grown stack lays over its foot instead of moving or shortening it. The jsdom suites Follow-ups:
|
|
Found 8 test failures on Blacksmith runners: Failures
|
…re pointing at it (#35966) * gallery: thread-minimap-unheld scrolls the rail to an old prompt before pointing at it Since #34666 the rail has one height, so sixty prompts overflow it; it opens on the latest and draws only the ticks in its view (tickWindow.ts). The plays hovered ticks 2 and 4 right away and failed with 'no element for [data-tick=N]' on every health shard, red on base too. Each play now wheels the rail (which marks it as the reader's) and scrolls its list to the top first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cb8b9969051e7411b140 * style(webviews): format the minimap gallery play (vp fmt) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cb8b9969051e7411b140 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo, 2026-11-04:
Leo-ask: ask-0eea9d95e5
What changes
max(count × 10, 320)capped at 92% of the window, so in a long chat it ran from the top of the pane to the bottom. It is now 240 px for every chat. The prompt count, the window, the pane's height, the prompts on screen (the band) and the bottom stack don't change it. Past 24 prompts its list scrolls and keeps the band in view (railScrollTop). Only a view too short for 240 px clips it (railRoom). A composer or tray that grows tall enough to reach the rail lays over its foot: the rail neither moves nor shortens (Leo, 2026-11-03: "i just don't like it when the thing shifts"). The other arms keep the old foot-shortening (railClearHeight).height.experiment.tsgainsfixed-200,fixed-240(default) andfixed-280(fixed: trueinRAIL_HEIGHTS), and theagent-pane.thread-minimap-heightgallery entry's notes describe them beside the old arms.The hover lag itself (React work per row change, the preview card) is measured separately, and its fix follows in a separate PR.
Tests
Red first (fa0b8ea), then the fix:
bun test test/thread-minimap-wave-model.test.ts: new "a sweep keeps the bump whole". On base, after one frame of a 60 Hz sweep, the row ahead has 0.18 of its length; it needs more than 0.35. Passes on head.bun test test/thread-minimap-rail.test.tsx: new "the rail is one height, the Codex rail's, whatever the prompt count or the pane's height" (1 to 1,000 prompts, 400 to 2,100 px views → 240). Fails on base (320, 450, 662, …), passes on head.bun test test/thread-minimap-rail.test.tsx: the band (1, 24, 50 and 1,000 prompts on screen) keeps 240. Fails at 8a21b18 (500 for 50), passes on head.bun test test/thread-rail-layout-box.test.tsx: the rail's box is identical with a 120 px, a 188 px and a rail-reaching stack. Fails at 8a21b18 (the height shrank), passes on head.test/thread-rail-full-height.test.tsxwas updated to the fixed box: the rows not drawn are counted through the list's gaps.test/thread-minimap*andtest/thread-rail*jsdom suites pass locally.Observed / Not run
vp fmt --checkon changed files.scripts/web-lint.shfails only on base files (pages/changelog/updateSurfaces.cssdesign token,App.tsxand others' format).Follow-ups
Review follow-ups: #35239.
Spec
design/session-rail.md"Height and overflow" (leo-workspace) should read: the compact rail is one fixed height, 240 px (the Codex rail's size), for every chat. Prompt count, window, pane height, the band and the bottom stack never change it or move it (a stack tall enough lays over its foot), and a view shorter than that clips it. Past 24 prompts its list scrolls. This replaces "starts at 320 px, grows toward 92%" (last good commit d53567b). This host can't publish to leo-workspace, so that edit follows from a lane that can.Changelog
risk:normal
🤖 Generated with Claude Code
Agent session: agent session