Repository navigation
Composer: the context ring reads as a gauge, never a spinner - #34502
Conversation
Leo read the ring at 68% as a loading spinner. Pins a visible remaining-share track and flat arc ends at 25/68/95%. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9435bc58cd1ad61a49df
…ck, never a spinner Experiment context-ring-look (gallery agent-pane.context-ring, variants gauge-25/68/95) compares track, arc (before), percent and fill-quiet; track ships. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9435bc58cd1ad61a49df
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Passes: CI passes on CI passes on Written by web and size checks: green Shipped in:
|
…ontextRing's doc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9435bc58cd1ad61a49df
|
Review (subagent opus-5.5 medium): SHIP at cc8f002 Visual verdict: the shipped arm changes only the ring's stroke attributes (track 0.3 to 0.5 opacity, flat arc ends). Its size, hit box and colour are unchanged. No captures attached. |
|
Review (codex gpt-6.1-sol xhigh, router-review): BLOCK at cc8f002 BLOCK at cc8f002 Visual verdict: no visible regression across the 16 supplied pairs; none captures the context ring.
The test regression is confirmed from source; Bun and browser dependencies were unavailable for execution. |
composer-turn-cycle counts any [class*="-ring"] in the quiet row besides the context wrapper and button as a spinner; the new track/used/caption classes matched it. Renamed to acpmux-context-track/used/caption. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9435bc58cd1ad61a49df
|
Review (codex, router-review): SHIP at f05d443 Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at f05d443 Visual verdict: no images; Leo tries the build
Follow-ups:
|
…t-ring-not-spinner # Conflicts: # webviews/src/experiments/registry.ts
|
Owned by an agent session · session |
|
Webview verdict at adaac5d: its one "new" red,
This PR changes only the context ring's look. Landing on the SHIPs at adaac5d (base merge of the reviewed f05d443). |
…t-ring-not-spinner
|
Found 8 test failures on Blacksmith runners: Failures
|
…t-ring-not-spinner # Conflicts: # webviews/src/experiments/registry.ts
|
Review (codex gpt-6-astra high, router-review): BLOCK at 357b2ed BLOCK at 357b2ed Visual verdict: All 16 supplied pairs reviewed; differences are limited to spinner animation phases. None shows the changed context ring.
Follow-ups:
|
Base's #34775 moved the empty ring from disabled to aria-disabled so its right-click menu still opens. bun test test/context-ring-gauge.test.tsx: 5 pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9435bc58cd1ad61a49df
|
Finding outcome: comment-6625524849/F1 fixed f9588eb |
|
Review (codex, router-review): SHIP at f9588eb Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at f9588eb Static review of the ring rendering, experiment wiring, gallery entry, and tests found no correctness or regression issues.
Follow-ups: F1 — provide gallery captures for the changed context-ring variants. |
|
Finding outcome: comment-6625788376/F1 filed-follow-up #35104 |
|
Review (codex gpt-6-astra high, carried from f9588eb): SHIP at ef61283 Carried: ef61283 is cmux-bot's base merge of feat-cmux-next. |
A newer verdict blocks ef61283 (no independent SHIP at the head).
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo, 2026-11-03, on the composer's quiet row (
5 Medium Options ⌄ ◔, the ring at about 68% used), reading the context ring as a loading spinner: "and why does it even take time to read settings? you know what things are. the read defaults/the 'not working in a project' thing that should all be instant".The ring was a faint 30% track under a round-ended arc. At about 70% and above, the faint track all but disappears at 12 px and the round-ended arc reads as a spinner's. This PR keeps the ring (Claude desktop's look, 12 px glyph in its 22 px hit box, static) but draws the remaining share as a clearly visible track (50% of the arc's ink) and gives the arc flat ends, so the whole circle reads as one gauge with no gap. Never a pie; the ring still never animates.
Spec: leo-workspace
design/composer.md(a rule is added there in a companion PR).Variants (experiment
context-ring-look, galleryagent-pane.context-ring, new variantsgauge-25,gauge-68,gauge-95)track(shipped): remaining share as a visible track at 0.5 opacity, flat arc ends.arc(before): faint 0.3 track, round arc ends.percent: the before ring plus a68%caption in--text-captionbeside it.fill-quiet: thicker 2.75 stroke, flat ends, used share in--agent-textat 0.7 alpha.Pick:
track. It removes the two cues that make a static arc read as a spinner (a near-invisible track and rounded tails) while keeping Claude desktop's thin ring, size and colour.percentadds width to the quiet row and repeats the hover card's number;fill-quietis heavier than the rest of the row's line glyphs.Test
webviews/test/context-ring-gauge.test.tsx: at 25/68/95% the track's stroke-opacity is at least 0.5 and below the arc's, the arc has butt ends and the same radius as the track, nothing is filled, nothing animates; before usage the ring is the inert track alone.Command:
cmux-ci test -- bash -c 'cd webviews && bun install --frozen-lockfile >/dev/null && bun test test/context-ring-gauge.test.tsx && bun run check'webviews/srcdiff reverse-applied: the track's stroke-opacity is 0.3 (expected >= 0.5) at 25, 68 and 95%. Run: https://github.com/manaflow-ai/cmux/actions/runs/41753121253test/composer-turn-cycle.test.ts(6 pass): https://github.com/manaflow-ai/cmux/actions/runs/41767379871. At cc8f002bun run checkpassed lint, the type check and the protocol check (https://github.com/manaflow-ai/cmux/actions/runs/41755413289). Its only red wasvp fmt --check, on four files this PR does not touch (for examplecloudStartProgress.ts, red on base); this PR's files passvp fmt --check.Observed / Not run
ContextRing's doc comment). The Codex router-review at cc8f002 found that the newacpmux-context-ring-track/usedclasses matchedcomposer-turn-cycle's[class*="-ring"]spinner probe. They are renamedacpmux-context-track/used/caption, and that test passes at f05d443.Changelog
Agent session: agent session
🤖 Generated with Claude Code