Repository navigation
base red: Settings' progress fill is not a surface; the model menu's + draws at 12px - #34494
Merged
Merged
Conversation
…+ draws at 12px render.test.tsx's 'no rule declares a background other than transparent or the two interaction tokens' failed on .app-update-progress's value fill (var(--text)), added by #33176: a progress bar's value is not a container, so the test now exempts only the progress-value pseudo-elements. check-icon-scale failed on QuickModelColumns.tsx's PlusIcon at 11px (#32980, which landed an hour after the check, #33595). 12 is on the scale, matches its viewBox and the CheckIcon beside it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-dfc0ecf416bf21757d6b
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-dfc0ecf416bf21757d6b
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 4, 2026 01:24 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 4, 2026 01:39 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two webview base reds that every feat-cmux-next push run since #33176 / #32980 shows (for example 41742234192 at 842ce34 and 41745017210 at 4165f6f):
webviews/src/pages/settings/render.test.tsx"no rule declares a background other than transparent or the two interaction tokens": regressed by cmux NEXT updates: download quietly, then one Restart to Update card; progress in Settings > Updates #33176, which added.app-update-progress::-webkit-progress-valueand::-moz-progress-barwithbackground: var(--text). A progress bar's value fill is not a surface, so the test now exempts only those two progress-value pseudo-elements at that value. Containers stay checked, and the neutral bar cmux NEXT updates: download quietly, then one Restart to Update card; progress in Settings > Updates #33176 shipped stays as it is.webviews/test/check-icon-scale.test.ts: regressed by cmux next: the model menu shows harness, model, effort and account at once #32980. The model menu'sPlusIcon(QuickModelColumns.tsx) drew at 11px, off the scale. cmux next: the model menu shows harness, model, effort and account at once #32980 landed about an hour after the check itself (cmux NEXT webviews: icons draw on one scale (12/14/16/20), with a ratcheting icon-scale check #33595). The icon now draws at 12px, which is on the scale, matches its 12 viewBox and matches the CheckIcon beside it. The baseline only shrinks, so raising it isn't allowed.Model picker surface:
design/model-picker.mdsays nothing about icon size; this changes the + by 1px.Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes two webview base reds by updating the settings render test and the model menu's PlusIcon size.
::progress-valuepseudo-elements) from the surface check, since a progress bar's filled part is its value, not a surface.PlusIconnow draws at 12px instead of 11px, matching itsviewBoxand theCheckIconbeside it, and putting it back on the icon scale.Written for commit 80e0df1. Summary will update on new commits.