Repository navigation
Agent pane: an opened subagent's "Subagent of" pill gets a close button; Escape closes it - #34329
Conversation
…on; Escape closes it too Leo: "this opened subagent has no close button". The pill's × (action.close, 18px, 12px glyph, hover on the × alone, as the summary card's Subagents tab close) returns to the chat's view. Escape that no field, menu or popover took does the same. Clicking the pill's text still goes back to the parent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
|
Owned by an agent session · session |
…t-view-close # Conflicts: # webviews/src/agent-session/acpmux/subagents/subagents.css
|
Review (subagent claude opus-5.5 medium): SHIP at dd711d0 Visual verdict: no images (code verdict only) What I checked: the × goes to the chat, the pill text goes to the parent, and the hover highlight covers only the ×. Ellipsis truncation and the 44px row still hold. The Escape ordering works with the composer, the double-press stop, the transcript selection and open menus. The xcstrings file is valid with all 21 locales, and no test or gallery depends on the pill's old DOM. Follow-ups (fixed forward):
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base cf0fdde; does not block Shipped in:
|
…sits above the tab-title comment (#34339) Follow-ups from the review of #34329: with focus in Session Info or on its toggle, Escape closes Session Info, never the subagent's view, whichever listener was added first. The hook call moves out of the middle of the comment that explains the tab-title effect. Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Leo: "this opened subagent has no close button".
An opened subagent showed a centred "Subagent of · " pill and nothing else to dismiss it.
Change
action.close, 18px button, 12px glyph). It matches the close button on the summary card's Subagents tab. The hover highlight covers only the ×, not the pill.subagents/subagentEscape.ts).subagents.close("Close subagent"), translated into all 21 languages.Prior art: none of these adds a close control, so I acknowledged them all: #29885, #28696, #29794, #29608, #27575, #28537, #28133, #24093, #22643, #33280, #27930, #25201. #24093 set the pill's
<chat> · <task>text, which this keeps. The open ones (#33280, #27930, #25201) touch other parts of these files.Gallery:
subagentsentry, variantschild-close-hover,child-closeandchild-escape.Test:
webviews/test/subagent-of-close.test.tsxcovers the × going to the chat, the pill text going to the parent, the Escape filter, and the hook claiming the key.Risk: small and limited to one component. The existing
.cv-subagent-of__pillselectors used by tests and gallery steps still point at the back button.Agent session: agent session
🤖 Generated with Claude Code