Repository navigation
webviews: align artifact surfaces with design tokens - #34303
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a web and size checks: green Shipped in:
|
|
Review (claude opus-5.5 medium): SHIP at 2f5f54b Visual verdict: no images attached [follow-up]. From the code, the artifact panel is pixel-identical at interface scale 1. The render card / inline preview head shrinks by 4px. Checked: every swapped token against Follow-ups:
|
|
Found 43 test failures on Blacksmith runners: Failures
...and 33 more test failures. View all on Blacksmith
|
2f5f54b to
e4fe029
Compare
e4fe029 to
94ef459
Compare
94ef459 to
bdf34db
Compare
bdf34db to
202518c
Compare
|
Review (claude opus-5.5 medium): SHIP at 202518c Visual verdict: no images at this head; at scale 1 the result matches base except the render card head (below). [follow-up] attach before/after images. Checked each token against Follow-ups:
|
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (claude opus-5.5 medium): SHIP at 202518c
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo's words (2026-11-03): "there's just tons of design systems related stuff for spacing guttters icons etc whatever like we don't yet feel "designed" yet nawmean" and "i generally also have disliked how we have like no sense of system at ALL for ANYTHING like we're not even looking at some shadcn type stuff".
Aligns the artifact side panel and render card chrome with the shared NEXT grid: tokenized tabs, row heights, half-step spacing, card body insets and action gaps. Existing preview isolation and inline/side-panel behavior stay unchanged.
References:
apps/codex/web/artifact-viewer.webp,apps/claude/live/transcript-markdown-rendering.png.Gallery before/after variants:
agent-pane.artifact-panel,agent-pane.inline-preview,agent-pane.render-card.Validation:
bun scripts/check-ui-review.ts --shrink-allowlist;bun scripts/check-design-tokens.ts --update-baseline;git diff --check.agent-identity footer --repo manaflow-ai/cmux
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Aligns the artifact side panel and render card chrome with the shared design tokens, swapping hard-coded pixel spacing for
--grid-*and--ds-*references. Updates the design token baseline to match. Preview isolation and inline/side-panel behavior are unchanged.Written for commit 202518c. Summary will update on new commits.