Repository navigation
cmux NEXT Chief Home: the pinned Needs you card is opt-in, off by default - #34110
Conversation
…ault Leo, 2026-11-03: "I just wanted to see permission things, period, not a pinned thing by default. Toggle-on, yes, but I haven't verified the looks of that yet". Settings > Notifications > Feed > Pin Needs You in Chief (feed.needsYouInChief, off by default) turns it on; the Feed's own requests are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
|
Owned by an agent session · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: Default changesThis pull request changes 1 default at
Every change is a new setting that defaults to off, the behavior from before it existed. Merge receipt: merged as Regenerate the snapshot with Shipped in:
|
|
Fleet runs at d84c211:
|
|
Review (subagent claude-opus-5-5 medium): SHIP at d84c211 Visual verdict: unchanged by default (the card is now off by default); the look of the opt-in card is not verified. Follow-ups: (1) [follow-up] type |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
|
Found 12 test failures on Blacksmith runners: Failures
...and 2 more test failures. View all on Blacksmith: run 41704464360, run 41704466932
|
|
Review (correctness): SHIP at 4638437 The default is false in runtime, Settings and generated exports. The observation reads the setting live, reads no Feed state while disabled, and hides only the pinned section without removing requests from the Feed. The latest commit changes only five generated exports. No concrete correctness blocker found. Verification at this head: cmux-next/compile and cmux-next/fast-gates passed, as did the app compile and fleet Release compile. The previously recorded HomeNeedsYouTests run passed 7/7 at d84c211; runtime and test source is unchanged by 4638437. Full Swift tests, action exports and several web checks are still running; these are not claimed passed. The opt-in card's appearance has not been verified or approved by Leo. CI classification: PR jobs tested synthetic merge 18a87d2 against base 6f7f953. The script-test failures for profile_channel/notary_probe also fail in that base's cmux-next checks. The legacy tunnel and nightly step-coverage failures also fail in that base's release-notary job. The PR status comment's comparison used the older original base 2e9aa60. The migration wrapper is red because its plan was cancelled, not because this PR changed migrations. Remaining cancelled jobs are advisory/superseded. No red caused by this PR was found. Risk evidence passed. No unresolved review threads or open merge freezes were found; merge_freeze.py check returned 0 against the current empty freeze-issue list. Leo's explicit merge request lifts the prior permission hold. No deployment is requested. |
|
Leo: #34110 put the arch ratchet's app_lines row red (+4 CmuxNextApp lines). The fix PR moves the feed.needsYouInChief read into CmuxNextSettings (HomeNeedsYouSetting.reader) and the reveal's tab lookup into DaemonStore.tab(reported:...); the card stays off by default and switches live. |
…ir packages' (arch app_lines +4 from #34110) (#34231) #34110 (be63d3b) added 4 CmuxNextApp lines to HomeHostView+NeedsYou: the feed.needsYouInChief read with its default, and its comment. The read moves to CmuxNextSettings as HomeNeedsYouSetting.reader (the setting owns its default), and the reveal's tab lookup (tab, else terminal resource, else ACP session), which DaemonStore.place already ran inline, becomes DaemonStore.tab(reported:terminal:agentSession:) in CmuxNextDaemon, used by both. Same values and the same lookup order. CmuxNextApp -4. Co-authored-by: cmux-bot[bot] <348531757+cmux-bot[bot]@users.noreply.github.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fix-forward for #33817. Leo, 2026-11-03:
and earlier: "oh stuff yeah actually we should be able to surface permissions/multiple choice related things inside chief".
#33817 put a pinned Needs you card over every Chief conversation by default. Leo did not ask for that. This PR makes the card opt-in and off by default. Its look has not been verified or approved by Leo.
What changes
feed.needsYouInChief). Help text: "Open requests, such as permission prompts and questions, are pinned at the top of your Chief's conversation. The Feed always lists them."ObservationStream). The Debug style variants (feed.needsYouStyle: rows, cards, bar) still apply..userOnly): the person decides whether it pins over their chat.Context read (Leo's recent drafts and issues)
These describe how permission and question items surface today: in the Feed's Needs you requests, on the iPhone, and as Chief approval cards. I read them as background only; Leo's correction above decides this PR.
Testing
HomeNeedsYouTests(CmuxNextAppTests):itIsOffByDefaultAndTheSettingTurnsItOn: unset cmux.json reads off,{"feed":{"needsYouInChief":true}}reads on, and the Settings row defaults tofalse;offPinsNothingAndOnPinsTheFeedsRequestsLive: with a request waiting and the toggle off, nothing is pinned while the Feed still lists the request; turning the toggle on pins it without a restart;onlyAChiefsConversationShowsItAndOnlyWhileSomethingWaitsnow also checks that off shows nothing;Runs: see the comments below for the fleet compile (
cmux-ci compile-check --app) and theHomeNeedsYouTestssuite at the head.Settings exports (schemas/settings, docs/mdm) are regenerated by the PR autofix.
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Makes the pinned Needs you card over Chief conversations opt-in and off by default, per Leo's direction to fix forward #33817.
The card appears only when Settings > Notifications > Feed > Pin Needs You in Chief (
feed.needsYouInChief) is on. Off (the default), the Chief transcript is unchanged and the Feed still lists all requests. On, the card pins the Feed's open requests under the Chief header and switches live without a restart. The card's visual style was not verified by Leo.New Features
feed.needsYouInChiefsetting, marked.userOnlyso agents cannot turn it on for the person.CmuxNextSettings' locales.Testing
HomeNeedsYouTestscoverage for the off-by-default state, the live toggle-on path, and that nothing is pinned while the setting is off.Settings exports (
schemas/settings,schemas/defaults,docs/mdm) are regenerated.Written for commit 4638437. Summary will update on new commits.