Repository navigation
acpmux: pass result_line through bg_start_with_id so the crate compiles - #34064
teamleaderleo wants to merge 1 commit into
Conversation
#33317 added result_line to bg_start and the Spec, and #33779 moved the spawn into bg_start_with_id without it, so feat-cmux-next fails with E0425 at hub/bg_tasks.rs:160. Workflow activities start with result_line false. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
Owned by an agent session · session |
|
Review (subagent claude-opus-5-5 medium): SHIP at 124e4c1 Checked every caller of Follow-ups: none |
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (codex gpt-6.1-sol xhigh, next-review, since=20261103T171449Z): SHIP at 124e4c1
SHIP at 124e4c1
Visual verdict: no images; Leo tries the build
Checked all callers and result_line propagation through the runner; no correctness findings. Cargo checks could not be rerun because Rust tooling is unavailable.
Follow-ups: none
feat-cmux-next does not compile acpmux. The error is
E0425: cannot find value result_line in this scopeatcmux-tui/crates/acpmux/src/hub/bg_tasks.rs:160, and it breaks the fleet's cmux-tui client build, so DEV builds and captures fail at base.Cause: two merges crossed. #33317 added
result_linetobg_startand tobg_run::Spec. #33779 moved the spawn intobg_start_with_id, but that function never tookresult_line. This PR passes it through. Workflow activities start withresult_line: false, as before.Observed / Not run
cargo check -p acpmux --all-targets,cargo clippy -p acpmux --all-targets -- -D warnings, andcargo test -p acpmux bg_(15 passed).Changelog
none
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes
acpmuxcompilation onfeat-cmux-nextby passingresult_linethroughbg_start_with_id, which previously caused anE0425error and broke the fleet'scmux-tuiclient build.#33317addedresult_linetobg_startand the spawn spec, while#33779moved the spawn intobg_start_with_idwithout acceptingresult_line.result_line: false, matching previous behavior.Written for commit 124e4c1. Summary will update on new commits.