Skip to content

acpmux: pass result_line through bg_start_with_id so the crate compiles - #34064

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
acpmux-bg-start-result-line
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
acpmux-bg-start-result-line

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

feat-cmux-next does not compile acpmux. The error is E0425: cannot find value result_line in this scope at cmux-tui/crates/acpmux/src/hub/bg_tasks.rs:160, and it breaks the fleet's cmux-tui client build, so DEV builds and captures fail at base.

Cause: two merges crossed. #33317 added result_line to bg_start and to bg_run::Spec. #33779 moved the spawn into bg_start_with_id, but that function never took result_line. This PR passes it through. Workflow activities start with result_line: false, as before.

Observed / Not run

  • Red on base: two fleet DEV builds (cmux-ci jobs 0ebdb48b2ed02a402df7571a and db989754dd4d6d2377916d77) fail with E0425 in acpmux.
  • Green on this head (fleet): cargo check -p acpmux --all-targets, cargo clippy -p acpmux --all-targets -- -D warnings, and cargo test -p acpmux bg_ (15 passed).

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes acpmux compilation on feat-cmux-next by passing result_line through bg_start_with_id, which previously caused an E0425 error and broke the fleet's cmux-tui client build.

  • Two merges crossed: #33317 added result_line to bg_start and the spawn spec, while #33779 moved the spawn into bg_start_with_id without accepting result_line.
  • Workflow activities now pass result_line: false, matching previous behavior.

Written for commit 124e4c1. Summary will update on new commits.

View guided diff Turn on auto-fix

#33317 added result_line to bg_start and the Spec, and #33779 moved the spawn into
bg_start_with_id without it, so feat-cmux-next fails with E0425 at
hub/bg_tasks.rs:160. Workflow activities start with result_line false.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 124e4c1: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr34064 -f ref=acpmux-bg-start-result-line -f platform=macos -f backend_mode=local

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at 124e4c1

Checked every caller of bg_start_with_id in cmux-tui/crates/acpmux (only bg_start and the workflow activity) and its one bg_run::Spec construction: result_line now goes from the RPC's resultLine param through bg_start and bg_start_with_id into Spec, and workflow activities pass false, the same as before #33779. The too_many_arguments allow is needed for clippy -D warnings and is harmless.

Follow-ups: none

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 3, 2026

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (codex gpt-6.1-sol xhigh, next-review, since=20261103T171449Z): SHIP at 124e4c1

SHIP at 124e4c1

Visual verdict: no images; Leo tries the build

Checked all callers and result_line propagation through the runner; no correctness findings. Cargo checks could not be rerun because Rust tooling is unavailable.

Follow-ups: none

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Duplicate of #34053 (merged as e3bb5b2), closing.

@teamleaderleo
teamleaderleo deleted the acpmux-bg-start-result-line branch November 3, 2026 17:21

This branch was previously deployed

3 inactive deployments
artifacts — 124e4c1b Deployed Nov 3, 2026 by teamleaderleo via publish tree-addressed cmux-tui #106910
sentry-dsyms — 124e4c1b Deployed Nov 3, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #106910
ci-routing-agent — 124e4c1b Deployed Nov 3, 2026 by teamleaderleo via cmux-tui tree preflight #106910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant