Repository navigation
acpmux: thread result_line through bg_start_with_id (base compile red) - #34058
Conversation
…#33347 met #33779) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41680509635 at 2b865bc failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
Owned by an agent session · session |
Fixes a base compile red.
feat-cmux-nextstopped compiling the acpmux library athub/bg_tasks.rs:160(cannot find value result_line in this scope). Every fleet Release compile from 7da5453 onward has failed with it, including PR heads that merge the current base.Cause: two PRs that each compiled on their own. #33779 moved the body of
bg_startinto a newbg_start_with_id, which has noresult_lineparameter. #33347 addedresult_lineto that body. After both landed,bg_starttakesresult_linebut never passes it on.Fix:
bg_start_with_idtakesresult_lineandbg_startpasses it through. The workflow caller (workflow_activity.rs) passesfalse, which is what its launch got before #33347. This is the minimal fix, so it also carries#[allow(clippy::too_many_arguments)], as other hub methods do.cmux-ci on fleet Linux:
cargo clippy -p acpmux --lib -D warningsis clean, andcargo test -p acpmux --lib -- bg_ workflowhas 103 passed, 0 failed.Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the acpmux compile red on
feat-cmux-nextby threadingresult_linethroughbg_start_with_id.Two PRs that each compiled on their own broke the build after landing: one moved the body of
bg_startintobg_start_with_idwithout aresult_lineparameter, and the other addedresult_lineto that body. The fix givesbg_start_with_idaresult_lineparameter and hasbg_startpass it through. The workflow caller inworkflow_activity.rspassesfalse, matching its behavior before the parameter was introduced. Clippy and bg workflow tests pass locally.Written for commit b0990fe. Summary will update on new commits.