Skip to content

base red: acpmux bg_start passes result_line through bg_start_with_id (cmux-tui compiles again) - #34054

Closed
lawrencecchen wants to merge 1 commit into
feat-cmux-nextfrom
fix/base-red-acpmux-result-line
Closed

lawrencecchen wants to merge 1 commit into
feat-cmux-nextfrom
fix/base-red-acpmux-result-line

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Base red on feat-cmux-next: cmux-tui does not compile. crates/acpmux/src/hub/bg_tasks.rs:160: cannot find value result_line in this scope.

Cause: a semantic merge of two PRs. #33347 (06fa0ed) added a result_line parameter to Hub::bg_start and put it into the task Spec. #33779 and #33982 had moved the body of bg_start into bg_start_with_id, which has no result_line. Each PR compiled alone. Together they do not.

Fix: bg_start_with_id takes result_line and bg_start passes it through. The workflow's machine task (workflow_activity.rs, the only other caller) passes false, so its behavior stays as before #33347.

Testing

  • Compile-check job acbcf1a8e7a776abfb0b4450 at b19fc01: CmuxNext passed, app passed, cmux-tui passed.
  • On feat (compile-check job 501d7bf473dfd6ad57c36281): cmux-tui failed with the error above.

Observed / Not run

  • Observed: the compile checks above.
  • Not run: the acpmux test suite (cargo test); the change only threads a flag through one function.

Changelog

none

Proof

No capture: build fix.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes a compile error in cmux-tui caused by a semantic merge of two PRs: one added a result_line parameter to bg_start, and another moved the body into bg_start_with_id, which lacks that parameter.

bg_start_with_id now takes result_line and bg_start passes it through. The workflow's machine task passes false, so its behavior is unchanged.

Written for commit b19fc01. Summary will update on new commits.

View guided diff Turn on auto-fix

…, so cmux-tui compiles again (a semantic merge of #33347, which added result_line to bg_start, and #33779/#33982, which moved bg_start into bg_start_with_id; the workflow's machine task passes false)
@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review b19fc01: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr34054 -f ref=fix/base-red-acpmux-result-line -f platform=macos -f backend_mode=local

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 3, 2026
@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Duplicate of #34053 (opened 2.5 min earlier, byte-identical diff, already has a SHIP at its head). My compile-check of the same change, job acbcf1a8e7a776abfb0b4450 at b19fc01: CmuxNext, app and cmux-tui passed. Closing this one so only #34053 lands.

This branch was previously deployed

3 inactive deployments
artifacts — b19fc011 Deployed Nov 3, 2026 by lawrencecchen via publish tree-addressed cmux-tui #106855
sentry-dsyms — b19fc011 Deployed Nov 3, 2026 by lawrencecchen via upload cmux-tui dSYMs to Sentry #106855
ci-routing-agent — b19fc011 Deployed Nov 3, 2026 by lawrencecchen via cmux-tui tree preflight #106855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant