Repository navigation
base red: acpmux bg_start passes result_line through bg_start_with_id (cmux-tui compiles again) - #34054
Closed
lawrencecchen wants to merge 1 commit into
Closed
base red: acpmux bg_start passes result_line through bg_start_with_id (cmux-tui compiles again)#34054lawrencecchen wants to merge 1 commit into
lawrencecchen wants to merge 1 commit into
Conversation
lawrencecchen
temporarily deployed
to
artifacts
November 3, 2026 16:51 — with
GitHub Actions
Inactive
lawrencecchen
temporarily deployed
to
sentry-dsyms
November 3, 2026 16:51 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
Contributor
Author
lawrencecchen
temporarily deployed
to
artifacts
November 3, 2026 16:58 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base red on feat-cmux-next: cmux-tui does not compile.
crates/acpmux/src/hub/bg_tasks.rs:160: cannot find valueresult_linein this scope.Cause: a semantic merge of two PRs. #33347 (06fa0ed) added a
result_lineparameter toHub::bg_startand put it into the taskSpec. #33779 and #33982 had moved the body ofbg_startintobg_start_with_id, which has noresult_line. Each PR compiled alone. Together they do not.Fix:
bg_start_with_idtakesresult_lineandbg_startpasses it through. The workflow's machine task (workflow_activity.rs, the only other caller) passesfalse, so its behavior stays as before #33347.Testing
Observed / Not run
Changelog
none
Proof
No capture: build fix.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes a compile error in
cmux-tuicaused by a semantic merge of two PRs: one added aresult_lineparameter tobg_start, and another moved the body intobg_start_with_id, which lacks that parameter.bg_start_with_idnow takesresult_lineandbg_startpasses it through. The workflow's machine task passesfalse, so its behavior is unchanged.Written for commit b19fc01. Summary will update on new commits.