Repository navigation
fix(acpmux): bind cached remote receipts to local reservations - #34045
Conversation
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b5794201d7e16745a0a4
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b5794201d7e16745a0a4
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (subagent claude-opus-5-5 medium): SHIP at c3cef98 Security read of What I checked:
CI: the failing jobs (acpmux lib tests, clippy, Windows cargo check, IR, SDK conformance) all fail at the cmux-tui compile step. That matches the base compile break that #34053 is fixing, not this diff. The new test still needs a green run once base compiles. Follow-ups:
|
A remote durable dispatch response is cached only against the local reservation that requested it.
cache_remotenow requires the peer row to carry the requestedbriefIdanddurable:true, validates both the local and peer identities, and merges peer result fields onto the locally owned reservation. Host, caller, session, prompt, fingerprint, and other routing/security fields cannot be replaced by peer-controlled values.Regression coverage rejects a mismatched peer key, rejects an advisory downgrade, preserves the local host/caller and dispatch-local boundary, preserves an existing victim row, and keeps a finished receipt terminal when a late pending response arrives. This fixes the blocking finding from review 5755116810 carried from the inherited cache path.
Validation: final fleet run 41677423510 passed formatting, the new cache_remote regression, terminal replay coverage, all three
dispatch_durableintegration tests, and strict acpmux lib clippy. The base compile blocker was repaired by #34053 (merged ase3bb5b2e357986d16086b1ef497401b12d72b94c).Independent review: Opus 5.5 medium SHIP at c3cef983.
Review follow-ups: reject a null outcome as terminal, preserve cleanup eligibility for error-only terminal rows, and avoid rewriting an unchanged terminal ledger row.
Leo asked on 2026-11-02: "go do all those/help out where you can + examine how you can improve yourself and your available options and capabilities and speed".
Leo-ask: ask-6ef2624788
🤖 Generated with Codex
Agent session: agent session