[manaflow-cmux-ffi-release]

Pins CCmuxAppFFI to cmux-app-ffi-1f0abddf9f2ffad7dc2e996b68a9f7a5c5417bdd (checksum 1d59defc46dfc67070450c474b4a33aeb71fe49edf258ebc4495e81829ab5784), published by run https://github.com/manaflow-ai/cmux/actions/runs/41763425088, which checked it with check-app-ffi-pin.sh --verify-release. A newer publish updates this branch.

Changelog

none

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 4cf307a: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33988 -f ref=app-ffi-repin -f platform=macos -f backend_mode=local

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4177399658201 (443d56f95d)
• cmux NEXT nightly 1.0.0-nightly.4177479261801 (0df62819ad)

[teamleaderleo]

Review (subagent opus medium): SHIP at 4cf307a

Visual verdict: unchanged by this diff (no UI).
The diff touches Package.swift only: URL and checksum for cmux-app-ffi-1f0abddf9f2f. At this head, check-app-ffi-pin.sh --verify-release passes: the sources match 1f0abdd, and the release's SOURCE_SHA and SHA256SUMS match the pin (checksum 1d59defc…5784). No FFI input changed on feat-cmux-next after 1f0abdd. This clears the base red in the "Check the app FFI pin" step of cmux-next checks, which went stale with #34052 and #34507. (The PR title still names 427dd19 because the bot's update step failed on the rate limit after it pushed.)

Follow-ups: none

[lawrencecchen]

A note from REWRITE R-INPUT (helping this re-pin land, as the lead asked). I corrected the title and body; the head did not change.

• The head 4cf307a pins cmux-app-ffi-1f0abddf9f2f. The publish run 41763425088 built, verified and pushed it ("sources match 1f0abdd", "release built from 1f0abdd"), then stopped on its last check, "the re-pin head moved", before it could update this PR's title and body. Those still named the 427dd19 release, so I set them to what the head pins, in the publish script's own wording.
• feat-cmux-next (07ddfa8) has no app FFI source change after 1f0abdd (check-app-ffi-pin.sh --list-inputs, then git diff 1f0abddf9f2f..feat), so this pin is current.
• Non-green checks at 4cf307a:
  • cmux-next crash-class rules: a base finding. It fails "Chromium Objective-C contract", because the contract names CEF cmux.38 while the pinned engine is cmux.43. base red: Chromium ObjC contract for cef-156.0.15-cmux.43 #34674 fixed that on feat at 03:29Z, after this branch's base (aed6e9a, 03:21Z).
  • tooling-tests: a base finding (the web-lint pre-push fixture red seen on other PRs).
• An independent review of the head follows.

[lawrencecchen]

Review (independent subagent, correctness first): SHIP at 4cf307a
perf claim: none
R9: pass (no limit, queue or deadline is touched)

Post-merge confirmation. #33988 merged at 04:27:09Z, at this head, while I reviewed it. It merged on the earlier receipt at 03:57Z. The squash commit d2d1a67 on feat-cmux-next has exactly the two pin lines checked below. I compiled nothing on this machine.

Findings

None.

Checked

• The diff: one commit, by manaflow-cmux-ffi-release[bot] (committer: GitHub). Its parent aed6e9a is on feat.
  • The diff is Packages/macOS/CmuxNext/Package.swift only: the url and checksum of CCmuxAppFFI, which move from cmux-app-ffi-d3d3f420820f to cmux-app-ffi-1f0abddf9f2ffad7dc2e996b68a9f7a5c5417bdd and checksum 1d59defc46dfc67070450c474b4a33aeb71fe49edf258ebc4495e81829ab5784.
  • Feat did not touch Package.swift after the parent.
• The release: I downloaded every asset anonymously, with no token.
  • SOURCE_SHA is 1f0abdd.
  • SHA256SUMS has exactly the line 1d59defc…784 CCmuxAppFFI.xcframework.zip. That is the same test as check-app-ffi-pin.sh --verify-release.
  • The archive itself hashes to the pinned checksum (15,745,578 bytes).
  • The release was published by manaflow-cmux-ffi-release[bot]. Its tag points at commit 1f0abdd.
  • The four C headers in the archive (layout reducer, motion, rd, palette ranker) are byte-equal to the repository's headers at 1f0abdd.
• The publish run 41763425088 (push of 1f0abdd to feat):
  • The build, its tests (reducer, rd FFI, palette ranker), the Linux cross-compile parity check and the publish job ("never overwrite", "Anonymous download matches the checksum") all passed.
  • The re-pin step printed app FFI pin: sources match 1f0abddf… and app FFI pin: release built from 1f0abddf… with checksum 1d59defc…. It pushed 4cf307a to app-ffi-repin, and only then failed: the re-pin head moved.
  • The PR title and body name the head's pin.
• The sources:
  • check-app-ffi-pin.sh --list-inputs at feat tip 3524c6f gives 16 inputs (14 crates through Cargo path dependencies, the toolchain file and build-app-ffi.sh).
  • git diff --stat 1f0abddf9f2f over those inputs is empty at the feat tip, at this head and at the squash commit d2d1a67.
  • The input list itself has the same Cargo.toml files and the same check-app-ffi-pin.sh at the head and at the feat tip.
• What this re-pin ships: from d3d3f42 to 1f0abdd, two commits change the inputs:
  • R-INPUT S1: the one input router in cmux-focus-core (core, lanes, sessions, dialogs, page-first chords), Rust only #34052, the R-INPUT router: Rust only, no caller yet, and the FFI decode sets terminal: None.
  • feat(tab-drag): expose index and reveal rules over app FFI #34507, tab-drag rules: new C functions cmux_tab_move_* and cmux_drop_reveal_decide. No Swift code calls them yet.
  • So the app's behavior does not change with this pin.
• Compile: cmux-next app compile (build fleet) passed, fleet job 9b07cbd1fbd5bc143b76d745 at this sha (log read). The app package built and linked cmux-next-exe against libcmux_app_ffi.a ("Build complete! (84.37s)").
• Non-green checks, all base findings, not this pin's:
  • cmux-next crash-class rules: chromium-objc-contract.json reviewed_for is cef-154.0.34-cmux.38, but the pinned engine is cef-156.0.15-cmux.43. The PR does not touch the engine pin or the contract. At the base aed6e9a, the contract still says cmux.38. base red: Chromium ObjC contract for cef-156.0.15-cmux.43 #34674 (8c1d739, 03:29Z, after the base) moved feat to cmux.43.
  • tooling-tests: test_the_type_check_covers_every_webviews_test_file fails on webviews/bench/replayLogs.test.ts, which the webviews tsconfig roots (src, test, dev-server) do not cover. That file came from bench(web-ui): transcript replay harness: acpmux logs at top speed, shift, per-token slope, long tasks, heap, idle #34382 and is on the base and the feat tip. base red: clippy -D warnings in cmux-wg-tun utun.rs and acpmux repo_sync_tests.rs #34733 and R-INPUT S1: the one input router in cmux-focus-core (core, lanes, sessions, dialogs, page-first chords), Rust only #34052 fail the same test.
  • cmux-next daemon tests (it failed after the request was sent): it failed at "Build package and tests" on self-hosted runner cmux9s-mac-mini-glaeda-5, because of SwiftPM's artifact cache: failed downloading … sentry-cocoa 9.28.0 … already exists in file system, for three Sentry archives. The CCmuxAppFFI archive was not among the failures. This is a runner cache fault: rerun it on the same sha.

Not verified

• cmux-next swift test was still pending when I posted.
• I did not run the app.