Update Ghostty for iOS manual IO - #3394
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughGhostty submodule pointer updated to commit Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 8 minutes and 53 seconds.Comment |
0bdd811 to
b4991eb
Compare
Makes 22fa801 reachable from fork main for manaflow-ai/cmux#3394.
b4991eb to
79eea77
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Greptile SummaryThis PR bumps the Ghostty submodule from Confidence Score: 4/5Safe to merge after correcting the pinned fork head SHA in the documentation intro Single P1 finding: the docs/ghostty-fork.md — the intro SHA should be Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR #53 merged into\nmanaflow-ai/ghostty main\nmerge commit: 1eafdc6a3] -->|contains patch commit| B[22fa801f8\nExpose manual embedded IO for iOS]
B -->|submodule pinned to| C[cmux ghostty submodule\n22fa801f88f96fa842e54ecce6c34a5d36003d19]
C -->|xcframework release tagged| D[xcframework-22fa801f88f96fa842e54ecce6c34a5d36003d19]
D -->|SHA-256 pinned in| E[scripts/ghosttykit-checksums.txt\n8d7da0bb...3c724a65]
C -->|documented in| F[docs/ghostty-fork.md]
F -->|intro header says| G["Current cmux pinned fork head: 1eafdc6a3\n⚠️ should be 22fa801f8"]
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ghostty`:
- Line 1: The parent commit pointer references SHA
22fa801f88f96fa842e54ecce6c34a5d36003d19 which only exists on the temporary
branch cmux-ios-manual-io-minimal-clean-20260501 and PR `#53`; before updating the
submodule pointer in the parent repo, push that commit to the fork main branch
(manaflow-ai/ghostty main) so the SHA is reachable, then update the submodule
pointer to that main commit and re-run the submodule update/commit in the parent
repo; ensure the pushed commit on manaflow-ai/ghostty main contains the same
tree as the temporary branch SHA to avoid dangling references.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3cfcb785-30d7-49b9-9987-5b9da307e76f
📒 Files selected for processing (3)
docs/ghostty-fork.mdghosttyscripts/ghosttykit-checksums.txt
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/ghostty-fork.md">
<violation number="1" location="docs/ghostty-fork.md:16">
P3: The pinned fork head in this header should match the actual submodule SHA. Using `1eafdc6a3` here is inconsistent with the pinned commit (`22fa801f8`) and makes pin verification misleading.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This branch was successfully deployed
1 participant
Summary
Verification
zig build testinghostty/CMUX_GHOSTTYKIT_NO_PREBUILT=1 ./scripts/ensure-ghosttykit.sh./scripts/reload.sh --tag gtyioRelated
Dogfood
Please dogfood the tagged macOS build before this is marked ready. This PR does not contain the new iOS app yet, so there is no iOS reload script in this worktree.
Summary by CodeRabbit
Documentation
Chores