Repository navigation
Improve Dock agent prompt docs - #3393
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI as "cmux CLI"
participant Agent
participant FS as "Repo /.cmux or ~/.config"
participant UI as "Dock UI"
User->>CLI: run `cmux docs dock` or read docs
CLI-->>User: show docs, schema, examples
Agent->>CLI: consult docs/suggested prompt
Agent->>FS: write/update `.cmux/dock.json` or `~/.config/cmux/dock.json`
FS-->>Agent: file write result
Agent->>User: present JSON + per-control summary & commands to review
User->>UI: open Dock
UI->>FS: load nearest project or global `dock.json`
UI-->>User: render controls / request trust confirmation if required
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Greptile SummaryThis PR adds
Confidence Score: 3/5Safe to merge from a runtime/CLI perspective, but the localization regression affects all non-English users of the Dock docs web page. All Swift and CLI changes are correct and consistent. The P1 localization regression — six user-facing strings regressed to English across ~16 non-English locale JSON files — is a present defect visible to real users, pulling the score below the P1 ceiling of 4. All web/messages/*.json files except en.json need translated strings for: projectConfig, globalConfig, precedenceCallout, exampleIntro, sharingGlobal, and agentPromptIntro. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User opens empty Dock] --> B[DockEmptyView shows agent prompt]
B --> C{cmux CLI available?}
C -- Yes --> D[Run: cmux docs dock]
C -- No --> E[Read: https://cmux.com/docs/dock]
D --> F[Inspect project type, scripts, tooling]
E --> F
F --> G{Dock config ambiguous?}
G -- Yes --> H[Ask user what to monitor]
G -- No --> I{In a repo / project dir?}
H --> I
I -- Yes --> J[Write .cmux/dock.json]
I -- No --> K[Write ~/.config/cmux/dock.json]
J --> L[Validate JSON]
K --> L
L --> M[Summarize controls for user review]
M --> N[User trusts config → Dock loads controls]
|
431a513 to
79250ca
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (9)
docs/cli-contract.md (1)
276-282:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd explicit
docs dockcontract and probe entries.
cmux docs --helpnow advertisesdock, but the Docs topics contract table and no-socket probes still don’t explicitly covercmux docs dock. Please add both so this new topic is contract-protected.Proposed doc update
## Docs topics: @@ | `docs browser` | Print browser automation docs and raw browser skill resources. | | `docs agents` | Print agent integration docs and raw integration resources. | +| `docs dock` | Print Dock docs URL, raw dock resources, config paths/precedence, and validation commands. | @@ - `cmux docs --help` -> `Usage: cmux docs [settings|shortcuts|api|browser|agents|dock]` - `cmux docs` -> `Topics:` +- `cmux docs dock` -> `Dock config files:` - `cmux docs settings` -> `Settings files:`Based on learnings: CLI help and contract strings are golden-tested and should be explicitly preserved in the contract/probe docs.
Also applies to: 308-311
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/cli-contract.md` around lines 276 - 282, Add an explicit "docs dock" entry wherever the Docs topics contract table is defined (the same table that lists `docs`, `docs settings`, `docs shortcuts`, etc.) so the contract row reads like the others (a backtick-wrapped command and a short description for `docs dock` matching the `cmux docs --help` text), and also add a corresponding no-socket probe entry in the no-socket probes section (the section that lists probes for `docs` topics) so the probe explicitly covers `cmux docs dock`; ensure the wording exactly matches the advertised CLI help string so golden tests remain stable.web/messages/pt-BR.json (1)
651-674:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winTranslate the new Dock strings in
pt-BRinstead of falling back to English.The updated
docs.dock.*entries here are English, which leaves the Dock docs and agent prompt partially untranslated for Brazilian Portuguese users. Please restore localized copy for these changed strings, or defer the copy refresh in this locale until translation is available. Based on learnings: only the explicitly high-confidence locales — includingpt-BR— are expected to contain fully translated copy for strings changed in a PR.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/pt-BR.json` around lines 651 - 674, The pt-BR locale has several docs.dock strings left in English (e.g., "exampleIntro", "agentPromptIntro", "agentPromptCodeTitle", "agentPrompt", "agentPromptTitle", "agentPromptIntro", "agentPromptCodeTitle", "agentPrompt" and any other newly added docs.dock.* keys) — replace these English values with Portuguese translations or, if translations are not yet available, revert them to the previous translated values or mark them as TODO/UNTRANSLATED to avoid shipping English fallback; locate and update the JSON entries for the keys named above in web/messages/pt-BR.json so the Dock docs and agent prompt are fully localized for pt-BR.web/messages/uk.json (1)
736-759:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winKeep the Ukrainian Dock docs fully localized.
These updated
docs.dock.*values were replaced with English, so Ukrainian users now get a mixed-language Dock page and agent prompt. Please translate the refreshed copy here, or keep the previous Ukrainian text until the new translation is ready. Based on learnings: only the explicitly high-confidence locales — includinguk— are expected to contain fully translated copy for strings changed in a PR.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/uk.json` around lines 736 - 759, Several Dock-related strings were left in English (e.g., "agentPromptIntro", "agentPrompt", "agentPromptCodeTitle", "agentPromptTitle", "sharingGlobal", "exampleIntro", and "precedenceCallout") causing mixed-language UX; restore full Ukrainian localization by replacing the English copy with Ukrainian translations or revert these keys to the previous Ukrainian strings until a vetted translation is available. Locate the keys agentPromptIntro, agentPrompt, agentPromptCodeTitle, agentPromptTitle, sharingGlobal, exampleIntro, and precedenceCallout in the messages bundle and update their values to Ukrainian (or reapply the prior Ukrainian values from version control) ensuring punctuation and escaped backticks remain consistent and the JSON stays valid. Ensure the translated text preserves technical terms and instructions (commands, paths, and JSON schema examples) and run a JSON parse check after editing.web/messages/no.json (1)
651-674:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRestore localized Dock copy for the Norwegian locale.
These updated
docs.dock.*values were switched to English, so the Norwegian Dock page now mixes localized UI with English config guidance and the agent prompt. Please translate the new copy here, or keep the previous Norwegian text until the update is ready. Based on learnings: only the explicitly high-confidence locales — includingno— are expected to contain fully translated copy for strings changed in a PR.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/no.json` around lines 651 - 674, The Norwegian locale copy for the Dock docs was replaced with English for several keys (e.g., "precedenceCallout", "trustCallout", "exampleIntro", "agentPromptTitle", "agentPrompt", "agentPromptCodeTitle" and other docs.dock.* entries); restore proper Norwegian translations (or revert these keys to the prior Norwegian strings) so the no.json values are fully localized, ensure the long multi-line "agentPrompt" content is translated and preserves the same instructions/formatting, validate the JSON remains well-formed, and keep the original intent of keys like "exampleIntro", "fieldsTitle", "sharingIntro", and "Deliverable" while updating only the string values for the listed docs.dock.* keys.web/messages/it.json (1)
651-674:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winTranslate the new Dock copy in the Italian locale.
These updated
docs.dock.*values are still in English (projectConfig,globalConfig,precedenceCallout,exampleIntro,sharingGlobal,agentPromptIntro, andagentPrompt). Init.json, that will show mixed-language docs/UI for a high-confidence locale.Based on learnings: only lower-confidence locales intentionally use English fallback;
itis one of the explicitly high-confidence locales expected to contain translated copy for changed strings.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/it.json` around lines 651 - 674, The Italian locale file left several new docs.dock.* strings untranslated; update the keys projectConfig, globalConfig, precedenceCallout, exampleIntro, sharingGlobal, agentPromptIntro, and agentPrompt in web/messages/it.json to proper Italian translations (keep original meaning and any inline code/backticks/JSON schema intact), ensuring punctuation and tone match surrounding entries like trustCallout and fieldsTitle, and validate JSON after editing.web/messages/ru.json (1)
651-674:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winTranslate the new Dock copy in the Russian locale.
The newly added
docs.dock.*strings here are still English (projectConfig,globalConfig,precedenceCallout,exampleIntro,sharingGlobal,agentPromptIntro, andagentPrompt). Forru.json, that means the Dock docs will regress to mixed-language content in a locale that is expected to be translated.Based on learnings: only lower-confidence locales intentionally keep English fallback;
ruis one of the explicitly high-confidence locales expected to contain translated copy for changed strings.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/ru.json` around lines 651 - 674, The listed docs.dock.* strings in ru.json are still English—update the values for the keys "projectConfig", "globalConfig", "precedenceCallout", "exampleIntro", "sharingGlobal", "agentPromptIntro", and "agentPrompt" with proper Russian translations while preserving JSON formatting and existing punctuation/escaping (keep the surrounding quotes and newlines in "agentPrompt" intact); locate these keys in the existing ru.json block (same object that contains "exampleTitle", "fieldsTitle", etc.) and replace only the English text for those keys so the rest of the file and other translations remain unchanged.web/messages/fr.json (1)
651-674:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winTranslate the new Dock copy before shipping the French locale.
Lines 651-674 add several Dock strings in English, so the French docs will render as a mixed-language page. Please localize these new values or intentionally fall back the whole section instead of mixing translated and untranslated copy.
Based on learnings: only the explicitly high-confidence locales—en, de, fr, es, ja, ko, zh-Hans, zh-Hant, pt-BR, ru, it, pl, uk, tr, da, no—are expected to contain fully translated copy for strings changed in a given PR.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/fr.json` around lines 651 - 674, The French locale file contains new English strings that must be localized or intentionally fallback; update the entries agentPromptTitle, agentPromptIntro, agentPromptCodeTitle, agentPrompt and the English sentences under sharingGlobal, exampleIntro, precedenceCallout, trustCallout (and any other English values added in this diff) with proper French translations, or replace the entire Dock block with a single intentional-fr fallback message; edit the keys shown (agentPromptTitle, agentPromptIntro, agentPromptCodeTitle, agentPrompt, sharingGlobal, exampleIntro, precedenceCallout, trustCallout, etc.) in web/messages/fr.json so the file no longer mixes English and French.web/messages/zh-TW.json (1)
651-674:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winKeep the Traditional Chinese Dock docs fully localized.
Lines 651-674 leave the new Dock guidance in English, which will show mixed-language content in
zh-TW. Please translate these new strings or defer the locale update until the whole Dock block is ready in Traditional Chinese.Based on learnings: only the explicitly high-confidence locales—en, de, fr, es, ja, ko, zh-Hans, zh-Hant, pt-BR, ru, it, pl, uk, tr, da, no—are expected to contain fully translated copy for strings changed in a given PR.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/zh-TW.json` around lines 651 - 674, The zh-TW locale contains several new Dock strings left in English; translate them into Traditional Chinese (or revert the locale change) so the zh-TW file stays fully localized. Update the keys shown in the diff—agentPromptTitle, agentPromptIntro, agentPromptCodeTitle, agentPrompt, sharingIntro, sharingGlobal (and any other new Dock strings around that block such as exampleIntro, precedenceCallout, trustCallout, exampleTitle, fieldsTitle, sharingTitle, sharingProject, sharingSecrets)—by providing Traditional Chinese translations that match the existing tone and terminology, or remove/keep the English strings out until a full zh-TW translation is ready. Ensure translations preserve placeholders and code snippets exactly (e.g., `cmux docs dock`, `.cmux/dock.json`, `~/.config/cmux/dock.json`, JSON schema) and validate the JSON after editing.web/messages/de.json (1)
651-674:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFinish localizing the updated Dock section in German.
Lines 651-674 introduce multiple English strings into
de.json, so the Dock docs will switch languages mid-section. Please translate the new copy before merge, or keep the entire block on the previous localized wording until the German update is ready.Based on learnings: only the explicitly high-confidence locales—en, de, fr, es, ja, ko, zh-Hans, zh-Hant, pt-BR, ru, it, pl, uk, tr, da, no—are expected to contain fully translated copy for strings changed in a given PR.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/de.json` around lines 651 - 674, The de.json contains untranslated English strings introduced in this block—translate the keys "sharingGlobal", "exampleIntro", "agentPromptTitle", "agentPromptIntro", "agentPromptCodeTitle", and "agentPrompt" into German to match the rest of the file; keep JSON quoting, backticks, code examples, and any inline commands exactly as-is, preserve placeholders and formatting/line breaks, and match the existing tone and terminology used elsewhere in the German file (e.g., use "Dock", "cmux", and "Konfiguration" consistently).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/messages/ja.json`:
- Around line 805-807: The Japanese locale file contains English text for the
keys "projectConfig", "globalConfig", and "precedenceCallout" (and similar
strings at the nearby keys referenced: lines around 810, 823, 826-828); replace
those English strings with their correct Japanese translations so the ja.json
remains fully Japanese, making sure you update the exact JSON keys
("projectConfig", "globalConfig", "precedenceCallout", plus the other affected
keys at the mentioned nearby lines) and preserve JSON formatting and
punctuation.
---
Outside diff comments:
In `@docs/cli-contract.md`:
- Around line 276-282: Add an explicit "docs dock" entry wherever the Docs
topics contract table is defined (the same table that lists `docs`, `docs
settings`, `docs shortcuts`, etc.) so the contract row reads like the others (a
backtick-wrapped command and a short description for `docs dock` matching the
`cmux docs --help` text), and also add a corresponding no-socket probe entry in
the no-socket probes section (the section that lists probes for `docs` topics)
so the probe explicitly covers `cmux docs dock`; ensure the wording exactly
matches the advertised CLI help string so golden tests remain stable.
In `@web/messages/de.json`:
- Around line 651-674: The de.json contains untranslated English strings
introduced in this block—translate the keys "sharingGlobal", "exampleIntro",
"agentPromptTitle", "agentPromptIntro", "agentPromptCodeTitle", and
"agentPrompt" into German to match the rest of the file; keep JSON quoting,
backticks, code examples, and any inline commands exactly as-is, preserve
placeholders and formatting/line breaks, and match the existing tone and
terminology used elsewhere in the German file (e.g., use "Dock", "cmux", and
"Konfiguration" consistently).
In `@web/messages/fr.json`:
- Around line 651-674: The French locale file contains new English strings that
must be localized or intentionally fallback; update the entries
agentPromptTitle, agentPromptIntro, agentPromptCodeTitle, agentPrompt and the
English sentences under sharingGlobal, exampleIntro, precedenceCallout,
trustCallout (and any other English values added in this diff) with proper
French translations, or replace the entire Dock block with a single
intentional-fr fallback message; edit the keys shown (agentPromptTitle,
agentPromptIntro, agentPromptCodeTitle, agentPrompt, sharingGlobal,
exampleIntro, precedenceCallout, trustCallout, etc.) in web/messages/fr.json so
the file no longer mixes English and French.
In `@web/messages/it.json`:
- Around line 651-674: The Italian locale file left several new docs.dock.*
strings untranslated; update the keys projectConfig, globalConfig,
precedenceCallout, exampleIntro, sharingGlobal, agentPromptIntro, and
agentPrompt in web/messages/it.json to proper Italian translations (keep
original meaning and any inline code/backticks/JSON schema intact), ensuring
punctuation and tone match surrounding entries like trustCallout and
fieldsTitle, and validate JSON after editing.
In `@web/messages/no.json`:
- Around line 651-674: The Norwegian locale copy for the Dock docs was replaced
with English for several keys (e.g., "precedenceCallout", "trustCallout",
"exampleIntro", "agentPromptTitle", "agentPrompt", "agentPromptCodeTitle" and
other docs.dock.* entries); restore proper Norwegian translations (or revert
these keys to the prior Norwegian strings) so the no.json values are fully
localized, ensure the long multi-line "agentPrompt" content is translated and
preserves the same instructions/formatting, validate the JSON remains
well-formed, and keep the original intent of keys like "exampleIntro",
"fieldsTitle", "sharingIntro", and "Deliverable" while updating only the string
values for the listed docs.dock.* keys.
In `@web/messages/pt-BR.json`:
- Around line 651-674: The pt-BR locale has several docs.dock strings left in
English (e.g., "exampleIntro", "agentPromptIntro", "agentPromptCodeTitle",
"agentPrompt", "agentPromptTitle", "agentPromptIntro", "agentPromptCodeTitle",
"agentPrompt" and any other newly added docs.dock.* keys) — replace these
English values with Portuguese translations or, if translations are not yet
available, revert them to the previous translated values or mark them as
TODO/UNTRANSLATED to avoid shipping English fallback; locate and update the JSON
entries for the keys named above in web/messages/pt-BR.json so the Dock docs and
agent prompt are fully localized for pt-BR.
In `@web/messages/ru.json`:
- Around line 651-674: The listed docs.dock.* strings in ru.json are still
English—update the values for the keys "projectConfig", "globalConfig",
"precedenceCallout", "exampleIntro", "sharingGlobal", "agentPromptIntro", and
"agentPrompt" with proper Russian translations while preserving JSON formatting
and existing punctuation/escaping (keep the surrounding quotes and newlines in
"agentPrompt" intact); locate these keys in the existing ru.json block (same
object that contains "exampleTitle", "fieldsTitle", etc.) and replace only the
English text for those keys so the rest of the file and other translations
remain unchanged.
In `@web/messages/uk.json`:
- Around line 736-759: Several Dock-related strings were left in English (e.g.,
"agentPromptIntro", "agentPrompt", "agentPromptCodeTitle", "agentPromptTitle",
"sharingGlobal", "exampleIntro", and "precedenceCallout") causing mixed-language
UX; restore full Ukrainian localization by replacing the English copy with
Ukrainian translations or revert these keys to the previous Ukrainian strings
until a vetted translation is available. Locate the keys agentPromptIntro,
agentPrompt, agentPromptCodeTitle, agentPromptTitle, sharingGlobal,
exampleIntro, and precedenceCallout in the messages bundle and update their
values to Ukrainian (or reapply the prior Ukrainian values from version control)
ensuring punctuation and escaped backticks remain consistent and the JSON stays
valid. Ensure the translated text preserves technical terms and instructions
(commands, paths, and JSON schema examples) and run a JSON parse check after
editing.
In `@web/messages/zh-TW.json`:
- Around line 651-674: The zh-TW locale contains several new Dock strings left
in English; translate them into Traditional Chinese (or revert the locale
change) so the zh-TW file stays fully localized. Update the keys shown in the
diff—agentPromptTitle, agentPromptIntro, agentPromptCodeTitle, agentPrompt,
sharingIntro, sharingGlobal (and any other new Dock strings around that block
such as exampleIntro, precedenceCallout, trustCallout, exampleTitle,
fieldsTitle, sharingTitle, sharingProject, sharingSecrets)—by providing
Traditional Chinese translations that match the existing tone and terminology,
or remove/keep the English strings out until a full zh-TW translation is ready.
Ensure translations preserve placeholders and code snippets exactly (e.g., `cmux
docs dock`, `.cmux/dock.json`, `~/.config/cmux/dock.json`, JSON schema) and
validate the JSON after editing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3e2f45e4-6f20-479e-8516-f350f28423c7
📒 Files selected for processing (27)
CLI/CMUXCLI+DocsSettings.swiftCLI/cmux.swiftResources/Localizable.xcstringsSources/DockEmptyView.swiftdocs/cli-contract.mddocs/dock.mdweb/app/[locale]/docs/dock/page.tsxweb/messages/ar.jsonweb/messages/bs.jsonweb/messages/da.jsonweb/messages/de.jsonweb/messages/en.jsonweb/messages/es.jsonweb/messages/fr.jsonweb/messages/it.jsonweb/messages/ja.jsonweb/messages/km.jsonweb/messages/ko.jsonweb/messages/no.jsonweb/messages/pl.jsonweb/messages/pt-BR.jsonweb/messages/ru.jsonweb/messages/th.jsonweb/messages/tr.jsonweb/messages/uk.jsonweb/messages/zh-CN.jsonweb/messages/zh-TW.json
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
web/messages/de.json (1)
651-674:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy liftGerman locale regression: Dock section now contains English content.
The updated Dock guidance/prompt strings in
de.jsonare in English. Please translate these updated values into German to maintain high-confidence locale quality.Based on learnings: Only high-confidence locales—en, de, fr, es, ja, ko, zh-Hans, zh-Hant, pt-BR, ru, it, pl, uk, tr, da, no—are expected to contain fully translated copy for strings changed in a given PR.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/de.json` around lines 651 - 674, The de.json update left several Dock-related strings in English (notably keys agentPromptTitle, agentPromptIntro, agentPromptCodeTitle, agentPrompt and exampleIntro plus any multi-line schema/rules/deliverable text), causing a German-locale regression; replace those English values with high-confidence German translations while preserving code blocks, inline backticks, JSON schema structure, example field names (controls, id, title, command, cwd, height, env), command examples (e.g., `cmux docs dock`), and any punctuation/formatting so only the human-visible text is translated and the technical tokens remain unchanged.web/messages/es.json (1)
651-674:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy liftSpanish locale regression: Dock guidance was replaced with English copy.
This block introduces English text into
es.jsonfor key Dock onboarding content. Please provide Spanish translations for these updated strings to keepesconsistent with high-confidence locale expectations.Based on learnings: Only high-confidence locales—en, de, fr, es, ja, ko, zh-Hans, zh-Hant, pt-BR, ru, it, pl, uk, tr, da, no—are expected to contain fully translated copy for strings changed in a given PR.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/es.json` around lines 651 - 674, The Spanish locale file (es.json) contains untranslated English text for several Dock onboarding keys (notably "agentPromptIntro", "agentPrompt", "agentPromptCodeTitle" and any other newly-changed strings like "exampleIntro", "precedenceCallout", "trustCallout", "sharingGlobal", "sharingSecrets"); replace the English copy with high-quality Spanish translations preserving meaning, JSON structure, punctuation, and any inline code/backticks and newline formatting, ensuring the resulting strings remain valid JSON and match the intent/format of the original English content.
🧹 Nitpick comments (4)
web/messages/no.json (1)
651-674: ⚡ Quick winHigh-confidence locale contains untranslated English strings.
Several newly added/modified keys in the
docs.docksection are in English while the surrounding keys remain translated to Norwegian. This creates an inconsistent user experience.Untranslated keys:
projectConfig,globalConfig,precedenceCallout,exampleIntro,sharingGlobal,agentPromptIntro.Note: Keeping
agentPromptin English may be intentional since it's technical instructions meant to be copied to AI coding agents, which typically work better with English prompts.Based on learnings: Norwegian (
no) is a high-confidence locale expected to contain fully translated copy for strings changed in a PR.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/no.json` around lines 651 - 674, The docs.dock Norwegian locale has several keys left in English; update the missing translations for the keys projectConfig, globalConfig, precedenceCallout, exampleIntro, sharingGlobal, and optionally agentPromptIntro in the web/messages/no.json locale to Norwegian to match surrounding strings. Locate the docs.dock block (search for "docs.dock" or the nearby translated keys like "trustCallout" / "exampleTitle") and replace the English values for those keys with their Norwegian equivalents, ensuring punctuation and placeholders remain intact and preserving agentPrompt in English only if intentional.web/messages/zh-CN.json (1)
651-674: ⚡ Quick winHigh-confidence locale contains untranslated English strings.
Several newly added/modified keys in the
docs.docksection are in English while the surrounding keys remain translated to Chinese. This creates an inconsistent user experience.Untranslated keys:
projectConfig,globalConfig,precedenceCallout,exampleIntro,sharingGlobal,agentPromptIntro.Note: Keeping
agentPromptin English may be intentional since it's technical instructions meant to be copied to AI coding agents, which typically work better with English prompts.Based on learnings: zh-Hans is a high-confidence locale expected to contain fully translated copy for strings changed in a PR.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/zh-CN.json` around lines 651 - 674, The PR added several keys in the docs.dock locale that remain in English, causing inconsistent zh-CN UI; translate the listed keys to Chinese (projectConfig, globalConfig, precedenceCallout, exampleIntro, sharingGlobal, agentPromptIntro) to match surrounding translations, keeping agentPrompt unchanged if intentional, and ensure the translations follow existing tone/terminology (e.g., "Dock 配置", "全局配置", "项目配置优先") and formatting/placeholder behavior matches the originals.web/messages/it.json (1)
651-674: ⚡ Quick winHigh-confidence locale contains untranslated English strings.
Several newly added/modified keys in the
docs.docksection are in English while the surrounding keys remain translated to Italian. This creates an inconsistent user experience.Untranslated keys:
projectConfig,globalConfig,precedenceCallout,exampleIntro,sharingGlobal,agentPromptIntro.Note: Keeping
agentPromptin English may be intentional since it's technical instructions meant to be copied to AI coding agents, which typically work better with English prompts.Based on learnings: Italian (
it) is a high-confidence locale expected to contain fully translated copy for strings changed in a PR.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/it.json` around lines 651 - 674, Several keys in the docs.dock section remain in English, causing inconsistent Italian localization; translate the missing keys by replacing the English text for "projectConfig", "globalConfig", "precedenceCallout", "exampleIntro", "sharingGlobal", and "agentPromptIntro" with proper Italian strings consistent with surrounding copy (leave "agentPrompt" in English if intentional), ensuring grammar and tone match existing entries like "sharingIntro" and "trustCallout" and that punctuation and placeholders remain unchanged.web/messages/ko.json (1)
651-674: ⚡ Quick winHigh-confidence locale contains untranslated English strings.
Several newly added/modified keys in the
docs.docksection are in English while the surrounding keys remain translated to Korean. This creates an inconsistent user experience.Untranslated keys:
projectConfig,globalConfig,precedenceCallout,exampleIntro,sharingGlobal,agentPromptIntro.Note: Keeping
agentPromptin English may be intentional since it's technical instructions meant to be copied to AI coding agents, which typically work better with English prompts.Based on learnings: Korean (
ko) is a high-confidence locale expected to contain fully translated copy for strings changed in a PR.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/ko.json` around lines 651 - 674, The KO locale has several untranslated English strings; update the values for the JSON keys "projectConfig", "globalConfig", "precedenceCallout", "exampleIntro", "sharingGlobal", and "agentPromptIntro" in the docs.dock section to fluent Korean matching the surrounding style (keep "agentPrompt" as-is if intentional), preserve existing punctuation/formatting, and validate the JSON parses after your edits.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/messages/pt-BR.json`:
- Around line 651-656: The pt-BR locale contains untranslated English
strings—update the values for the keys "projectConfig", "globalConfig",
"precedenceCallout", "exampleIntro", "sharingGlobal", and "agentPromptIntro" to
idiomatic Brazilian Portuguese (keeping "agentPrompt" in English only if
intentionally required); locate these keys in the pt-BR JSON (symbols:
projectConfig, globalConfig, precedenceCallout, exampleIntro, sharingGlobal,
agentPromptIntro) and replace the English sentences with concise Portuguese
translations preserving punctuation and any inline code/filenames (e.g.,
".cmux/dock.json"); run a quick spell/locale check to ensure natural phrasing
and consistent terminology across the file.
In `@web/messages/zh-TW.json`:
- Around line 651-656: The zh-TW locale contains English text for several keys
that need Traditional Chinese translations; update the values for
"projectConfig", "globalConfig", "precedenceCallout", "exampleIntro",
"sharingGlobal", and "agentPromptIntro" in web/messages/zh-TW.json with proper
zh-Hant strings (preserve punctuation/formatting and context such as "Dock",
".cmux/dock.json", and "controls array"), leave "agentPrompt" as-is if
intentionally English, and ensure translations match the original meaning and
tone for a high-confidence Traditional Chinese locale.
---
Outside diff comments:
In `@web/messages/de.json`:
- Around line 651-674: The de.json update left several Dock-related strings in
English (notably keys agentPromptTitle, agentPromptIntro, agentPromptCodeTitle,
agentPrompt and exampleIntro plus any multi-line schema/rules/deliverable text),
causing a German-locale regression; replace those English values with
high-confidence German translations while preserving code blocks, inline
backticks, JSON schema structure, example field names (controls, id, title,
command, cwd, height, env), command examples (e.g., `cmux docs dock`), and any
punctuation/formatting so only the human-visible text is translated and the
technical tokens remain unchanged.
In `@web/messages/es.json`:
- Around line 651-674: The Spanish locale file (es.json) contains untranslated
English text for several Dock onboarding keys (notably "agentPromptIntro",
"agentPrompt", "agentPromptCodeTitle" and any other newly-changed strings like
"exampleIntro", "precedenceCallout", "trustCallout", "sharingGlobal",
"sharingSecrets"); replace the English copy with high-quality Spanish
translations preserving meaning, JSON structure, punctuation, and any inline
code/backticks and newline formatting, ensuring the resulting strings remain
valid JSON and match the intent/format of the original English content.
---
Nitpick comments:
In `@web/messages/it.json`:
- Around line 651-674: Several keys in the docs.dock section remain in English,
causing inconsistent Italian localization; translate the missing keys by
replacing the English text for "projectConfig", "globalConfig",
"precedenceCallout", "exampleIntro", "sharingGlobal", and "agentPromptIntro"
with proper Italian strings consistent with surrounding copy (leave
"agentPrompt" in English if intentional), ensuring grammar and tone match
existing entries like "sharingIntro" and "trustCallout" and that punctuation and
placeholders remain unchanged.
In `@web/messages/ko.json`:
- Around line 651-674: The KO locale has several untranslated English strings;
update the values for the JSON keys "projectConfig", "globalConfig",
"precedenceCallout", "exampleIntro", "sharingGlobal", and "agentPromptIntro" in
the docs.dock section to fluent Korean matching the surrounding style (keep
"agentPrompt" as-is if intentional), preserve existing punctuation/formatting,
and validate the JSON parses after your edits.
In `@web/messages/no.json`:
- Around line 651-674: The docs.dock Norwegian locale has several keys left in
English; update the missing translations for the keys projectConfig,
globalConfig, precedenceCallout, exampleIntro, sharingGlobal, and optionally
agentPromptIntro in the web/messages/no.json locale to Norwegian to match
surrounding strings. Locate the docs.dock block (search for "docs.dock" or the
nearby translated keys like "trustCallout" / "exampleTitle") and replace the
English values for those keys with their Norwegian equivalents, ensuring
punctuation and placeholders remain intact and preserving agentPrompt in English
only if intentional.
In `@web/messages/zh-CN.json`:
- Around line 651-674: The PR added several keys in the docs.dock locale that
remain in English, causing inconsistent zh-CN UI; translate the listed keys to
Chinese (projectConfig, globalConfig, precedenceCallout, exampleIntro,
sharingGlobal, agentPromptIntro) to match surrounding translations, keeping
agentPrompt unchanged if intentional, and ensure the translations follow
existing tone/terminology (e.g., "Dock 配置", "全局配置", "项目配置优先") and
formatting/placeholder behavior matches the originals.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 19e551a3-5ce4-41fa-9413-e5c58a3d0317
📒 Files selected for processing (27)
CLI/CMUXCLI+DocsSettings.swiftCLI/cmux.swiftResources/Localizable.xcstringsSources/DockEmptyView.swiftdocs/cli-contract.mddocs/dock.mdweb/app/[locale]/docs/dock/page.tsxweb/messages/ar.jsonweb/messages/bs.jsonweb/messages/da.jsonweb/messages/de.jsonweb/messages/en.jsonweb/messages/es.jsonweb/messages/fr.jsonweb/messages/it.jsonweb/messages/ja.jsonweb/messages/km.jsonweb/messages/ko.jsonweb/messages/no.jsonweb/messages/pl.jsonweb/messages/pt-BR.jsonweb/messages/ru.jsonweb/messages/th.jsonweb/messages/tr.jsonweb/messages/uk.jsonweb/messages/zh-CN.jsonweb/messages/zh-TW.json
✅ Files skipped from review due to trivial changes (4)
- web/app/[locale]/docs/dock/page.tsx
- docs/cli-contract.md
- CLI/cmux.swift
- Sources/DockEmptyView.swift
🚧 Files skipped from review as they are similar to previous changes (11)
- web/messages/ru.json
- web/messages/uk.json
- docs/dock.md
- web/messages/tr.json
- web/messages/bs.json
- web/messages/fr.json
- web/messages/pl.json
- web/messages/km.json
- web/messages/ar.json
- web/messages/th.json
- web/messages/ja.json
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/messages/ja.json`:
- Line 828: The localized value for docs.dock.agentPrompt was translated to
Japanese but must remain the original English prompt; restore the exact English
text used in the canonical source for the key docs.dock.agentPrompt (replace the
current Japanese string with the verbatim English prompt), ensure the JSON
remains valid, and verify the string matches the source locale exactly so agent
copy/paste behavior is preserved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 106479e9-df58-4744-9d5e-fa6c593e6724
📒 Files selected for processing (15)
web/messages/da.jsonweb/messages/de.jsonweb/messages/es.jsonweb/messages/fr.jsonweb/messages/it.jsonweb/messages/ja.jsonweb/messages/ko.jsonweb/messages/no.jsonweb/messages/pl.jsonweb/messages/pt-BR.jsonweb/messages/ru.jsonweb/messages/tr.jsonweb/messages/uk.jsonweb/messages/zh-CN.jsonweb/messages/zh-TW.json
🚧 Files skipped from review as they are similar to previous changes (6)
- web/messages/fr.json
- web/messages/uk.json
- web/messages/pt-BR.json
- web/messages/es.json
- web/messages/ru.json
- web/messages/pl.json
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 27 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/cli-contract.md">
<violation number="1" location="docs/cli-contract.md:308">
P2: `dock` was added to `cmux docs --help` but the contract is missing a corresponding `docs dock` topic/probe entry, creating a spec gap for this new topic.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This branch was successfully deployed
1 participant
Summary
cmux docs docktopic for agents before editing Dock config.Verification
for f in web/messages/*.json; do python3 -m json.tool "$f" >/dev/null || exit 1; donepython3 -m json.tool Resources/Localizable.xcstrings >/dev/nullVERCEL_ENV=preview RESEND_API_KEY=dummy CMUX_FEEDBACK_FROM_EMAIL=dev@example.com CMUX_FEEDBACK_RATE_LIMIT_ID=dev bun run buildfromweb/./scripts/reload.sh --tag dock-promptcmux docs dock,cmux docs --help,cmux docs dock --json | python3 -m json.toolSummary by CodeRabbit
New Features
Documentation
Localization