Repository navigation
fix(webviews): web-lint red: Reply chip shadow token; settings gallery format - #33920
Conversation
…ttings gallery formatted check:design-tokens failed on feat since #33343 (0bb39cb): .cv-selection-reply had a raw box-shadow color (0 2px 8px rgb(0 0 0 / 0.14)). It now uses the popover elevation token, which also darkens correctly in dark mode. vp fmt --check failed on settings.gallery.ts since #33681 (db2bc10); this is the formatter's output. (cherry picked from commit bde198b)
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on ed88469 to compare; do not merge until green; see lane-rules Shipped in:
|
|
Found 10 test failures on Blacksmith runners: Failures
|
|
Review (independent-subagent): SHIP at f176fbf
Not run: no app or pane build, and no visual capture of the chip. The change is a single CSS value that uses a token defined on this page. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base red, priority zero. The feat tip
web-linthas been red since about 12:00Z (STATUS 8911):check:design-tokens:new design token violation (1 > 0): agent-session/acpmux/conversation/conversation.css color box-shadow 0 2px 8px rgb(0 0 0 / 0.14), from Agent pane: a Reply chip over selected text quotes it into the composer #33343 (0bb39cb, the Reply chip over selected text). The chip now usesvar(--elevation-2), the popover token that other popovers use. The shadow is close in light mode, and the token gives the dark-mode value.vp fmt --check:src/pages/settings/settings.gallery.tsfrom cmux NEXT: see and accept team invitations in Settings > Accounts #33681 (db2bc10) was not formatted. This is the formatter's output; no hand edit.Changelog
none
Observed / Not run
webviews/,bun run check:design-tokensfails on the base and passes on the head.bun run checkpasses on the head.scripts/web-lint.shand the pre-push gate pass.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes two web-lint failures: the Reply chip shadow now uses the
--elevation-2design token instead of a hardcoded color, andsettings.gallery.tsis reformatted with no hand edits. The shadow is nearly identical in light mode and now renders correctly in dark mode.Written for commit f176fbf. Summary will update on new commits.