Skip to content

fix(webviews): web-lint red: Reply chip shadow token; settings gallery format - #33920

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
base-red/design-tokens
Nov 3, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
base-red/design-tokens

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Base red, priority zero. The feat tip web-lint has been red since about 12:00Z (STATUS 8911):

Changelog

none

Observed / Not run

  • Observed: in webviews/, bun run check:design-tokens fails on the base and passes on the head. bun run check passes on the head. scripts/web-lint.sh and the pre-push gate pass.
  • Not run: a gallery capture of the chip; the shadow change is about 1 px of blur and 3% of opacity in light mode.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes two web-lint failures: the Reply chip shadow now uses the --elevation-2 design token instead of a hardcoded color, and settings.gallery.ts is reformatted with no hand edits. The shadow is nearly identical in light mode and now renders correctly in dark mode.

Written for commit f176fbf. Summary will update on new commits.

View guided diff Turn on auto-fix

…ttings gallery formatted

check:design-tokens failed on feat since #33343 (0bb39cb): .cv-selection-reply had a raw
box-shadow color (0 2px 8px rgb(0 0 0 / 0.14)). It now uses the popover elevation token, which
also darkens correctly in dark mode. vp fmt --check failed on settings.gallery.ts since #33681
(db2bc10); this is the formatter's output.

(cherry picked from commit bde198b)
@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review f176fbf: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33920 -f ref=base-red/design-tokens -f platform=macos -f backend_mode=local

Gallery before/after for f176fbf: 16 states rendered, 4 images differ, 1957 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41650109038 -R manaflow-ai/cmux -n gallery-advisory-33920-f176fbf133083acde4b43e314b1bd4770de66010 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.access-offer/turn-no-credits Apple System Colors Light unchanged 0% own conversation.css
agent-pane.access-offer/turn-no-credits Apple System Colors unchanged 0% own conversation.css
agent-pane.access-offer/turn-low-credits Apple System Colors Light unchanged 0% own conversation.css
agent-pane.access-offer/turn-low-credits Apple System Colors unchanged 0% own conversation.css
agent-pane.access-offer/turn-no-offer Apple System Colors Light unchanged 0% own conversation.css
agent-pane.access-offer/turn-no-offer Apple System Colors unchanged 0% own conversation.css
agent-pane.activity-line-looks/none Apple System Colors Light unchanged 0% own conversation.css
agent-pane.activity-line-looks/none Apple System Colors unchanged 0% own conversation.css
agent-pane.activity-line-looks/spinner Apple System Colors Light changed 0.0536% own conversation.css
agent-pane.activity-line-looks/spinner Apple System Colors changed 0.0496% own conversation.css
agent-pane.activity-line-looks/kind Apple System Colors Light changed 0.0274% own conversation.css
agent-pane.activity-line-looks/kind Apple System Colors changed 0.0245% own conversation.css
agent-pane.activity-line-looks/aligned Apple System Colors Light unchanged 0% own conversation.css
agent-pane.activity-line-looks/aligned Apple System Colors unchanged 0% own conversation.css
agent-pane.approval-edits/single Apple System Colors Light unchanged 0% own conversation.css
agent-pane.approval-edits/single Apple System Colors unchanged 0% own conversation.css
agent-pane.approval-edits/grouped Apple System Colors Light unchanged 0% own conversation.css
agent-pane.approval-edits/grouped Apple System Colors unchanged 0% own conversation.css
agent-pane.approval-edits/single-multiedit Apple System Colors Light unchanged 0% own conversation.css
agent-pane.approval-edits/single-multiedit Apple System Colors unchanged 0% own conversation.css
agent-pane.approval-edits/grouped-multiedit Apple System Colors Light unchanged 0% own conversation.css
agent-pane.approval-edits/grouped-multiedit Apple System Colors unchanged 0% own conversation.css
agent-pane.approval-edits/single-long Apple System Colors Light unchanged 0% own conversation.css
agent-pane.approval-edits/single-long Apple System Colors unchanged 0% own conversation.css
agent-pane.approval-edits/grouped-long Apple System Colors Light unchanged 0% own conversation.css
agent-pane.approval-edits/grouped-long Apple System Colors unchanged 0% own conversation.css
agent-pane.attachment-source/before Apple System Colors Light unchanged 0% own conversation.css
agent-pane.attachment-source/before Apple System Colors unchanged 0% own conversation.css
agent-pane.attachment-source/corner Apple System Colors Light unchanged 0% own conversation.css
agent-pane.attachment-source/corner Apple System Colors unchanged 0% own conversation.css
agent-pane.attachment-source/small Apple System Colors Light unchanged 0% own conversation.css
agent-pane.attachment-source/small Apple System Colors unchanged 0% own conversation.css

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on ed88469 to compare; do not merge until green; see lane-rules

Shipped in:

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 3, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026

Copy link
Copy Markdown

Found 10 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp5yzdiapp/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpf1bkhper/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='skills/cmux-customization/SKILL.md')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='skills/cmux-customization/references/
examples.md')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='skills/cmux-customization/references/
local-app-views.md')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='skills/cmux-customization/references/
viewer-types.md')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (independent-subagent): SHIP at f176fbf

  • Token is defined where the chip renders. --elevation-2 is on :root in webviews/src/pages/shared/desktop.css. agent-session/acpmux/dev.tsx imports desktop.css first. build-agent-pane-web.sh gets the shipped pane's sheets from dev.tsx's import order, and the gallery and guest page agent-pane.css do the same. So the shadow does not disappear.
  • It is the right step. desktop.css says --elevation-2 is for "popovers, menus, the palette, hover cards". The Reply chip floats over text at --layer-dropdown, so it is that kind of surface. The pane's other floating surfaces use the same token: the link card, the hover card, the composer attachment popovers, the location popover and the file-search palette. The visible change is small: 0 2px 8px at 14% becomes 0 2px 6px at 11% (16% in dark), which brings it into the shared scale.
  • Dark mode is correct. desktop.css overrides it to 0 2px 6px … black 16% under :root[data-theme="dark"], and agent-session/shared/theme.ts sets that attribute. It also applies under prefers-color-scheme: dark when there is no light override.
  • settings.gallery.ts only changes formatting. The same inv-1 object is split across lines. Its keys, values and order do not change, and nothing else in the file changes.
  • Checks, run locally in a clean worktree:
    • On the head, bun run check:design-tokens passes (3525 recorded) and the full bun run check passes, including vp fmt --check, vp lint and the type check.
    • On the base, both the PR parent 84eac874f26 and the feat tip 95214b4c615 fail check:design-tokens with new design token violation (1 > 0): … conversation.css box-shadow 0 2px 8px rgb(0 0 0 / 0.14). On the parent, vp fmt --check src/pages/settings/settings.gallery.ts fails; on the head it passes.

Not run: no app or pane build, and no visual capture of the chip. The change is a single CSS value that uses a token defined on this page.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 3, 2026
@lawrencecchen
lawrencecchen merged commit b08cc6f into feat-cmux-next Nov 3, 2026
236 of 253 checks passed
@lawrencecchen
lawrencecchen deleted the base-red/design-tokens branch November 3, 2026 14:33

This branch was previously deployed

1 inactive deployment
ci-routing-agent — f176fbf1 Deployed Nov 3, 2026 by lawrencecchen via wait for same-key tree publisher #106376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant