Repository navigation
gallery: Chief inspector stage mounts with its first screen's answers in (flaky load shift) - #33915
Conversation
…wers in pages.chief-inspector#prompt scored a 0.0159 load shift in one of the two jobs that render it: the fixture fetcher's replies settled after the first paint in some renders, so the summary line and the prompt drew under a frame of "Loading…". The entry's load now warms one store per fixture (reachable, unreachable) with the URLs the Prompt and Timeline tabs read, so the first frame is the final one. Gallery fixture only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 84eac87 to compare; do not merge until green; see lane-rules Shipped in:
|
GitHub Actions
Inactive
|
Owned by an agent session · session |
teamleaderleo
left a comment
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (codex gpt-6-astra high, next-review, since=20261103T140619Z): SHIP at 3d0f85a
SHIP at 3d0f85a
Visual verdict: unchanged by this diff
Reviewed store initialization, error handling, mount ordering, and all six screenshot pairs; no actionable findings. Build/tests were unavailable because dependencies are absent.
Follow-ups: none
|
Found 10 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
|
Awareness for @lawrencecchen (most recent author on |
|
Fresh-home launch of
|
What was red.
gallery healthon pushes to feat-cmux-next:pages.chief-inspector#promptscored a load shift of 0.0159 against its 0 baseline in one of the two jobs that render it (run 41643573386 at 5505bbd). The other job scored 0, so the state was flaky. On a push, a flaky red still fails the run.Cause. The gallery entry's
ApiStoreanswers from anasyncfixture fetcher.useSyncExternalStoresubscribes in a passive effect, and that effect can run after the first paint. So in some renders the first frame showed "Loading…" and no summary line, and the prompt then drew over it. The gate that catches this is the load-shift gate from #30250. The fixture dates from Lawrence's "chief-inspector page ... has a gallery entry (fixture-backed App, page:cmux.chief-inspector)" (53e28d0). It never warmed its store, and that only began to count when the shift gate landed.Fix (gallery fixture only). The entry's
loadnow builds one store per fixture (reachable and unreachable) and awaits the URLs the Prompt and Timeline tabs read before the component mounts (/api/status,/api/turns,/api/turn?key=now). The first frame is then the final one. No shipped code changes. The baseline stays at 0.Risk. Gallery only, in
webviews/src/pages/chief-inspector/chief-inspector.gallery.tsx. That path is Chief code, so it gets its own PR. Area owner by git log: @lawrencecchen, who is requested for awareness. This is not a wait gate.Split from the rest of the gallery flake fixes, which are in a sibling PR.
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes a flaky load shift in the Chief Inspector gallery entry so the first frame is now the final one.
Some renders showed "Loading…" on first paint because the fixture fetcher's answers settled a tick later, causing a 0.0159 load shift. The entry's
loadnow warms one store per fixture (reachable and unreachable) with the URLs the Prompt and Timeline tabs read (/api/status,/api/turns,/api/turn?key=now). Gallery fixture only; no shipped code changes.Written for commit 3d0f85a. Summary will update on new commits.