Repository navigation
Chief: a sign-in waiting on you is an open Needs you request in the Feed - #33850
Conversation
… Feed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-528c54a2913c7edf480a
escalate_auth posts an open sign-in (or passkey) request through the app's feed.request control method, keyed per Chief, subagent and site; it is withdrawn when the Chief tells the subagent it is signed in, or when the subagent is cancelled, and lapses after an hour otherwise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-528c54a2913c7edf480a
…ps the request Review follow-ups at 1818b01: a re-escalation after its request closed replayed the closed item, and "not signed in yet" closed it early. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-528c54a2913c7edf480a
|
Review (subagent claude-opus-5-5 medium): SHIP at b070fab Visual verdict: no UI code changed. Follow-ups:
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
|
@lawrencecchen for awareness, since this is Chief code you own most of: |
|
Owned by an agent session · session |
|
Found 2 test failures on Blacksmith runners: Failures
|
|
Review (codex, router-review): SHIP at b070fab Reviewer: codex gpt-6.1-sol xhigh, fast tier. Follow-ups: 5. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at b070fab
Rust tests could not run because Cargo is absent. Follow-ups:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo asked his Chief for "a pinned Needs you view in Chief Home, Feed and iPhone listing items waiting on Leo (PRs held for his trial like #30817, sign-ins, approvals, consent cards), plus an iPhone push when one appears."
This PR covers the sign-ins. When a subagent calls
escalate_auth, the Chief drives the sign-in in Home's right pane and posts one line in its own chat ("Needs you: touch the sensor (SITE)"). Nothing reached the Feed, so the sign-in was missing from the Feed's pinned Needs you section and from anything that reads the Feed (Home, iPhone, push).What changes
New
optchat-chief/src/needs_you_feed.rs. Onescalate_auth, the brain posts one open Feed request through the app's existingfeed.requestcontrol method onCMUX_SOCKET_PATH. It reaches the socket the same way subagent workspaces andcloud_workspacealready do.passkeyescalation becomes apasskeyrequest.password,2faandoauthbecome asign-inrequest: origin, page URL, reason, and the subagent's session as context.chief-auth:<chief id>:<subagent>:<site>, so a repeat escalation joins the open item.high), so it gets the Feed's push.The request closes (
feed.cancel) when either of these happens:tell(aN, "Signed in to SITE ...; go on."), and the message must name the site unless it is the subagent's only open sign-in. Reason:answered_elsewhere.control cancel, or any stop that settles it as cancelled). Reason:poster_gone.Otherwise it lapses after an hour (
expires_in_ms), which is longer than any sign-in page waits.Posts and cancels run in order on one worker thread, off the brain's loop. Stop condition: the thread ends when the brain drops its sender (the host stops). No timer or poll is added.
No app, so no
CMUX_SOCKET_PATH(a CLI or Cloud Chief): nothing is posted.The Swift side doesn't change:
FeedControl'sfeed.request/feed.cancelalready exist. No UI and no default change. #22646 and #24071 are untouched.Not localized: the title and body ("Sign in to npmjs.com", "a1 needs it: ...") are the Chief's own English text, like its chat lines. The Feed row's kind label and buttons come from the app's localized strings.
Testing
tests/needs_you_feed.rs(5 tests) uses a recordingFeedPortand the brain harness:sign-inrequest with its key, origin, URL, reason and expiry.passkeyrequest.tellleaves the request open, and "Signed in to npmjs.com ..." withdraws it.control cancelwithdraws it withposter_gone.Results:
cargo test --locked --test needs_you_feed) fails to compile the test:error[E0432]: unresolved imports optchat_chief::needs_you_feed.cargo test --locked --no-fail-fastin optchat-chief) passes (CARGO_EXIT=0, no failed test anywhere),needs_you_feedincluded.CARGO_EXIT=0).cmux-ci fresh-homepasses at both 1818b01 and b070fab: Home appeared at 6.6 s and the app stayed up 30 s with no crash.Not run
Chief area (
Native/OptChat/optchat-chief/): independent review at the head, whole-crate tests with no failure (so there is nothing to compare against base), a fresh-home launch on a fleet Mac, and a review request to @lawrencecchen, who has the most commits on these paths in the last 30 days. The request is for awareness and doesn't hold the merge.Agent session: agent session
🤖 Generated with Claude Code