Repository navigation
fix(ci): use one browser for gallery head and base renders - #33836
Conversation
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1b496497f308a88c14c8
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1b496497f308a88c14c8
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: green on the base 044672e; do not merge until green; see lane-rules Shipped in:
|
|
Found 10 test failures on Blacksmith runners: Failures
|
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1b496497f308a88c14c8
|
Review (subagent claude-opus-5-5 medium): SHIP at 583b1f5 Visual verdict: unchanged by this diff (CI-only change, no UI). Checked: The only red, Follow-ups: none. Different-model review (router-review, gpt-6.1-sol xhigh): SHIP at 583b1f5. Its 17 targeted tests and the workflow wiring guard pass, and reverting the workflow fix brings the browser mismatch back. Not posted with --post; quoted here. Held: the body has a "HOLD: Awaiting coordinator review." line, so this review does not merge it. The owner decides when to lift the hold. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Gallery health resolved its browser inside the head render step. The helper writes
CMUX_CHROME_HEADLESS_SHELLtoGITHUB_ENV, which Actions imports only for later steps: the head ran full Chrome while the base replay ran headless-shell. This produced different text widths and layout-shift scores for unchanged source during the limits audit. Shell selection arrived in c2933eb.Resolve the browser in its own preceding step, under the same render condition, so both sides receive the same executable. The existing dependency installation moves with setup.
Leo's audit request: “why are there prompt limits anyways?” and “well we ought to audit the limits and make sure 1. don't have nonsense 2. do some super sweet ergo perf stuff”. This corrects the validation used by that audit.
Validation:
python3 -m unittest tests.test_playwright_system_chrome tests.test_ci_gallery_health_merge_ref— 17 passed. The regression executes the workflow commands with fake build/browser commands and importsGITHUB_ENVbetween steps: it fails on ca064c2 with head=chrome, base=resolved shell, and passes after the fix.python3 tests/test_ci_workflow_guards_are_wired.pypasses; the regression lives in the already-wired gallery guard suite. Static pre-push checks andpr-overlappass. No browser is launched by the portable regression.Paired gallery replays 41637515269 and 41647896883 rendered the original and current clipboard change against their respective bases under the same full Chrome engine. The current replay rendered merge
907a576a40b114bfbb6bf94629ae6ab84eac5b58and base8d08eaaf21413c0a39d72231bb54099fe75c31c3, including both themes: each reports identicalrepo-worktrees-searchlayout shift0.00699(baseline0.00447) and moves, with no fresh render or geometry failure. This confirms the previously different scores disappear when the executable matches.🤖 Generated with Codex
Agent session: agent session