Skip to content

fix(acpmux): opaque agent id prefix with get, not a string slice (panic-ratchet red since #33209) #33717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 1 commit into from
Nov 3, 2026
Merged

fix(acpmux): opaque agent id prefix with get, not a string slice (panic-ratchet red since #33209) #33717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmux-tui/crates/acpmux/src/opaque_agent_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ impl Key {
let msg = format!("{}\0{harness}\0{session}", host.to_ascii_lowercase());
let mac = cmux_local_auth::frontend_proof::hmac_sha256(&self.0, msg.as_bytes());
let hex = cmux_local_auth::frontend_proof::hex(&mac);
format!("{PREFIX}{}", &hex[..HEX_LEN])
// `hex` is 64 ASCII digits, so the prefix always exists; `get` keeps the panic ratchet at zero.
format!("{PREFIX}{}", hex.get(..HEX_LEN).unwrap_or(&hex))
}
}

Expand Down
Loading