Skip to content

cmux NEXT sidebar: GroupJoinHold publicly imports Observation (Release compile red since #33578) - #33680

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/release-compile-red
Nov 3, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/release-compile-red

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Fix-forward for the Release compile red on feat-cmux-next since f0db136 (#33578).

cmux-next Release compile (Xcode 26), the fleet Release compile and status / cmux-next/compile fail at f0db136 with:

Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Logic/GroupJoinHold.swift:85:2: error: cannot use protocol 'Observable' in a public or '@usableFromInline' conformance; 'Observation' was not imported publicly (in macro expansion @Observable:1:50)

GroupJoinRows is a public @Observable class, so the file has to import Observation publicly. SidebarDocStore.swift in the same module already does this. This PR changes one line, import Observation → public import Observation. #33578's fix stays in.

Risk: low. The change is one import's access level and changes no behavior.

Changelog: none.

Agent session: agent session

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 142a82d: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33680 -f ref=lane/release-compile-red -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 2181a86 to compare; do not merge until green; see lane-rules

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-sonnet-5-5): SHIP at 88a8301

Visual verdict: unchanged by this diff (a revert to the code before #33578).

Checked that the diff is the exact inverse of f0db136 and touches the same 6 files and no others. Nothing on base still references the removed symbols, and PendingWorkspaceRows.removing is restored where it is called.

Follow-ups: none.

@teamleaderleo
teamleaderleo force-pushed the lane/release-compile-red branch from 88a8301 to b63633b Compare November 3, 2026 11:15
@teamleaderleo teamleaderleo changed the title Revert "cmux NEXT sidebar: a workspace opened into a named group appears straight in its group" (#33578): Release compile red cmux NEXT sidebar: GroupJoinHold publicly imports Observation (Release compile red since #33578) Nov 3, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-sonnet-5-5): SHIP at b63633b

Visual verdict: unchanged by this diff (one import access level, no UI change).

CmuxNextSidebar builds with InternalImportsByDefault, so a public @observable class needs public import Observation, as SidebarDocStore.swift already has. The file's public API uses only stdlib and same-module types, so no second error is waiting behind this one.

Follow-ups: none.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
…e compile red since #33578)

GroupJoinRows is a public @observable class, so its Observable conformance needs a public import of Observation
(GroupJoinHold.swift:85: "cannot use protocol 'Observable' in a public or '@usableFromInline' conformance"), as
SidebarDocStore.swift already does.

Sidebar-Look: no visual change
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-6b98f3ccf38f5d4bc316
@teamleaderleo
teamleaderleo force-pushed the lane/release-compile-red branch from b63633b to 142a82d Compare November 3, 2026 11:22
@cursor

cursor Bot commented Nov 3, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-sonnet-5-5): SHIP at 142a82d

Visual verdict: unchanged by this diff.

Same tree as b63633b, which got a SHIP (git diff b63633bed042 142a82d08827 is empty). Only the commit message changed, to add the Sidebar-Look: no visual change trailer the prepush gate asks for.

Follow-ups: none.

@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)/
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 142a82d0 Deployed Nov 3, 2026 by teamleaderleo via wait for same-key tree publisher #105734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant