Repository navigation
cmux NEXT sidebar: GroupJoinHold publicly imports Observation (Release compile red since #33578) - #33680
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 2181a86 to compare; do not merge until green; see lane-rules Shipped in:
|
|
Review (subagent claude-sonnet-5-5): SHIP at 88a8301 Visual verdict: unchanged by this diff (a revert to the code before #33578). Checked that the diff is the exact inverse of f0db136 and touches the same 6 files and no others. Nothing on base still references the removed symbols, and Follow-ups: none. |
88a8301 to
b63633b
Compare
|
Review (subagent claude-sonnet-5-5): SHIP at b63633b Visual verdict: unchanged by this diff (one import access level, no UI change). CmuxNextSidebar builds with InternalImportsByDefault, so a public @observable class needs Follow-ups: none. |
…e compile red since #33578) GroupJoinRows is a public @observable class, so its Observable conformance needs a public import of Observation (GroupJoinHold.swift:85: "cannot use protocol 'Observable' in a public or '@usableFromInline' conformance"), as SidebarDocStore.swift already does. Sidebar-Look: no visual change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-6b98f3ccf38f5d4bc316
b63633b to
142a82d
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (subagent claude-sonnet-5-5): SHIP at 142a82d Visual verdict: unchanged by this diff. Same tree as b63633b, which got a SHIP ( Follow-ups: none. |
|
Found 1 test failure on Blacksmith runners: Failure
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fix-forward for the Release compile red on
feat-cmux-nextsince f0db136 (#33578).cmux-next Release compile (Xcode 26), the fleet Release compile andstatus / cmux-next/compilefail at f0db136 with:GroupJoinRowsis apublic@Observableclass, so the file has to import Observation publicly.SidebarDocStore.swiftin the same module already does this. This PR changes one line,import Observation→public import Observation. #33578's fix stays in.Risk: low. The change is one import's access level and changes no behavior.
Changelog: none.
Agent session: agent session
🤖 Generated with Claude Code