Skip to content

base red: the notify Watcher import is macOS-only (unused on Linux after #33406) - #33664

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/acpmux-watch-import-red
Nov 3, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/acpmux-watch-import-red

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

clippy (changed cmux-tui packages) fails on Linux for any PR that touches cmux-tui: error: unused import: notify::Watcher at crates/acpmux/src/login_env/watch.rs:15. #33406 moved Linux to inotify, so the trait import is used only by the non-Linux source (watcher.watch(...)). This puts the import under the same #[cfg(not(target_os = "linux"))].

One line, no behaviour change.

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the Linux clippy failure unused import: notify::Watcher by gating the import behind #[cfg(not(target_os = "linux"))].

#33406 moved Linux to inotify, so the trait is imported only on other platforms. One line, no behavior change.

Written for commit 775bdc7. Summary will update on new commits.

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 775bdc7: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33664 -f ref=lane/acpmux-watch-import-red -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added the risk:high Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-sonnet-5-5): SHIP at 775bdc7

The only trait-method call (watcher.watch(...), line 71) is inside the #[cfg(not(target_os = "linux"))] source fn, the Linux path uses its own inotify watch fn and no notify::Watcher method, and the cfg(test) module has no .watch( calls on the trait, so the gated import is correct on both platforms.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)/
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 775bdc7

Reviewer: codex gpt-6-astra high, fast tier.

SHIP at 775bdc7

Visual verdict: unchanged by this diff

The cfg matches the platform split of source; Linux no longer imports an unused trait, while non-Linux builds retain the trait needed by watcher.watch(...).

Follow-ups: none

This branch was previously deployed

3 inactive deployments
artifacts — 775bdc78 Deployed Nov 3, 2026 by teamleaderleo via publish tree-addressed cmux-tui #105644
sentry-dsyms — 775bdc78 Deployed Nov 3, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #105644
ci-routing-agent — 775bdc78 Deployed Nov 3, 2026 by teamleaderleo via cmux-tui tree preflight #105644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant