[teamleaderleo]

On a cmux Cloud machine, the gh shim now answers gh auth status and gh api user from the GitHub account the cmux team connected, so an agent asked "can u see me github" says yes, with the right login, even in a chat with no folder.

Leo's ask, from his ChatGPT reference: "can u see me github", and "being able to have chatgpt (and in this case, any harnesses) see whatever folders/files".

Why

We ran a DEV build of feat-cmux-next 77e9a45 against a real home. It includes #33154, the acpmux MCP tool github_status. The test was a new chat with no folder, asking "can u see me github". Both Claude Code and Codex gave the right login, but neither called github_status. Both ran gh auth status / gh api user in a shell. That works on a Mac where gh is logged in. On a Cloud machine with no repo picked it doesn't: the shim (cmux github gh --auto) can only mint an installation token for one repo, so with no repo gh has no login. An agent that shells out there wrongly says it can't see GitHub, even though the person's cmux team has GitHub connected. Steering text alone doesn't make models call the tool reliably.

What changed

• cmux-tui/crates/cmux-host/src/github_cli_identity.rs (new): when the person has no auth of their own (no GH_TOKEN or similar, no gh auth login), cmux github gh --auto checks for these two questions before routing:
  • gh auth status (with -a, -t/--show-token, -h github.com): prints status in gh's format, for example ✓ Connected through cmux as <login> (GitHub App installation), the account type, and Repositories: N selected when known. It exits 0 when connected. When not connected, it prints gh's "You are not logged into any GitHub hosts" message plus the cmux connect link, and exits 1. It never prints a token, a token prefix or scopes, even with --show-token.
  • gh api user / gh api /user (GET only, optional --jq/-q): prints a minimal user object (login, html_url, plus avatar_url, name and type "User"/"Organization" only when known). --jq takes . and .FIELD. When not connected, it gives gh's 401 shape and exits 1.
  • The answer comes from the same source as github_status: the machine agent's {"github_status": {}} line on /run/cmux-vm-agent/agent.sock, which calls cmux-platform GET /v1/me/github with the machine's install bearer. The reply is checked again with cloud::github_status::sanitize, so a token the source sends is dropped.
  • The shim answers only when the person has no gh auth for any host (an Enterprise login in hosts.yml keeps gh's own answer). acpmux's github_status gh source sets CMUX_GITHUB_GH_OWN_LOGIN_ONLY=1, so it still reports only the person's own gh login and doesn't count the team's account twice.
  • Every other gh command keeps its current behaviour. So do these two when the agent gives no answer (older image, unreachable): gh runs as before, after one line on stderr.
• github_cli.rs: the socket round trip moves into agent_reply, used by both the token ask and the status ask.
• acpmux/src/github_status.rs: STEER now says to call github_status first, instead of running gh auth status / gh api user, because it also covers Cloud machines and the team's cmux connection.

How it reaches Cloud machines

The shim script (web/scripts/cmux-vm-image/github-auth.ts) doesn't change. It already execs the image's cmux github gh --auto. The new behaviour ships in the image's cmux-tui binary. A machine gets it once a published cmux-tui that includes this commit is pinned in images/cmux-vm/inputs.lock.json and baked (Cloud VM image bake, then auto-promote), and the channel diff and env deploy land. The cloud-image-staleness job dispatches that bake by itself once the channel image is more than 7 days behind the tip. This change adds no daemon capability, so it doesn't trigger a bake any sooner.

Testing

Tests in github_cli_identity_tests.rs run against a fake agent socket. They cover: connected (user), not connected, an organization account, a source that sends a token (top-level and inside profile fields, and as the login), --jq, which argument shapes count as identity questions, and the fallback when there's no answer. Each test asserts that the agent was asked {"github_status": {}} and that no output contains a token or "scope".

The first commit stubs the new path so the tests run red; the second makes them green (results below).

Observed / Not run

Ran with cmux-ci test (fast-checks, Linux):

• Red at 277e98e (the tests with the stub): cargo test -p cmux-host --lib github_cli_identity had 7 of 8 failing (run 41617912882).
• Green at 158ec23: cargo test -p cmux-host --lib github_cli passed 31 of 31, cargo test -p acpmux --lib github_status passed 8 of 8, and cargo clippy -p cmux-host -p acpmux --all-targets -D warnings was clean (run 41781461087).
• After the review fixes (Windows cfg(unix) gate, Enterprise hosts.yml logins keep gh's answer, acpmux's own-login probe sets CMUX_GITHUB_GH_OWN_LOGIN_ONLY): the same commands at the new head, results in the review comment.

Not run: a live Cloud machine. Getting there needs a published cmux-tui and an image bake (see above).

risk:high: this touches the credential path of the Cloud gh shim. Nothing new holds or prints a token.

Changelog

• Fixed: On cmux Cloud machines, gh auth status and gh api user now show the GitHub account your cmux team connected, so agents can answer "can you see my GitHub" in a chat with no folder.

🤖 Generated with Claude Code

Agent session: agent session

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 4e471e5: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33581 -f ref=lane/cloud-gh-identity -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 0509360 to compare; do not merge until green; see lane-rules

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4182499138501 (e0aa712b3b)
• cmux NEXT nightly 1.0.0-nightly.4184087390301 (08052d331e)
• cmux NEXT nightly 1.0.0-nightly.4184224384601 (a3abfc4160)
• cmux NEXT nightly 1.0.0-nightly.4184409870901 (78ee0e108e)

[blacksmith-sh]

Found 6 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmpi92z1hdw/summary-missing.json (live):/summary-missing.json (live):	View Logs
/tmp/tmppi8jy7ca/summary-fail.json (live):/summary-fail.json (live):	View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/ [new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows	View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[teamleaderleo]

Review (codex gpt-6-astra high, sweep, via the review router; full diff from merge base 10687a1 to this head): BLOCK at 277e98e

[P1] [blocking] files/cmux-tui/crates/cmux-host/src/github_cli_identity.rs:65 - identity_ask unconditionally returns None, so the new identity implementation is unreachable and its added tests fail immediately - remove the stub branch and execute the parser.
[P1] [blocking] files/cmux-tui/crates/cmux-host/src/lib.rs:50 - github_cli_identity is compiled on non-Unix targets even though it imports the Unix-only github_cli module, breaking Windows compilation - guard the module with #[cfg(unix)].
[P1] [blocking] files/cmux-tui/crates/cmux-host/src/github_cli_identity.rs:133 - the Cloud reply’s uncontrolled error.code is copied into stderr without secret filtering, allowing a token embedded there to leak - validate against fixed error codes or redact it before constructing Refused.
[P2] [follow-up] files/cmux-tui/crates/cmux-host/src/github_cli.rs:835 - identity interception ignores GH_HOST, so GH_HOST=ghe.example.com gh auth status or gh api user can incorrectly report the cmux github.com account - only intercept when the effective host is unset or github.com.

[teamleaderleo]

Review (codex gpt-6.1-sol xhigh, next-review): BLOCK at 158ec23

BLOCK at 158ec23
Visual verdict: no images; Leo tries the build

1. [P1] [blocking] lib.rs:50: Gate github_cli_identity with #[cfg(unix)]. It unconditionally imports crate::github_cli, which is excluded on Windows. Because acpmux depends on cmux-host on Windows, this breaks the Windows build and compile-check job.

2. [P2] [follow-up] github_cli.rs:835: Preserve account attribution when github_status invokes gh. Its from_gh calls PATH’s gh api user, so the Cloud shim now returns the team’s account, which from_gh labels gh-cli. The tool consequently lists the organization twice and describes one entry as “the person’s own GitHub CLI login.” Make that probe bypass synthetic identity answers and add an integration test using the Cloud shim.

3. [P2] [follow-up] github_cli.rs:834: Respect enterprise-only gh logins and GH_HOST before intercepting. own_gh_login() recognizes only github.com, so a person authenticated to an enterprise host can now receive cmux’s github.com identity—or “not connected”—instead of their existing gh status. Preserve real-gh handling for those cases.

Rust tests were unavailable because this box has neither Rust nor Cargo.

[teamleaderleo]

Review (codex gpt-6.1-sol xhigh, router-review): BLOCK at 158ec23

BLOCK at 158ec23

Visual verdict: no images; Leo tries the build

1. [P1] [blocking] [category:correctness] [finding:F1] [outcome:pending] lib.rs:50: Gate the new module with #[cfg(unix)]. It unconditionally imports crate::github_cli, which is excluded on Windows. Since acpmux depends on cmux-host on Windows, this breaks the Windows compile check and builds.

2. [P1] [blocking] [category:correctness] [finding:F2] [outcome:pending] github_cli.rs:835: Preserve the existing MCP tool’s personal-login probe. acpmux::github_status::from_gh runs gh api user through this shim, then labels its response gh-cli. With this interception, an organization installation appears twice, including as “the person’s own GitHub CLI login.” Make that internal probe bypass synthesized identity and add coverage using the Cloud shim.

3. [P1] [blocking] [category:correctness] [finding:F3] [outcome:pending] github_cli.rs:834: Preserve existing Enterprise authentication reporting. own_gh_login() recognizes only a github.com: entry, so someone logged into an Enterprise host now has unqualified gh auth status replaced by the cmux team’s status. If cmux is disconnected, it incorrectly reports no logged-in hosts and exits 1; base delegates to gh and reports the existing Enterprise login.

Focused Rust tests could not run because cargo is absent.

[teamleaderleo]

Review (codex gpt-6-astra high): SHIP at 4e471e5

SHIP at 4e471e5
Visual verdict: no images supplied (range review); the visual verdict must come separately

1. [P2] [follow-up] [category:correctness] [finding:F1] [outcome:pending] cmux-tui/crates/cmux-host/src/github_cli_identity.rs:68: Valid YAML can indent its root mapping. A hosts.yml with github.com: and appropriately indented credentials makes this detector report no login, allowing gh auth status to substitute the cmux team account for the existing personal login. Parse YAML or conservatively treat indented content as possible authentication, and cover this form in a regression test.

Static review completed; Rust tests could not run because cargo is unavailable.

Follow-ups:

• F1: Preserve personal authentication when hosts.yml uses an indented root mapping.

Range review via router-review (gpt-6-astra high; gpt-6.1-sol gave no reply). Fast checks at this head: cmux-host github_cli 32/32, acpmux github_status 8/8, clippy -D warnings clean (run 41787024638).