Repository navigation
Demo configurable plus button actions on macOS 15 runner - #3352
lawrencecchen wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds a single documentation file recording the successful demo of configurable plus-button actions on a macOS 15 runner. Both left-click (browser surface) and right-click menu (configured order with separator) behaviors were verified and captured on video with no blockers. Confidence Score: 5/5Documentation-only change; safe to merge. Only a single markdown recording report is added. There are no code changes, no logic, and no security surface. The sole finding is a minor wording inconsistency (P2) between two sections of the same document. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Loader as cmux-loader (CI)
participant App as cmux DEV pbtn15.app
participant Config as cmux.json
Loader->>Config: Write plus-button config (newBrowser left-click, Demo Shell / Demo Workspace right-click)
Loader->>App: reload.sh --tag pbtn15 --launch
Loader->>App: approve-computer-use-app
Loader->>App: set-app-window-frame
Loader->>Loader: record-video start repro
Loader->>App: Right-click titlebar plus button
App-->>Loader: Menu: New Terminal | separator | Demo Shell | Demo Workspace
Loader->>App: Click Demo Shell
App-->>Loader: Shell command executes
Loader->>App: Left-click titlebar plus button
App-->>Loader: Browser surface opens (cmux.newBrowser)
Loader->>Loader: record-video stop repro
Reviews (1): Last reviewed commit: "Address https://github.com/manaflow-ai/c..." | Re-trigger Greptile |
| 5. Started recording: `./.cmux-loader/record-video start repro 180`. | ||
| 6. In UI: | ||
| - Right-clicked titlebar plus button (`titlebarControl.newTab`). | ||
| - Confirmed menu order was `New Terminal`, `Demo Shell`, `Demo Workspace`. |
There was a problem hiding this comment.
Separator missing in step-by-step description
The "Steps attempted" section (line 16) lists the confirmed right-click menu order as New Terminal, Demo Shell, Demo Workspace, omitting the separator. The "Result" section (line 23) correctly lists it as New Terminal, separator, Demo Shell, Demo Workspace, matching the PR description. The two sections of the same document are inconsistent.
| - Confirmed menu order was `New Terminal`, `Demo Shell`, `Demo Workspace`. | |
| - Confirmed menu order was `New Terminal`, separator, `Demo Shell`, `Demo Workspace`. |
Addresses #3348
Generated by cmux-loader.
Recorded videos:
Run artifacts: https://github.com/manaflow-ai/cmux-loader/actions/runs/25157034841
Codex final message:
Done.
loader/recording-plus-button-actions-demo-macos15pbtn15/Users/runner/Library/Developer/Xcode/DerivedData/cmux-pbtn15/Build/Products/Debug/cmux DEV pbtn15.app/Users/runner/.config/cmux/cmux.json(exact task payload).Recording result:
repro./.cmux-loader/record-video stop reprocompleted withstatus=ok.What I verified via GUI:
New Terminal, separator,Demo Shell,Demo Workspace.Demo Shellexecuted the configured command path (right-click action path demonstrated).cmux.newBrowser.No blockers encountered.
Report saved at: docs/recordings/plus-button-actions-demo-macos15.md.
Summary by cubic
Adds a recorded demo and short report verifying configurable titlebar plus-button actions on macOS 15. Confirms right‑click menu order (New Terminal, separator, Demo Shell, Demo Workspace) and that left‑click opens a browser tab via
cmux.newBrowser; details and video link are in docs/recordings/plus-button-actions-demo-macos15.md.Written for commit b632998. Summary will update on new commits. Review in cubic