Skip to content

Demo configurable plus button actions on macOS 15 runner - #3352

Closed
lawrencecchen wants to merge 1 commit into
task-plus-button-action-overridesfrom
loader/recording-plus-button-actions-demo-macos15
Closed

lawrencecchen wants to merge 1 commit into
task-plus-button-action-overridesfrom
loader/recording-plus-button-actions-demo-macos15

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Apr 30, 2026 •

Copy link
Copy Markdown
Contributor

Addresses #3348

Generated by cmux-loader.

Recorded videos:

  • repro: .runner/videos/repro.mov (ok)

Run artifacts: https://github.com/manaflow-ai/cmux-loader/actions/runs/25157034841

Codex final message:

Done.

  • Task source used: Make plus button actions configurable #3348
  • Checked-out ref: loader/recording-plus-button-actions-demo-macos15
  • Reload tag used: pbtn15
  • App path used: /Users/runner/Library/Developer/Xcode/DerivedData/cmux-pbtn15/Build/Products/Debug/cmux DEV pbtn15.app
  • Output config file written: /Users/runner/.config/cmux/cmux.json (exact task payload).

Recording result:

  • Video artifact: repro
  • ./.cmux-loader/record-video stop repro completed with status=ok.

What I verified via GUI:

  • Right-click menu on titlebar plus button appeared in configured order: New Terminal, separator, Demo Shell, Demo Workspace.
  • Clicking Demo Shell executed the configured command path (right-click action path demonstrated).
  • Left-click on titlebar plus opened a browser surface/tab as configured with cmux.newBrowser.

No blockers encountered.

Report saved at: docs/recordings/plus-button-actions-demo-macos15.md.


Summary by cubic

Adds a recorded demo and short report verifying configurable titlebar plus-button actions on macOS 15. Confirms right‑click menu order (New Terminal, separator, Demo Shell, Demo Workspace) and that left‑click opens a browser tab via cmux.newBrowser; details and video link are in docs/recordings/plus-button-actions-demo-macos15.md.

Written for commit b632998. Summary will update on new commits. Review in cubic

Generated by cmux-loader.
@vercel

vercel Bot commented Apr 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Apr 30, 2026 9:18am
cmux-staging Building Building Preview, Comment Apr 30, 2026 9:18am

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 24ff93d1-fb98-4bf3-814d-161fccad7a7b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch loader/recording-plus-button-actions-demo-macos15

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a single documentation file recording the successful demo of configurable plus-button actions on a macOS 15 runner. Both left-click (browser surface) and right-click menu (configured order with separator) behaviors were verified and captured on video with no blockers.

Confidence Score: 5/5

Documentation-only change; safe to merge.

Only a single markdown recording report is added. There are no code changes, no logic, and no security surface. The sole finding is a minor wording inconsistency (P2) between two sections of the same document.

No files require special attention.

Important Files Changed

Filename Overview
docs/recordings/plus-button-actions-demo-macos15.md New recording report documenting the plus-button-actions demo on macOS 15; minor inconsistency between step 6 (no separator) and the Result section (separator listed).

Sequence Diagram

sequenceDiagram
    participant Loader as cmux-loader (CI)
    participant App as cmux DEV pbtn15.app
    participant Config as cmux.json

    Loader->>Config: Write plus-button config (newBrowser left-click, Demo Shell / Demo Workspace right-click)
    Loader->>App: reload.sh --tag pbtn15 --launch
    Loader->>App: approve-computer-use-app
    Loader->>App: set-app-window-frame
    Loader->>Loader: record-video start repro
    Loader->>App: Right-click titlebar plus button
    App-->>Loader: Menu: New Terminal | separator | Demo Shell | Demo Workspace
    Loader->>App: Click Demo Shell
    App-->>Loader: Shell command executes
    Loader->>App: Left-click titlebar plus button
    App-->>Loader: Browser surface opens (cmux.newBrowser)
    Loader->>Loader: record-video stop repro
Loading

Reviews (1): Last reviewed commit: "Address https://github.com/manaflow-ai/c..." | Re-trigger Greptile

5. Started recording: `./.cmux-loader/record-video start repro 180`.
6. In UI:
- Right-clicked titlebar plus button (`titlebarControl.newTab`).
- Confirmed menu order was `New Terminal`, `Demo Shell`, `Demo Workspace`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Separator missing in step-by-step description

The "Steps attempted" section (line 16) lists the confirmed right-click menu order as New Terminal, Demo Shell, Demo Workspace, omitting the separator. The "Result" section (line 23) correctly lists it as New Terminal, separator, Demo Shell, Demo Workspace, matching the PR description. The two sections of the same document are inconsistent.

Suggested change
- Confirmed menu order was `New Terminal`, `Demo Shell`, `Demo Workspace`.
- Confirmed menu order was `New Terminal`, separator, `Demo Shell`, `Demo Workspace`.

@lawrencecchen
lawrencecchen deleted the branch task-plus-button-action-overrides May 1, 2026 11:52

This branch was successfully deployed

1 active deployment
Preview – cmux — b6329988 Deployed Apr 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant