Repository navigation
Agent pane: a forced Stop reads as a plain stop, and a message sent after Stop shows below it - #33334
Conversation
…d in after it draws below it A turn acpmux ended because the agent never answered Stop no longer adds the line "The agent didn't answer Stop, so cmux ended its turn." to the transcript: it reads as any stop, with a muted Stopped in the footer (stopped-turn-look experiment), and only the tooltips name cmux's end. A steer logged after the turn's stopping record never reached the agent: it draws below the stop line, and acpmux's run of it as the next prompt (same promptId) or its queued card takes its place. Continue says what it sends and goes when a queued prompt runs next anyway. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-fb75b7af9902231028aa
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-fb75b7af9902231028aa
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-fb75b7af9902231028aa
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-fb75b7af9902231028aa
|
Owned by an agent session · session |
|
Review (codex, router-review): SHIP at 91900c3 Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 3. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 91900c3
The Bun suites could not run because Bun and project dependencies are absent. Follow-ups:
|
…pane-stopped-turn-row # Conflicts: # webviews/src/agent-session/acpmux/Localizable.xcstrings # webviews/src/agent-session/acpmux/mockFixture.ts
…ds only without one Review follow-up at 91900c3 (P2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-fb75b7af9902231028aa
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
|
|
Review (codex, router-review): SHIP at 0499fd4 Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 2. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 0499fd4 Visual verdict: no regression in the 16 supplied pairs; differences are spinner rotation only. New stopped-turn states aren’t pictured.
The first finding was reproduced using the extracted reducer methods. Full tests could not start because Follow-ups:
|
|
Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over. Overlap awareness for this PR and #33248: #33543 changes only model.ts scrollLeadRanges plus focused scroll tests and an A/B runner. It leaves row-kind, status, Stop behavior, App.tsx, first paint, and initial rail entrance unchanged. The candidate is held for same-worker timing and strict slowdown/reversal coverage; no performance improvement is claimed. Its frozen head is fa55874. Please preserve the independent scroll-range function changes when integrating the overlapping model.ts work. |
A newer verdict blocks 110ec68 (no independent SHIP at the head).
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Found 1 test failure on Blacksmith runners: Failure
|
…pane-stopped-turn-row # Conflicts: # webviews/src/agent-session/acpmux/App.tsx # webviews/src/agent-session/acpmux/Localizable.xcstrings
|
Review (codex, router-review): SHIP at 81bd3ef Reviewer: codex gpt-6.1-sol xhigh, fast tier. Follow-ups: 3. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 81bd3ef Visual verdict: no images; Leo tries the build
Targeted Node probes reproduced findings 1–2. Bun and project dependencies were unavailable, so browser suites were not run. Follow-ups:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Relayed from Leo's look at a transcript capture: "Queued-message controls. 'Send now ×' and the copy icon float loosely under the bubble. Align them to the bubble's edge."
What I found
On the current base, a waiting steer's controls already sit exactly where a sent prompt's controls sit. #31683 made that change (merged 2026-11-02 02:51 UTC). Before it, the waiting steer's row stayed in flow (#27580), so it sat inset from the bubble and took its own height. A capture from a build before #31683 shows the loose row.
I measured base with the shared footer test and the gallery, in Chromium at 880px and 360px, with short and wrapping prompts:
The two steers in
agent-pane.composer/steer-waiting-stackmeasure the same.What this changes
Tests and gallery only. No CSS change.
webviews/test/queued-user-footer.test.ts: the test checked only the outer row's box. It now also checks the controls in each width, length and theme case: Copy's glyph ends on the bubble's right edge, both while waiting and once sent. The glyphs keep the sent row's gap under the bubble. Every queued icon button and the sent Copy are thetranscript-action-controlsquare. If a change moved the controls inside a correct-looking row box, the old test would still pass, and this one fails.QueuedUserFooter.gallery.ts: adds a newstackvariant with two waiting steers. Only the newest one offers Send now. Thebalancedandstackplays now check the same glyph alignment against the sent prompt in the same frame.Design spec: leo-workspace
design/chat-transcript.md, "A queued personal prompt stays right-aligned in the sent-prompt bubble position. Send now and the withdrawal × occupy the same footer slot directly under the bubble's right edge." Nothing in the spec changes.Observed / Not run
CMUX_BROWSER_TESTS=1 bun test test/queued-user-footer.test.ts, 12 pass and 0 fail. Gallery plays foragent-pane.queued-user-footercompact,balanced,roomy,stackandreadpass in dark and light.acceptedfails its click step at base too, and this PR leaves it unchanged.vp lintand the type check are clean. One formatting fix was applied after that run.Changelog
none
Agent session: agent session
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Makes a forced Stop (cmux ended the turn because the agent never answered) read as any other stop, and a message steered in right after it draw below the stop instead of above it.
stopped-turn-lookexperiment) replaces it, with the reason only in tooltips.Written for commit 81bd3ef. Summary will update on new commits.