Repository navigation
Transcript: background task ends weighed from the event; silent ones go onto their call - #33283
Conversation
…go onto their call acpmux weighs each background task end in one table keyed by kind and status (hub/background_cause.rs) and puts it on the background_turn started record as cause. The pane draws no row for a silent end, marks a result new on its call until the next prompt, and always shows a failure. Reverts the punctuation-only widening of isBareAgentText to a lone period. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
|
|
Owned by an agent session · session |
|
Found 1 test failure on Blacksmith runners: Failure
|
|
Review (codex, router-review): SHIP at 72c7087 Reviewer: codex gpt-6.1-sol xhigh, fast tier. Follow-ups: 4. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 72c7087
Follow-ups:
|
… cache key, keep earlier replies Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
|
Review (codex, router-review): SHIP at 08645a7 Reviewer: codex gpt-6.1-sol xhigh, fast tier. Follow-ups: 5. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 08645a7
Follow-ups:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review (codex, router-review): SHIP at b9cdc18 Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 4. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at b9cdc18
Focused source probes reproduced findings 1–3. TypeScript syntax checks passed; full tests were unavailable without Bun/Cargo. Follow-ups:
|
|
Review (codex, router-review): SHIP at 9aa7dbc Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 4. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 9aa7dbc
Five visibility tests passed. Integration tests could not start because dependencies are absent. Follow-ups:
|
A newer verdict blocks 425401a (no independent SHIP at the head).
|
Review (codex gpt-6.1-sol high, sweep, via the review router; full diff from merge base e8fc118 to this head): BLOCK at 425401a [P2] [blocking] webviews/src/agent-session/acpmux/conversation/ToolRow.tsx:226 - Attaching a reply to a Monitor call with no command, output, or diffs makes the reply inaccessible: the background line disappears, but the call’s disclosure and body-render conditions ignore |
…eir named line; done-line replies are findable (#33758) * Transcript: background reactions keep through call updates and newer prompts; failures beat interim; local_monitor is a monitor Fixes #33375 and #33376 (follow-ups from the review of #33283). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5 * Transcript: a failure with a long reply keeps its named line; a subagent done line's reply is text Find reads Fixes #33319 and #33538. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Background task ends are weighed from the task's own event, not from the reply's text. One worth no response no longer gets a transcript row.
Leo, on the "Background task finished" rows with lone "·" replies under them: "i mean can these possibly be more graceful? im not really sure", then "there's like... background tasks worth responding to and not worth responding to", and on the punctuation rule from #32884: "well there are cases (rare) that you would want to see it".
What changes
acpmux (
hub/background_cause.rs, new): one table,WEIGHTS, keyed by task kind and notification status. Kinds aresubagent,subagent_step(a call a subagent made),monitor,shellandunknown. The kind comes from Claude Code'stask_startedline; the status comes fromtask_notification, plusinterimwhen the notification says the agent "is waiting on its own background work" or that its result "may be interim". The background turn'sstartedrecord now carriescause: {kind, status, weight, origin?, summary?}. When several notifications arrive before one turn, the heaviest one names the cause. Each kind has its own test, and a further test checks that every kind × status pair resolves (onlyfailedis a failure).Pane:
Logs written before acpmux recorded
causedraw exactly as they did after #32884.This reverts #32884's punctuation widening of
isBareAgentText, back to #32726's lone ".". That covers the narrowing follow-up too: "·" now draws when it is a real reply, and is hidden only as part of a silent background turn.Variants
Gallery
agent-pane.background-reactions, compare view,background-reaction-lookexperiment:Picked On the call: it removes the row entirely for what isn't worth a response, and still says "something new finished here" where the work started. That matches how Codex marks a finished agent on its own row and how Claude's task list updates in place, with nothing appended to the chat.
Cost
No new O(rows) work per token. The reply text is gathered once per background turn, when it ends, from that turn's own reply ids. Seeing results on a prompt walks only the fresh reactions. No timers, observers or animation loops are added.
Spec: leo-workspace
design/chat-transcript.md(merged). Tests: acpmuxhub::background_causeandhub::background_turn; webviewstest/agent-pane-background-turns.test.ts(interim, result, failure, silent with no call, subagent report, record parsing),backgroundRuns.test.tsx,visibleMessage.test.ts.Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Background task ends are now weighed from the task's own event instead of the reply's text, so silent ones (a subagent's step, an interim stop, a monitor tick, a stop) draw no transcript row and go onto the call that started them.
causeon each background turn's started record, keyed by task kind and status, with the heaviest notification naming the turn.isBareAgentTextback to a lone..background-reaction-lookexperiment with the folded-run arm as the previous look; logs written before acpmux recordedcausedraw exactly as before.Written for commit 425401a. Summary will update on new commits.