[lawrencecchen]

Summary

Was stacked on #33112, which merged at 14:43Z; feat-cmux-next is now merged in (head 1845245).

REOPEN-F7. Profile 8 (cmux19, job 72f71795e8b896e2f54c5ad4) puts TooltipTracker.setWhole (a tracker in the tooltip table and a tracking area) at about 1 ms (profiled) of the window build. It ran at init for every row's hidden hover-only icon buttons, which cannot be hovered while hidden.

Fix: the tooltip's text and shortcut are recorded at once, as before; only the hover tracking area waits. NSView.defersThemedToolTipTracking (opt-in; only SidebarIconButton sets it, the other 127 themedToolTip users do not change) keeps the tracking area off while the view is hidden or has no window, and themedToolTipCanShow() adds it when the button shows (viewDidUnhide, viewDidMoveToWindow, viewDidMoveToSuperview). VoiceOver's help is set with the text.

Review at e2c9ba9 found a P1 in the first version (it deferred the whole registration): the Priority bell, whose shortcut showPriority sets while the sidebar may have no window, lost its "⌥⌘K" (SidebarIconMeaningTests.thePriorityBellNamesItsDotAndKeepsTheShortcutApart). Fixed at 2e8574d. No look change (Sidebar-Look: no visual change).

Gain

Gain: 108-112 fewer tooltip tracking areas per launch (the same 4 hidden icon buttons per workspace row; 24-25 rows plus 3 spare rows in the realistic launch). Count tests: SidebarIconButtonLazyTooltipTests red on base (steps c2a86828, 6270511b), green on head (step 0b2c0164). Time gain 1-4 ms main-thread CPU, under the bench's noise (measured together with #33112); no regression (A/B cmux21, 20 launches per arm). Accepted under the HOT PATH AUDIT rule (handoff/hot-path-audit/README.md item 3).

Testing

• Red for the P1: bcf4316 (new tests aShortcutSetBeforeTheButtonShowsIsKept, theTooltipReadsBackBeforeAWindowAndTracksOnlyOnceShown on e2c9ba9): step 6270511b7b2d10eb40ae5335 failed as expected (text and shortcut nil before the button shows).
• Green at 2e8574d: step 36b216622f0a4209e0fe5265 passed all 4 suites, including SidebarIconMeaningTests. Compile job ccea8d7f03d6ed7dcc4801e5 passed. Head 9c4e4b7 (with REOPEN-F7: a hidden sidebar icon button makes its image when it first shows #33112's pin change merged in): compile job d6f8e8d11108cadb2596f944 passed; green step 0b2c0164bcc0b5c70bbbb201 passed all 5 suites (SidebarIconButtonLazyTooltipTests, SidebarIconButtonLazyImageTests, ThemedTooltipTests, SidebarIconMeaningTests, SidebarSearchColumnTests).
• At 1845245 (feat merged): compile job 7c406538fa4d7a531bf15d9e passed; green step c14606f0a6009a51dd2bc2ec passed all 5 suites.
• Regression test SidebarIconButtonLazyTooltipTests: a hidden button has no tracker but has its VoiceOver help; it gets its tooltip when shown; a label change while hidden shows the new label; showsLabelToolTip = false registers none. ThemedTooltipTests still passes (no AppKit toolTip, help equals the label).
• Red: ref 92f4c5d (the test on REOPEN-F7: a hidden sidebar icon button makes its image when it first shows #33112's fix, no tooltip change): step c2a86828a617f0dfa6bc9253 failed as expected: 2 of 3 tests, a hidden button already has its tooltip tracker.
• Green at 2a6536a (step 61d790fe): the tooltip suite passed; the step failed only on the REOPEN-F7: a hidden sidebar icon button makes its image when it first shows #33112 test bug fixed at 5263ab5. With REOPEN-F7: a hidden sidebar icon button makes its image when it first shows #33112 merged in (feat 8f963a6 included): head e2c9ba9. Green there: step b107e78cf56106c1af131427 passed, all 3 suites (SidebarIconButtonLazyTooltipTests, SidebarIconButtonLazyImageTests, ThemedTooltipTests), exit 0.
• Compile at e2c9ba9: job 0bb6989a80a1ce39b4d64bf0 passed (CmuxNext, app, cmux-tui).
• AB: measured together with REOPEN-F7: a hidden sidebar icon button makes its image when it first shows #33112 (1 ms profiled is below the bench's run-to-run spread).

Review

Review subagent: SHIP at 9c4e4b7 (comment 6601489848), after its P1 at e2c9ba9 was fixed. After #33112 merged, feat was merged in (conflict in SidebarIconButton.swift only, the #33112 lines next to this PR's): SHIP at 1845245 (comment 6607407510); the 3 changed files are byte-identical to 9c4e4b7.

Observed / Not run

• Observed: the fleet runs above.
• Not run: no hover check on a live app. The tooltip shows through the same tracker after the button shows; the test covers the registration.

Changelog

none

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 1845245: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33113 -f ref=fix/reopen-f7-lazy-button-tooltip -f platform=macos -f backend_mode=local

web and size checks: green

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4167226066401 (c98a19b2a9)
• cmux NEXT nightly 1.0.0-nightly.4167405134701 (95d17bceb7)
• cmux NEXT nightly 1.0.0-nightly.4167532505001 (927ace55d5)

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[lawrencecchen]

Review (subagent opus): SHIP at 9c4e4b7

• P1 fixed in every order: setWhole always stores text and shortcut, and each setter passes the other's current value. The cases that pass are: shortcut after text while hidden or with no window, a label change while hidden (the shortcut is kept), showsLabelToolTip off then on, and showPriority's order (unhide, then label, then shortcut). Only track(...) is gated.
• Views that do not opt in keep the old behavior: TrackerSet.defers defaults to false, so the condition reduces to text != nil. defers(_:) reads the table and does not allocate. Regions ignore the flag (P3: say so in the doc).
• Presenter is safe: current/inside only get a tracker through mouseEntered, so a tracker with no area cannot be shown. track(false) with no area does not reach the else if let area branch, so it never calls exit.
• Nuance on (4): a shown-then-hidden button keeps its area unless its tooltip text changes or it moves while hidden. Then the area is removed (with exit) and added again on viewDidUnhide/viewDidMoveToWindow. This is harmless. Removal from a superview has window nil, so the new viewDidMoveToSuperview returns early. An ancestor unhide reaches the button through viewDidUnhide, and NSStackView re-attach reaches it through viewDidMoveToWindow.
• Tests: the readback asserts were red against the first deferral and pass now. The !tracksTooltip asserts fail on REOPEN-F7: a hidden sidebar icon button makes its image when it first shows #33112's head, which tracks at init. No new stored static or global: one instance field on TrackerSet plus the existing trackers NSMapTable. No app_lines (CmuxNextApp) source changed. P3: the themedToolTipCanShow() doc lists two hooks, but the button uses three.
• I did not compile or run anything. The fleet red and green results are the author's.

[lawrencecchen]

Review (subagent opus): SHIP at 1845245
Same reviewed change on the new base: the +/- lines of diff merge-base..184524511fb are identical to diff 8a8ba37..9c4e4b7 (3 files), and the 3 files at this head are byte-identical to 9c4e4b7.
Conflict resolution is right: feat's SidebarIconButton.swift at the merge base equals #33112's head 8a8ba37, git show --cc of the merge is empty (no hand-made lines), and init sets defersThemedToolTipTracking = true + applyToolTip(); themedToolTipCanShow() runs next to renderIcon() in viewDidMoveToWindow (window != nil), viewDidMoveToSuperview and viewDidUnhide.
No commit on feat since 8f963a6 (up to tip a34003d) touches CmuxNextDesign/Tooltip/ (ThemedToolTip.swift, TooltipPresenter.swift); #33112 changed only SidebarIconButton.swift, WorkspaceRowView.swift and its test. Not run: compile and tests (read-only review).