Skip to content

cmux NEXT: the update and notice cards take the theme; the download bar is the accent - #33103

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/update-card-theme
Nov 3, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/update-card-theme

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Leo, on the sidebar's Downloading Update card: "will this be themeed properly?"

leo-named-fix: land on push.

What was hard-coded

  • The download progress bar was Palette.textSecondary: a fixed gray in every theme, whatever the accent.
  • The Update Ready card and the notice card (Downloading, Checking, Installing, tips) drew CardSurfaceView's neutral gray veil, so over a themed sidebar they read as unthemed cards. The Updated card already took the theme's tint (2026-11-02, same complaint).

Text, icon and cancel-button colours were already theme tokens (Palette.textPrimary / textSecondary / textTertiary), and theme changes already repaint the card (ThemeRepaint calls viewDidChangeEffectiveAppearance).

Change

  • SidebarNoticeCardView: the bar is Palette.accentFill (the theme's accent; the primary text when no accent is chosen) on the Palette.hoverFill track. The surface sets takesThemeTint.
  • SidebarUpdateCardView (Update Ready): the surface sets takesThemeTint.
  • Colours and materials only: no layout, copy or flow change, so this rebases cleanly with the separate one-step update flow work.
  • Sidebar owner note entry added (plans/cmux-next/sidebar-owner.md).

Tests

  • SidebarCardSurfaceTests.theDownloadBarIsTheThemesAccent: renders the downloading card in a dark and a light theme, each with the neutral and a chosen accent, and asserts the bar is Palette.accentFill and not the fixed secondary-text gray. It fails on base, where the bar is textSecondary.
  • theUpdateReadyCardSitsOnTheSharedCardSurfaceInTheThemesTint and aNoticeOrTipCardSitsOnTheSharedCardSurfaceInTheThemesTint now expect the theme's glass tint. They share the helper the Updated card's test uses.

Observed / Not run

  • Ran: prepush-gate.py --base origin/feat-cmux-next --head HEAD, which reports no new violations.
  • Not run: the Swift suite and a compile. This lane's machine has neither; the review runs alongside.

Changelog

  • Fixed: The sidebar's update and download cards follow your theme, and the download bar uses the theme's accent.

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Makes the sidebar's update and notice cards follow your theme, and colors the download progress bar with the theme's accent instead of a fixed gray.

  • The Update Ready and notice/tip cards now use the theme's glass tint, matching the Updated card.
  • The download bar is the theme's accent (Palette.accentFill, the primary text when no accent is chosen) on the theme's hover-fill track.
  • Colors and materials only — layout, copy, and flow are unchanged.

Written for commit 8b2cfe6. Summary will update on new commits.

View guided diff Turn on auto-fix

…ar is the accent

Leo, on the Downloading Update card: "will this be themeed properly?"

The download bar was the fixed secondary-text gray and the Update Ready and
notice cards drew the neutral gray veil over a themed sidebar. The bar is now
Palette.accentFill on the hover-fill track, and both cards' CardSurfaceView
takes the theme's glass tint, as the Updated card's does.

Sidebar-Look: Leo: "will this be themeed properly?"
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-36813ca4dcb616ac37df
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 8b2cfe6: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33103 -f ref=lane/update-card-theme -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on c82a27c to compare; do not merge until green; see lane-rules

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpdhtc1ef1/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpyyjele0_/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo teamleaderleo added the leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel label Nov 3, 2026
@teamleaderleo
teamleaderleo merged commit 91b8977 into feat-cmux-next Nov 3, 2026
183 of 200 checks passed
@teamleaderleo
teamleaderleo deleted the lane/update-card-theme branch November 3, 2026 05:57

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 8b2cfe68 Deployed Nov 3, 2026 by teamleaderleo via namespace autofix #12961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant