Repository navigation
cmux NEXT: the update and notice cards take the theme; the download bar is the accent - #33103
Merged
Merged
Conversation
…ar is the accent Leo, on the Downloading Update card: "will this be themeed properly?" The download bar was the fixed secondary-text gray and the Update Ready and notice cards drew the neutral gray veil over a themed sidebar. The bar is now Palette.accentFill on the hover-fill track, and both cards' CardSurfaceView takes the theme's glass tint, as the Updated card's does. Sidebar-Look: Leo: "will this be themeed properly?" Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-36813ca4dcb616ac37df
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 3, 2026 05:41 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on c82a27c to compare; do not merge until green; see lane-rules Shipped in:
|
|
Found 6 test failures on Blacksmith runners: Failures
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo, on the sidebar's Downloading Update card: "will this be themeed properly?"
leo-named-fix: land on push.
What was hard-coded
Palette.textSecondary: a fixed gray in every theme, whatever the accent.CardSurfaceView's neutral gray veil, so over a themed sidebar they read as unthemed cards. The Updated card already took the theme's tint (2026-11-02, same complaint).Text, icon and cancel-button colours were already theme tokens (
Palette.textPrimary/textSecondary/textTertiary), and theme changes already repaint the card (ThemeRepaintcallsviewDidChangeEffectiveAppearance).Change
SidebarNoticeCardView: the bar isPalette.accentFill(the theme's accent; the primary text when no accent is chosen) on thePalette.hoverFilltrack. The surface setstakesThemeTint.SidebarUpdateCardView(Update Ready): the surface setstakesThemeTint.plans/cmux-next/sidebar-owner.md).Tests
SidebarCardSurfaceTests.theDownloadBarIsTheThemesAccent: renders the downloading card in a dark and a light theme, each with the neutral and a chosen accent, and asserts the bar isPalette.accentFilland not the fixed secondary-text gray. It fails on base, where the bar istextSecondary.theUpdateReadyCardSitsOnTheSharedCardSurfaceInTheThemesTintandaNoticeOrTipCardSitsOnTheSharedCardSurfaceInTheThemesTintnow expect the theme's glass tint. They share the helper the Updated card's test uses.Observed / Not run
prepush-gate.py --base origin/feat-cmux-next --head HEAD, which reports no new violations.Changelog
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Makes the sidebar's update and notice cards follow your theme, and colors the download progress bar with the theme's accent instead of a fixed gray.
Palette.accentFill, the primary text when no accent is chosen) on the theme's hover-fill track.Written for commit 8b2cfe6. Summary will update on new commits.