Skip to content

base red: UpdateInstallCheckTests fakes the frontmost app instead of reading a nil NSApp #33093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 1 commit into from
Nov 3, 2026
+7 −2
Merged

base red: UpdateInstallCheckTests fakes the frontmost app instead of reading a nil NSApp #33093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/UpdateInstallCheckTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,13 @@ import Testing
let identity = UpdateBuildIdentity(bundleIdentifier: "com.cmuxterm.app.debug.install-check", shortVersion: "1.0.0",
build: build, minimumSystemVersion: nil,
infoFeedURL: "https://files-next.cmux.com/nightly-next/appcast-arm64.xml", hasPublicKey: false)
return UpdaterService(identity: identity, policy: ManagedUpdatePolicy { false }, defaults: defaults,
enableSparkle: false, recordsUpdates: false, now: { time })
let updater = UpdaterService(identity: identity, policy: ManagedUpdatePolicy { false }, defaults: defaults,
enableSparkle: false, recordsUpdates: false, now: { time })
// The relaunch reads the frontmost app (``UpdaterService/frontmost``); AppKit's answer needs
// an NSApplication, which a test process that made none lacks (`NSApp` is nil and the read
// traps). This app is frontmost, as when a person clicks Restart to Update.
updater.frontmost = { UpdateFrontmostApp(isThisApp: true, pid: 1, bundleID: "com.cmuxterm.app.debug.install-check") }
return updater
}

@Test func aLaunchOnTheOldBuildIsAFailedInstall() {
Expand Down
Loading