Repository navigation
acpmux: fix the base clippy red in additional_dirs' test (cloned_ref_to_slice_refs) - #33064
Conversation
…loned array (clippy cloned_ref_to_slice_refs) 09242cc (#32811) added `assert_eq!(got, [a.clone()])`, which clippy -D warnings refuses (clippy::cloned_ref_to_slice_refs), so `clippy (changed cmux-tui packages)` is red on feat-cmux-next and on every PR whose changed packages build acpmux. std::slice::from_ref(&a) is the same comparison with no clone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on ee701e9 to compare; do not merge until green; see lane-rules Shipped in:
|
|
Review (review_33064): SHIP at b7fce95 Independent correctness review (subagent). Diff is one line in |
|
Found 6 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
clippy (changed cmux-tui packages)is red onfeat-cmux-nextsince #32811 (09242cc): its new test incmux-tui/crates/acpmux/src/hub/additional_dirs.rswritesassert_eq!(got, [a.clone()]), whichclippy -D warningsrefuses (clippy::cloned_ref_to_slice_refs). Every PR whose changed packages build acpmux inherits that red, for example #23071.Base red: https://github.com/manaflow-ai/cmux/actions/runs/41580822611/job/125734988630 (62c09dc) and https://github.com/manaflow-ai/cmux/actions/runs/41572819258/job/125710705429 (09242cc).
The fix compares against
std::slice::from_ref(&a): the same assertion, without the clone. Test-only change.Changelog
none
Observed / Not run
cmux-ci run --class isolated --script scripts/ci/cmux-tui-rust-check.sh --os linux --arg clippyat b7fce95, step5d42d2c9ae3a2ae60983574c: passed (Blacksmith run https://github.com/manaflow-ai/cmuxterm-hq/actions/runs/41582037716).🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the
clippy::cloned_ref_to_slice_refswarning in the acpmuxadditional_dirstest, which was making theclippy (changed cmux-tui packages)check red on the base branch and on any PR whose changed packages build acpmux.The test now asserts against
std::slice::from_ref(&a)instead of[a.clone()], which is semantically identical but satisfiesclippy -D warnings. Test-only change, no behavior change.Written for commit b7fce95. Summary will update on new commits.