Skip to content

acpmux: fix the base clippy red in additional_dirs' test (cloned_ref_to_slice_refs) - #33064

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix-acpmux-additional-dirs-clippy
Nov 3, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix-acpmux-additional-dirs-clippy

Conversation

@austinywang

@austinywang austinywang commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

clippy (changed cmux-tui packages) is red on feat-cmux-next since #32811 (09242cc): its new test in cmux-tui/crates/acpmux/src/hub/additional_dirs.rs writes assert_eq!(got, [a.clone()]), which clippy -D warnings refuses (clippy::cloned_ref_to_slice_refs). Every PR whose changed packages build acpmux inherits that red, for example #23071.

Base red: https://github.com/manaflow-ai/cmux/actions/runs/41580822611/job/125734988630 (62c09dc) and https://github.com/manaflow-ai/cmux/actions/runs/41572819258/job/125710705429 (09242cc).

The fix compares against std::slice::from_ref(&a): the same assertion, without the clone. Test-only change.

Changelog

none

Observed / Not run

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the clippy::cloned_ref_to_slice_refs warning in the acpmux additional_dirs test, which was making the clippy (changed cmux-tui packages) check red on the base branch and on any PR whose changed packages build acpmux.

The test now asserts against std::slice::from_ref(&a) instead of [a.clone()], which is semantically identical but satisfies clippy -D warnings. Test-only change, no behavior change.

Written for commit b7fce95. Summary will update on new commits.

View guided diff Turn on auto-fix

…loned array (clippy cloned_ref_to_slice_refs)

09242cc (#32811) added `assert_eq!(got, [a.clone()])`, which clippy -D warnings
refuses (clippy::cloned_ref_to_slice_refs), so `clippy (changed cmux-tui packages)`
is red on feat-cmux-next and on every PR whose changed packages build acpmux.
std::slice::from_ref(&a) is the same comparison with no clone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@austinywang austinywang added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review b7fce95: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33064 -f ref=fix-acpmux-additional-dirs-clippy -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on ee701e9 to compare; do not merge until green; see lane-rules

Shipped in:

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 3, 2026
@austinywang

Copy link
Copy Markdown
Contributor Author

Review (review_33064): SHIP at b7fce95

Independent correctness review (subagent). Diff is one line in cmux-tui/crates/acpmux/src/hub/additional_dirs.rs:99 (test module only). requested returns Vec<PathBuf>; Vec<T>: PartialEq<&[U]> holds, so assert_eq!(got, std::slice::from_ref(&a)) is the same comparison without the clone. from_ref only borrows; later uses of a (lines 108, 110) are unaffected. No findings. Fleet clippy step 5d42d2c9ae3a2ae60983574c passed at this head.

@austinywang austinywang added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 3, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp7axjee5d/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpbhu0jqdh/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

This branch was previously deployed

3 inactive deployments
artifacts — b7fce95e Deployed Nov 3, 2026 by austinywang via publish tree-addressed cmux-tui #104058
sentry-dsyms — b7fce95e Deployed Nov 3, 2026 by austinywang via upload cmux-tui dSYMs to Sentry #104058
ci-routing-agent — b7fce95e Deployed Nov 3, 2026 by austinywang via cmux-tui tree preflight #104058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants