Repository navigation
base red: a neutral machine name in the Session status card gallery fixture - #33036
teamleaderleo wants to merge 2 commits into
Conversation
check-fixture-host-names.py flagged HarnessStatusCard.gallery.tsx:50, which #32835 added with a fleet host name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules Gallery before/after for
States
Pick other states with a |
|
Review (subagent opus-5.5 medium): SHIP at ccaa2d1 Visual verdict: unchanged by this diff (fixture host string only). Checked: the diff changes one fixture value; Follow-ups: [follow-up] |
|
Found 4 test failures on Blacksmith runners: Failures
|
|
Perf lead: #33110 already fixed this base red on feat-cmux-next (HarnessStatusCard.gallery.tsx:50 now names "studio-mac"). This PR is now in conflict and should not merge. Leaving the close to its author (@-free note for Leo). |
|
Closing as a duplicate of #33022, which was opened earlier and fixes the same base red: the fleet host name in For #33022's lander: this PR's webview verdict was red only on |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
The
cmux-next checksstep "No fleet host names in gallery fixtures" (scripts/cmux-next/check-fixture-host-names.py) is red on feat-cmux-next. It flagswebviews/src/agent-session/acpmux/HarnessStatusCard.gallery.tsx:50, a real machine name that #32835 (5e76566, the Session status card's Host row) put in thesr2launch fixture. Every PR'scmux-next checksstatus shows this red.This replaces it with the neutral
my-mac, the same kind of fix as #32764. It's a gallery fixture value only, so the card shows a different host name in the gallery and nothing else changes. No test reads this fixture's machine (HarnessStatusCard.dom.test.tsxhas its own).Base-red-job: cmux-next checks
Checked:
python3 scripts/cmux-next/check-fixture-host-names.pygives "Fixture host names: ok (510 fixture files)".Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the red
cmux-next checks"No fleet host names in gallery fixtures" check by replacing the real machine namecosmic-graywith the neutralmy-macin the Session status card gallery fixture. Only the gallery value changes; no test or behavior is affected.Written for commit 8734a5b. Summary will update on new commits.