Skip to content

base red: a neutral machine name in the Session status card gallery fixture - #33036

Closed
teamleaderleo wants to merge 2 commits into
feat-cmux-nextfrom
lane/web-base-red-fixture-host
Closed

teamleaderleo wants to merge 2 commits into
feat-cmux-nextfrom
lane/web-base-red-fixture-host

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

The cmux-next checks step "No fleet host names in gallery fixtures" (scripts/cmux-next/check-fixture-host-names.py) is red on feat-cmux-next. It flags webviews/src/agent-session/acpmux/HarnessStatusCard.gallery.tsx:50, a real machine name that #32835 (5e76566, the Session status card's Host row) put in the sr2 launch fixture. Every PR's cmux-next checks status shows this red.

This replaces it with the neutral my-mac, the same kind of fix as #32764. It's a gallery fixture value only, so the card shows a different host name in the gallery and nothing else changes. No test reads this fixture's machine (HarnessStatusCard.dom.test.tsx has its own).

Base-red-job: cmux-next checks

Checked: python3 scripts/cmux-next/check-fixture-host-names.py gives "Fixture host names: ok (510 fixture files)".

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the red cmux-next checks "No fleet host names in gallery fixtures" check by replacing the real machine name cosmic-gray with the neutral my-mac in the Session status card gallery fixture. Only the gallery value changes; no test or behavior is affected.

Written for commit 8734a5b. Summary will update on new commits.

View guided diff Turn on auto-fix

check-fixture-host-names.py flagged HarnessStatusCard.gallery.tsx:50,
which #32835 added with a fleet host name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review ccaa2d1: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33036 -f ref=lane/web-base-red-fixture-host -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards.

CI failed on 8734a5b7da (run 41584229484 attempt 1): 1 code, 1 unknown.

Job Verdict Why
web / react-apps-base-check (4) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs transcript-upward-anchor.test.ts received card folds preserve painted row-box adjacency while streaming: failed (job)
Matched log lines
web / react-apps-base-check (4): (fail) received card folds preserve painted row-box adjacency while streaming [9076.21ms]

Not re-run automatically: web / react-apps-base-check (4), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / react-apps-base-check (4); NEW webview test reds: test/transcript-upward-anchor.test.ts > (unnamed); do not merge until green; see lane-rules
red: web / react-apps-check; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules

Gallery before/after for 8734a5b: 16 states rendered, 2 images differ, 1198 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41584229304 -R manaflow-ai/cmux -n gallery-advisory-33036-8734a5b7da6bb5adb07d00f242f1f2e49caf6243 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.harness-status/claude Apple System Colors Light unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/claude Apple System Colors unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/claude-sr2 Apple System Colors changed 0.206% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/claude-sr2 Apple System Colors Light changed 0.206% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/claude-api-key Apple System Colors Light unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/claude-api-key Apple System Colors unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/codex Apple System Colors Light unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/codex Apple System Colors unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/opencode Apple System Colors Light unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/opencode Apple System Colors unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/copy-and-escape Apple System Colors Light unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/copy-and-escape Apple System Colors unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/copy-value Apple System Colors Light unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/copy-value Apple System Colors unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/header-action-alignment Apple System Colors Light unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.harness-status/header-action-alignment Apple System Colors unchanged 0% own HarnessStatusCard.gallery.tsx
agent-pane.access-offer/turn-no-credits Apple System Colors Light unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.access-offer/turn-no-credits Apple System Colors unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.access-offer/turn-low-credits Apple System Colors Light unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.access-offer/turn-low-credits Apple System Colors unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.access-offer/turn-no-offer Apple System Colors Light unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.access-offer/turn-no-offer Apple System Colors unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.add-account/subscription Apple System Colors Light unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.add-account/subscription Apple System Colors unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.add-account/api-key Apple System Colors Light unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.add-account/api-key Apple System Colors unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.add-account/unavailable Apple System Colors Light unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.add-account/unavailable Apple System Colors unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.add-project-panel/environment Apple System Colors Light unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.add-project-panel/environment Apple System Colors unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.add-project-panel/sources Apple System Colors Light unchanged 0% same-folder HarnessStatusCard.gallery.tsx
agent-pane.add-project-panel/sources Apple System Colors unchanged 0% same-folder HarnessStatusCard.gallery.tsx

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus-5.5 medium): SHIP at ccaa2d1

Visual verdict: unchanged by this diff (fixture host string only).

Checked: the diff changes one fixture value; check-fixture-host-names.py passes at the head (510 files); no test, play or gallery-matrix baseline reads the gallery's LAUNCHES machine; my-mac matches no checker rule and no registry host.

Follow-ups: [follow-up] HarnessStatusCard.dom.test.tsx and several webviews/test files still use a fleet host as sample data (the checker doesn't scan tests), optional cleanup.

@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
test/transcript-upward-anchor.test.ts/transcript-upward-anchor.test View Logs
test/transcript-upward-anchor.test.ts/transcript-upward-anchor.test View Logs
test/transcript-upward-anchor.test.ts/transcript-upward-anchor.test View Logs
test/transcript-upward-anchor.test.ts/transcript-upward-anchor.test View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@lawrencecchen

Copy link
Copy Markdown
Contributor

Perf lead: #33110 already fixed this base red on feat-cmux-next (HarnessStatusCard.gallery.tsx:50 now names "studio-mac"). This PR is now in conflict and should not merge. Leaving the close to its author (@-free note for Leo).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing as a duplicate of #33022, which was opened earlier and fixes the same base red: the fleet host name in HarnessStatusCard.gallery.tsx:50, which fails check-fixture-host-names.py. Land that one.

For #33022's lander: this PR's webview verdict was red only on transcript-upward-anchor.test.ts:320 (Expected 136, Received 128). That test fails at the same line on every recent base push run, with 130 or 132 received, so it's a base flake, not caused by a fixture change. A fix for it is in progress.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, sweep, via the review router; full diff from merge base dfc60a4 to this head): SHIP at 8734a5b

No P1/P2 findings.

This branch was previously deployed

3 inactive deployments
artifacts — 8734a5b7 Deployed Nov 3, 2026 by cmux-bot[bot] via publish tree-addressed cmux-tui #104129
sentry-dsyms — 8734a5b7 Deployed Nov 3, 2026 by cmux-bot[bot] via upload cmux-tui dSYMs to Sentry #104129
ci-routing-agent — 8734a5b7 Deployed Nov 3, 2026 by cmux-bot[bot] via cmux-tui tree preflight #104129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants