Skip to content

cmux-tui: new-frontend-browser-tab can make its tab directly in a new split (frontend-browser-tab-split-v1) #32862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmux-bot merged 4 commits into from
Nov 3, 2026
Merged

cmux-tui: new-frontend-browser-tab can make its tab directly in a new split (frontend-browser-tab-split-v1) #32862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d13ce04
test(cmux-next): a link opened to the right is made in its split, nev…
austinywang Oct 21, 2026
10bc1fe
fix(cmux-next): a link opened to the right appears in its split in on…
austinywang Oct 21, 2026
a4142d2
fix(cmux-tui): the keyed split helper no longer shadows keyed_fronten…
austinywang Oct 21, 2026
31ba863
chore(cmux-tui): regenerate the SDK bindings for new-frontend-browser…
teamleaderleo Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cmux-tui/bindings/cpp/.cmux-sdk-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@
},
{
"path": "include/cmux/raw/generated/models.hpp",
"sha256": "a22858a7a9ec510b9fc6a93fdb5a6a70fa8f0da9dffa4c992f79a3356d221d25",
"size": 319535
"sha256": "543ef12f05c447121f9d3972b990291ff5e5472aa8a40ea3745c0e73ecbe9cc5",
"size": 319576
},
{
"path": "src/raw/generated/protocol.cpp",
"sha256": "fd80bff6a096d4126cefb8a7e7f6556fa8f108c4808d39a23ad1789a03dbcdc8",
"size": 2024118
"sha256": "fa31d3ec28298c72f7dfc301e7278aedb7e7b4cfb4aad335491693c812ff61a3",
"size": 2024923
}
],
"format": 1,
"ir_sha256": "cc21760f2943f674c9ddfc3acf0b238c0388afbe9a4e3245bc24d9aa17a2208c",
"ir_sha256": "7c39669d1126b40e5f9e8759eee6ec5ee6eec5da05b4c5a793d8cb16c32dc31b",
"language": "cpp",
"mux_protocol": 12,
"schema_version": 2
Expand Down
3 changes: 2 additions & 1 deletion cmux-tui/bindings/cpp/include/cmux/raw/generated/models.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace cmux::raw {

inline constexpr std::uint32_t kMuxProtocolVersion = 12U;
inline constexpr std::string_view kProtocolIrSha256 = "cc21760f2943f674c9ddfc3acf0b238c0388afbe9a4e3245bc24d9aa17a2208c";
inline constexpr std::string_view kProtocolIrSha256 = "7c39669d1126b40e5f9e8759eee6ec5ee6eec5da05b4c5a793d8cb16c32dc31b";

struct ActivitySnapshot;
struct ActivitySubscribeResult;
Expand Down Expand Up @@ -3975,6 +3975,7 @@ struct NewFrontendBrowserTabRequest {
Field<Id> pane{};
Field<std::string> profile_id{};
Field<std::uint16_t> rows{};
Field<ConversationTabSplit> split{};
Field<std::string> title{};
std::string url{};
friend bool operator==(const NewFrontendBrowserTabRequest&, const NewFrontendBrowserTabRequest&) = default;
Expand Down
20 changes: 19 additions & 1 deletion cmux-tui/bindings/cpp/src/raw/generated/protocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25976,6 +25976,11 @@ Result<Json> Codec<NewFrontendBrowserTabRequest>::encode(const NewFrontendBrowse
if (!encoded) return std::move(encoded).error();
object.emplace("rows", std::move(encoded).value());
}
if (!value.split.is_absent()) {
auto encoded = encode_value(value.split);
if (!encoded) return std::move(encoded).error();
object.emplace("split", std::move(encoded).value());
}
if (!value.title.is_absent()) {
auto encoded = encode_value(value.title);
if (!encoded) return std::move(encoded).error();
Expand Down Expand Up @@ -26086,6 +26091,16 @@ Result<NewFrontendBrowserTabRequest> Codec<NewFrontendBrowserTabRequest>::decode
result.rows = Field<std::uint16_t>(std::move(decoded).value());
}
}
const Json* field_split = value.find("split");
if (field_split) {
if (field_split->is_null()) {
result.split = Field<ConversationTabSplit>::null();
} else {
auto decoded = decode_value<ConversationTabSplit>(*field_split);
if (!decoded) return std::move(decoded).error();
result.split = Field<ConversationTabSplit>(std::move(decoded).value());
}
}
const Json* field_title = value.find("title");
if (field_title) {
if (field_title->is_null()) {
Expand Down Expand Up @@ -42453,6 +42468,9 @@ constexpr std::array<CommandFieldRequirement, 5> kCommand168FieldRequirements{{
{"split", 0U, "conversation-tab-split-v1"},
{"transaction", 0U, "conversation-tab-transaction-v1"},
}};
constexpr std::array<CommandFieldRequirement, 1> kCommand169FieldRequirements{{
{"split", 0U, "frontend-browser-tab-split-v1"},
}};
constexpr std::array<CommandFieldRequirement, 7> kCommand170FieldRequirements{{
{"cwd", 12U, "terminal-placement-env-v1"},
{"env", 12U, "terminal-placement-env-v1"},
Expand Down Expand Up @@ -42759,7 +42777,7 @@ constexpr std::array<CommandMetadata, 288> kCommands{{
{"move-workspace-to-group", "control", 12U, "workspace-groups-v1", false, "", "", std::span<const CommandFieldRequirement>{}},
{"new-browser-tab", "control", 5U, "", false, "", "", std::span<const CommandFieldRequirement>{}},
{"new-conversation-tab", "control", 12U, "conversation-tabs-v1", false, "", "", std::span<const CommandFieldRequirement>(kCommand168FieldRequirements)},
{"new-frontend-browser-tab", "control", 12U, "frontend-browser-tabs-v1", false, "", "", std::span<const CommandFieldRequirement>{}},
{"new-frontend-browser-tab", "control", 12U, "frontend-browser-tabs-v1", false, "", "", std::span<const CommandFieldRequirement>(kCommand169FieldRequirements)},
{"new-pane", "control", 9U, "", false, "", "", std::span<const CommandFieldRequirement>(kCommand170FieldRequirements)},
{"new-pane-right", "control", 9U, "viewport-splits-v1", false, "", "", std::span<const CommandFieldRequirement>(kCommand171FieldRequirements)},
{"new-remote-terminal-tab", "control", 12U, "remote-terminal-tabs-v1", false, "", "", std::span<const CommandFieldRequirement>{}},
Expand Down
18 changes: 9 additions & 9 deletions cmux-tui/bindings/go/raw/.cmux-sdk-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,32 +2,32 @@
"files": [
{
"path": "generated_commands.go",
"sha256": "3f5ac9421e59568e9085ac5d1635d50b67b218adb0da3ae151794e47e02b0bd5",
"size": 1241938
"sha256": "7af0b4ade641a6be12a7338e5dcfac5725a4aedaea7323c9a5e2c91b6d5ef197",
"size": 1243451
},
{
"path": "generated_events.go",
"sha256": "5ac440ca11cffdeec6e537357fa9f4bdc33dee507f910eb90c0f4a7d96292cfb",
"sha256": "62caa42f79698daafb3ee65576559aee18d955acfaa539a9d79d2c6129bdbddc",
"size": 215270
},
{
"path": "generated_metadata.go",
"sha256": "82cea3871a8e3551a45a215d0786d840ec59f35fd9b34743d3d0d62639b1c581",
"size": 125865
"sha256": "b172ba909e88e5b6e8aac1b8c0cea631284023fba1f149452b0459c6a63819c2",
"size": 125921
},
{
"path": "generated_presence_test.go",
"sha256": "39f823345308df3ed7256a1bfbe5c65149fbc49d6c12c220ea1fc4c3a9add9cb",
"size": 2677527
"sha256": "b8dcbfde8b0f832398546f02446ff93b04d19240842569cc57ad75c6be4dfedd",
"size": 2679611
},
{
"path": "generated_types.go",
"sha256": "80419ee64c6f63e28be8af035b13be88614435c920b741c1aafbe66bd72d2666",
"sha256": "059b09ca5536b45eea68f8cf5f053c1a2572a5e3be17a8edb7d59d9f31dab044",
"size": 532677
}
],
"format": 1,
"ir_sha256": "cc21760f2943f674c9ddfc3acf0b238c0388afbe9a4e3245bc24d9aa17a2208c",
"ir_sha256": "7c39669d1126b40e5f9e8759eee6ec5ee6eec5da05b4c5a793d8cb16c32dc31b",
"language": "go",
"mux_protocol": 12,
"schema_version": 2
Expand Down
84 changes: 58 additions & 26 deletions cmux-tui/bindings/go/raw/generated_commands.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cmux-tui/bindings/go/raw/generated_events.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions cmux-tui/bindings/go/raw/generated_metadata.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading