Repository navigation
gallery: a chat and the subagent it opened in the right split, side by side - #32825
Conversation
…y side Leo, 2026-11-02: "WHEN I OPEN A SUBAGENT IT SHOULD GO TO THE RIGHT SPLIT AREA". agent-pane.subagent-split draws the two panes (parent: the subagents' states and Session Info open; child: the subagent pane, titled by its task, its own transcript, Session Info closed), and agent-pane.subagent-split-pair lays them side by side; each play asserts that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules Shipped in:
|
…carry the stage's settings and fail fast (review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (claude-opus-5-5): SHIP at 4c19619
Review (subagent claude-opus-5-5): SHIP at 4c19619
Visual verdict: gallery-only change; two new scenes (parent and child split, side by side), no shipped UI changed.
Checked the earlier BLOCK's fixes: the parent play reads the running tray and done line, #32763 is merged in for the child's closed Session Info, the pair fails fast on a pane load error and carries the stage's settings.
Follow-ups: none blocking.
… finds its file (#32953) #32825 gave the entry `id: SPLIT_ENTRY`; test/support/galleryFrame.ts finds an entry's file by its `id: "<id>"` line, so every test that warms every web entry (gallery-control-surfaces) threw "no gallery files define entry". Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… bun lane #32825 wrote agent-pane.subagent-split's id as a constant; galleryEntryPath finds an entry's file by its literal id line, so browser/gallery-control-surfaces went red on feat-cmux-next and only the browser lane could see it (fixed by #32953). This test catches that shape without a browser: red with id: SPLIT_ENTRY restored, green on head. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Leo, 2026-11-02: "WHEN I OPEN A SUBAGENT IT SHOULD GO TO THE RIGHT SPLIT AREA"
Leo, 2026-11-03: "like if they want it open they can just do it on the right split one but otherwise it really doesn't have that much space pretty often"
This adds gallery scenes for #32677 (a subagent opens in the right split) and #32763 (a chat opened in a split starts with Session Info closed).
agent-pane.subagent-split: two variants of one chat.parent: the chat on the left, with its subagents' line showing each one's state (one running, one done) and Session Info open.child: the pane the app opens on the right on the running subagent (asubagent:reveal).childplay asserts the pane is titled by its task, with no raw id or UUID, shows its own transcript, and keeps Session Info closed.agent-pane.subagent-split-pair: the two panes side by side, each a live stage in its own frame. Its play checks that the left pane shows the subagent states with Session Info open, and the right pane shows the title with Session Info closed.References (cmux-design-references):
codex/web/sidebar-parallel-agents,codex/web/multitask,codex-mobile/live/agents-sheet-active-completed,codex-mobile/live/grouped-activity-rows, and Leo's ChatGPT task-thread target (parent on the left with the task's chip, the task's own thread on the right). No ChatGPT task-thread reference is in the index yet.Not in this PR: a composer in the subagent's pane. acpmux cannot send a subagent a message today (#32809). Sub-sessions already have their own composer.
Observed / Not run
vp fmtandvp linton both files, gallery coverage names these covers, prepush gate. The gallery matrix plays for both entries run through cmux-ci.Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds gallery scenes showing a subagent opening in the right split: the parent chat on the left keeps its subagents' states and Session Info open, while the subagent pane opens on the right titled by its task, with Session Info closed. Covers #32677 and #32763.
agent-pane.subagent-splitentry with two live variants,parent(the chat) andchild(the split-opened subagent pane).childplay asserts the pane is titled by its task with no raw id or UUID, shows its own transcript, and does not inherit Session Info open.agent-pane.subagent-split-pairentry renders both panes side by side in separate frames and checks the two behaviors together.Written for commit 4c19619. Summary will update on new commits.