Skip to content

gallery: a chat and the subagent it opened in the right split, side by side - #32825

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/subagent-split-gallery
Nov 3, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/subagent-split-gallery

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Leo, 2026-11-02: "WHEN I OPEN A SUBAGENT IT SHOULD GO TO THE RIGHT SPLIT AREA"
Leo, 2026-11-03: "like if they want it open they can just do it on the right split one but otherwise it really doesn't have that much space pretty often"

This adds gallery scenes for #32677 (a subagent opens in the right split) and #32763 (a chat opened in a split starts with Session Info closed).

  • agent-pane.subagent-split: two variants of one chat.
    • parent: the chat on the left, with its subagents' line showing each one's state (one running, one done) and Session Info open.
    • child: the pane the app opens on the right on the running subagent (a subagent: reveal).
    • The child play asserts the pane is titled by its task, with no raw id or UUID, shows its own transcript, and keeps Session Info closed.
  • agent-pane.subagent-split-pair: the two panes side by side, each a live stage in its own frame. Its play checks that the left pane shows the subagent states with Session Info open, and the right pane shows the title with Session Info closed.

References (cmux-design-references): codex/web/sidebar-parallel-agents, codex/web/multitask, codex-mobile/live/agents-sheet-active-completed, codex-mobile/live/grouped-activity-rows, and Leo's ChatGPT task-thread target (parent on the left with the task's chip, the task's own thread on the right). No ChatGPT task-thread reference is in the index yet.

Not in this PR: a composer in the subagent's pane. acpmux cannot send a subagent a message today (#32809). Sub-sessions already have their own composer.

Observed / Not run

  • Observed: vp fmt and vp lint on both files, gallery coverage names these covers, prepush gate. The gallery matrix plays for both entries run through cmux-ci.

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Adds gallery scenes showing a subagent opening in the right split: the parent chat on the left keeps its subagents' states and Session Info open, while the subagent pane opens on the right titled by its task, with Session Info closed. Covers #32677 and #32763.

Written for commit 4c19619. Summary will update on new commits.

View guided diff Turn on auto-fix

…y side

Leo, 2026-11-02: "WHEN I OPEN A SUBAGENT IT SHOULD GO TO THE RIGHT SPLIT AREA".
agent-pane.subagent-split draws the two panes (parent: the subagents' states
and Session Info open; child: the subagent pane, titled by its task, its own
transcript, Session Info closed), and agent-pane.subagent-split-pair lays them
side by side; each play asserts that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 4c19619: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32825 -f ref=lane/subagent-split-gallery -f platform=macos -f backend_mode=local

Gallery before/after for 4c19619: 16 states rendered, 19 images differ, 171 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41563035957 -R manaflow-ai/cmux -n gallery-advisory-32825-4c19619145f8eb932381ca35a5c25f33720f4bb2 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.subagent-split/parent Apple System Colors Light new 0% own subagentSplit.gallery.ts
agent-pane.subagent-split/parent Apple System Colors new 0% own subagentSplit.gallery.ts
agent-pane.subagent-split/child Apple System Colors Light new 0% own subagentSplit.gallery.ts
agent-pane.subagent-split/child Apple System Colors new 0% own subagentSplit.gallery.ts
agent-pane.subagent-split-pair/default Apple System Colors Light new 0% own subagentSplitPair.gallery.tsx
agent-pane.subagent-split-pair/default Apple System Colors new 0% own subagentSplitPair.gallery.tsx
agent-pane.agent-runs/card-running Apple System Colors Light changed 0.0519% same-folder subagentSplit.gallery.ts
agent-pane.agent-runs/card-running Apple System Colors changed 0.0104% same-folder subagentSplit.gallery.ts
agent-pane.agent-runs/card-done Apple System Colors Light unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.agent-runs/card-done Apple System Colors unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.agent-runs/card-failed Apple System Colors Light unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.agent-runs/card-failed Apple System Colors unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/full Apple System Colors Light unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/full Apple System Colors unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-running Apple System Colors Light changed 0.0068% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-running Apple System Colors changed 0.0056% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-finished Apple System Colors Light unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-finished Apple System Colors unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-agent-failed Apple System Colors Light unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-agent-failed Apple System Colors unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-agent-row-compact Apple System Colors Light changed 0.0063% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-agent-row-compact Apple System Colors changed 0.0059% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-agent-row-detail Apple System Colors Light changed 0.0067% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-agent-row-detail Apple System Colors changed 0.0056% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-agent-row-grid Apple System Colors Light changed 0.0072% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-agent-row-grid Apple System Colors changed 0.0055% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-agent-row-narrow Apple System Colors Light changed 0.0064% same-folder subagentSplit.gallery.ts
agent-pane.chat-inspector/workflow-agent-row-narrow Apple System Colors changed 0.0052% same-folder subagentSplit.gallery.ts
agent-pane.composer-turn-cycle/idle Apple System Colors Light unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.composer-turn-cycle/idle Apple System Colors unchanged 0% same-folder subagentSplit.gallery.ts
agent-pane.composer-turn-cycle/running Apple System Colors changed 0.0293% same-folder subagentSplit.gallery.ts
agent-pane.composer-turn-cycle/running Apple System Colors Light unchanged 0% same-folder subagentSplit.gallery.ts

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

Probably yours: gallery-control-surfaces.test.ts fails here but not on main's latest full suite. Seen on other PRs too (likely flaky): message-preview-browser.test.ts, message-preview-browser.test.ts. This PR merged before its CI finished: fix forward on main.

CI failed on 4c19619145 (run 41563036189 attempt 1): 1 code, 1 unknown.

Job Verdict Why
web / react-apps-base-check (1) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs message-preview-browser.test.ts a received message is one ellipsized line at wide and narrow zoomed widths, and opens whole: failed (job)
  • seen on other PRs message-preview-browser.test.ts Minimal Mode draws the same one line, which opens the whole message: failed (job)
  • new in this PR gallery-control-surfaces.test.ts (unnamed): failed (job)
Matched log lines
web / react-apps-base-check (1): (fail) a received message is one ellipsized line at wide and narrow zoomed widths, and opens whole [1413.16ms]

Not re-run automatically: web / react-apps-base-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / react-apps-base-check (1); NEW webview test reds: test/browser/gallery-control-surfaces.test.ts > (unnamed); do not merge until green; see lane-rules
red: web / react-apps-check; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
teamleaderleo and others added 2 commits November 3, 2026 01:54
…carry the stage's settings and fail fast (review)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (claude-opus-5-5): SHIP at 4c19619

Review (subagent claude-opus-5-5): SHIP at 4c19619
Visual verdict: gallery-only change; two new scenes (parent and child split, side by side), no shipped UI changed.
Checked the earlier BLOCK's fixes: the parent play reads the running tray and done line, #32763 is merged in for the child's closed Session Info, the pair fails fast on a pane load error and carries the stage's settings.
Follow-ups: none blocking.

@teamleaderleo teamleaderleo added the leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel label Nov 3, 2026
@teamleaderleo
teamleaderleo merged commit 6616d17 into feat-cmux-next Nov 3, 2026
184 of 188 checks passed
@teamleaderleo
teamleaderleo deleted the lane/subagent-split-gallery branch November 3, 2026 02:17
cmux-bot Bot pushed a commit that referenced this pull request Nov 3, 2026
… finds its file (#32953)

#32825 gave the entry `id: SPLIT_ENTRY`; test/support/galleryFrame.ts finds an
entry's file by its `id: "<id>"` line, so every test that warms every web entry
(gallery-control-surfaces) threw "no gallery files define entry".


Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Nov 3, 2026
… bun lane

#32825 wrote agent-pane.subagent-split's id as a constant; galleryEntryPath finds
an entry's file by its literal id line, so browser/gallery-control-surfaces went
red on feat-cmux-next and only the browser lane could see it (fixed by #32953).
This test catches that shape without a browser: red with id: SPLIT_ENTRY
restored, green on head.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 4c196191 Deployed Nov 3, 2026 by teamleaderleo via cmux-tui tree preflight #103422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant