Repository navigation
Transcript: a background update with nothing to open has no chevron, and draws no line once it ends - #32798
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
|
|
Owned by an agent session · session |
|
Review (subagent claude-opus-5-5 medium): SHIP at 487d8b5 Visual verdict: I opened no screenshots. The new I checked the code only. The nested Follow-ups:
|
…button (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-81baa1463f6190d4c5dc
…d one that ended with nothing draws no line A background turn whose events only update rows that are not its own (a call an earlier turn started, a subagent's work) used to draw a closed "Background update" line whose chevron opened to nothing. The pane now notes when a row of the turn's own draws something (hasRows). Without one, an ended quiet turn draws no line, and a running one is a plain spinner line with no chevron and no button until a row comes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-81baa1463f6190d4c5dc
487d8b5 to
835e635
Compare
|
Review (subagent claude-opus-5-5 medium): SHIP at 835e635 Visual verdict: unchanged by the rebase; #32867's chevron placement (right after the label, rotor class on the svg) is kept as-is, only wrapped in Checked the range-diff against the earlier SHIP at 487d8b5: the only deltas are the two conflict resolutions. In Follow-ups: none. |
It opens nothing. Leo, 2026-11-03, on rows like it: "these background updates don't really expand out to anything? idk what those are even for". Same rule as #32798: a row shows a chevron only with something to show. test/transcript-running-live-line.test.tsx: the new test fails on base (1 fail), 10/10 pass here. Agent-Session: https://cmux.com/deeplink/agent?id=aid-81baa1463f6190d4c5dc Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…32726 began; lines with nothing to open (#32798) stay out of runs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
Leo (2026-11-03): "these background updates don't really expand out to anything? idk what those are even for"
What these rows are
acpmux brackets each turn the agent runs without a prompt (a background task finished, a scheduled wakeup, anything else such as a hook or late work after a restart) with
background_turnrecords. A quiet one draws as one muted line ("Background task finished", "Scheduled check", "Background update") that opens to the rows the turn made (#30205).Some of these turns make no rows of their own. Their events only update rows that belong to something else, such as a call an earlier turn started or a subagent's tool calls while the main agent is idle. Those draw a "Background update" line whose chevron opens to nothing. In the session logs I checked, every empty line was a
systemtrigger, which reads as "Background update".Change
direct.ts(OrderedRows) records on the line (background.hasRows) when a row of the turn's own draws something. That covers a row tagged live, a row tagged when an older page brings the started record, and the line keeps the mark when its ended record arrives.backgroundTurns.tsdrawsBackgroundLine: a quiet turn that ended with no rows of its own draws no line. It has nothing to show and nothing to say. Its rows (if any, all visibly empty) stay folded as before.BackgroundTurnLine.tsx: a running turn with no rows yet is a plain spinner line, with no chevron, no button and noaria-expanded. Once its first row comes, it opens to that row.TranscriptActivityRow.tsx: achevronprop (defaulttrue, so other rows are unchanged). Chevron placement is untouched.transcript / background-turns-nothing-to-open, with a play that asserts the ended line is absent and the running line is neither a button nor has a chevron. Existing gallery lines carryhasRows: true.No new strings. Turns that do have rows keep their trigger labels and open as before.
Observed / Not run
test/agent-pane-background-turns.test.tswas committed first (2aedebf). On base code it fails 2 tests: the ended empty line is drawn, and the running empty line is a<button>withcv-agent-activity__chevron. On head: 20/20 pass across it andbackgroundTurns.test.tsx.systemlines that had no rows now draws 0 of them. A session with 24 quiet lines, all with rows, still draws all 24.web-lint.shandprepush-gate.pypass. On a fleet box, the background, activity-row, step-row and spacing tests pass 37/0 (run 41561316728).bun run checkthere is red only on twono-implied-evalwarnings intest/native-session-info-toggle.test.tsx, a file this PR does not touch. That is a base red, already fixed on base by base red: the old-host close-script test runs the script with node:vm, not new Function (tip web-lint red from 419a87a14791) #32760.Changelog
Agent session: agent session
🤖 Generated with Claude Code