Repository navigation
base red: cmux-actions fixture RUNNER_POOLS holds every declared pool - #32653
Merged
Merged
Conversation
#32457 moved the iOS kit picker's fallback to fromJSON(vars.RUNNER_POOLS).linux_8, but the fixture variable held only `linux`, so the picker's runs-on resolved to null and four "iOS kit picker fallback" cases failed on feat-cmux-next. The fixture now holds each pool declared in .github/runners.json at its first member (what runner_pools.py keeps it at), and the iOS kit cases test the pool reads: the eight vCPU pool, a moved pool, the bounded LINUX_RUNNER sizes and the saved-overflow sixteen vCPU pool. The unset and empty variable cases are gone: RUNNER_POOLS is required and an unset one fails the run at fromJSON(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-73244be6791fcec67af9
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Collaborator
Author
|
Review (subagent claude-opus-5-5 medium): SHIP at fec6edd I checked that the fixture pools derive from .github/runners.json, that the cases match the ios-kit runner runs-on order, and that dropping the unset/empty cases is justified by runs_on_labels.pool_members. vitest passes 1032/1032 and the no-single-size-pins guard is OK. Follow-ups: none. |
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 2, 2026 23:31 — with
GitHub Actions
Inactive
Collaborator
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base-red-job: cmux-actions / Tests (expressions, matrix, every workflow fixture)
#32457 (bbb2b89) moved the iOS kit picker's fallback in
.github/workflows/cmux-next-ios-kit.ymltofromJSON(vars.RUNNER_POOLS).linux_8. That pool is declared in.github/runners.jsonand set live, so the workflow is right. The cmux-actions fixture, though, hadRUNNER_POOLS={"linux":"fleet-linux"}only, so the picker's runs-on came out null and 4 "iOS kit picker fallback" cases failed on feat-cmux-next.Fix, test-only (the workflow is unchanged and nothing is pinned):
RUNNER_POOLSnow holds every pool declared in.github/runners.jsonat its first member, which is whatscripts/ci/runner_pools.pykeeps it at.linuxstaysfleet-linux, so trigger planning still sees a fleet candidate.linux_16. I dropped the unset and empty variable cases: RUNNER_POOLS is required, and an unset one fails the run atfromJSON()(tests/runs_on_labels.py).Checks:
vitest run test/passes 1032/1032 (4 failed before),tsc --noEmitpasses, andtests/test_ci_no_single_size_pins.pyis OK.Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the cmux-actions fixture so the iOS kit picker fallback tests pass on
feat-cmux-next.#32457 moved the picker's fallback to
fromJSON(vars.RUNNER_POOLS).linux_8, but the fixture variable held onlylinux, so the picker resolved to a null runs-on and four cases failed. The fixture now holds every pool declared in.github/runners.jsonat its first member — whatscripts/ci/runner_pools.pykeeps them at — and the iOS kit cases test the pool reads: the eight vCPU pool, a moved pool, the boundedLINUX_RUNNER4/8/16 sizes, and saved overflow readinglinux_16. The unset and empty variable cases are gone;RUNNER_POOLSis required and an unset one fails the run atfromJSON().Test-only: the workflow is unchanged and nothing is pinned.
Written for commit fec6edd. Summary will update on new commits.