Skip to content

base red: cmux-actions fixture RUNNER_POOLS holds every declared pool - #32653

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/fleet-ios-kit-runs-on
Nov 2, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/fleet-ios-kit-runs-on

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Base-red-job: cmux-actions / Tests (expressions, matrix, every workflow fixture)

#32457 (bbb2b89) moved the iOS kit picker's fallback in .github/workflows/cmux-next-ios-kit.yml to fromJSON(vars.RUNNER_POOLS).linux_8. That pool is declared in .github/runners.json and set live, so the workflow is right. The cmux-actions fixture, though, had RUNNER_POOLS = {"linux":"fleet-linux"} only, so the picker's runs-on came out null and 4 "iOS kit picker fallback" cases failed on feat-cmux-next.

Fix, test-only (the workflow is unchanged and nothing is pinned):

  • The fixture RUNNER_POOLS now holds every pool declared in .github/runners.json at its first member, which is what scripts/ci/runner_pools.py keeps it at. linux stays fleet-linux, so trigger planning still sees a fleet candidate.
  • The iOS kit cases now test the pool reads: the eight vCPU pool, a moved pool being followed, the bounded LINUX_RUNNER 4/8/16 sizes, a fleet or invalid LINUX_RUNNER being rejected for the pool, and saved overflow reading linux_16. I dropped the unset and empty variable cases: RUNNER_POOLS is required, and an unset one fails the run at fromJSON() (tests/runs_on_labels.py).

Checks: vitest run test/ passes 1032/1032 (4 failed before), tsc --noEmit passes, and tests/test_ci_no_single_size_pins.py is OK.

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the cmux-actions fixture so the iOS kit picker fallback tests pass on feat-cmux-next.

#32457 moved the picker's fallback to fromJSON(vars.RUNNER_POOLS).linux_8, but the fixture variable held only linux, so the picker resolved to a null runs-on and four cases failed. The fixture now holds every pool declared in .github/runners.json at its first member — what scripts/ci/runner_pools.py keeps them at — and the iOS kit cases test the pool reads: the eight vCPU pool, a moved pool, the bounded LINUX_RUNNER 4/8/16 sizes, and saved overflow reading linux_16. The unset and empty variable cases are gone; RUNNER_POOLS is required and an unset one fails the run at fromJSON().

Test-only: the workflow is unchanged and nothing is pinned.

Written for commit fec6edd. Summary will update on new commits.

View guided diff Turn on auto-fix

#32457 moved the iOS kit picker's fallback to fromJSON(vars.RUNNER_POOLS).linux_8, but the
fixture variable held only `linux`, so the picker's runs-on resolved to null and four
"iOS kit picker fallback" cases failed on feat-cmux-next. The fixture now holds each pool
declared in .github/runners.json at its first member (what runner_pools.py keeps it at),
and the iOS kit cases test the pool reads: the eight vCPU pool, a moved pool, the bounded
LINUX_RUNNER sizes and the saved-overflow sixteen vCPU pool. The unset and empty variable
cases are gone: RUNNER_POOLS is required and an unset one fails the run at fromJSON().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-73244be6791fcec67af9
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review fec6edd: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32653 -f ref=lane/fleet-ios-kit-runs-on -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at fec6edd

I checked that the fixture pools derive from .github/runners.json, that the cases match the ios-kit runner runs-on order, and that dropping the unset/empty cases is justified by runs_on_labels.pool_members. vitest passes 1032/1032 and the no-single-size-pins guard is OK.

Follow-ups: none.

@teamleaderleo
teamleaderleo merged commit e467c24 into feat-cmux-next Nov 2, 2026
124 of 135 checks passed
@teamleaderleo
teamleaderleo deleted the lane/fleet-ios-kit-runs-on branch November 2, 2026 23:32
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, sweep, via the review router; full diff from merge base db16812 to this head): SHIP at fec6edd

No P1/P2 findings.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — fec6edde Deployed Nov 2, 2026 by teamleaderleo via wait for same-key tree publisher #102948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant