Skip to content

ci(nightly): clear the release-notary guard reds (warm sources, universal nightly workflow) - #32529

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/nightly-release-notary-red
Nov 2, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/nightly-release-notary-red

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Base red: cmux-next guards / nightly-guards / workflow-guard-tests / release-notary fails on feat-cmux-next (for example run 41504624858) and on four open PRs. Two steps fail.

  • Validate nightly push throttle, tests/test_ci_warm_sources.py:
    • Cause: ci(nightly): get nightly.yml back under its size cap (base red) #32513 moved "Build and sign the release notes" into scripts/ci/nightly-steps/release-notes-build-sign.sh. The warm-sources detector treats any script named *build*.sh as a compile, so sign-release-notes became a compile job with no warm sources.
    • Fix: the step compiles nothing, so the script is renamed release-notes-sign.sh. The rule itself is unchanged.
  • Validate universal nightly workflow, tests/test_nightly_universal_build.sh:

Locally, every command in both steps passes: test_nightly_universal_build.sh, test_nightly_trusted_routing, test_nightly_build_state, test_ensure_setup_node, and the nine tests in the push throttle step (warm sources included). test_workflow_file_size, test_nightly_step_coverage and test_nightly_next_identity pass too.

Base-red-job: cmux-next guards / nightly-guards / workflow-guard-tests / release-notary

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Clears the release-notary nightly-guard reds by updating two tests that broke after recent workflow changes.

  • Renames release-notes-build-sign.sh to release-notes-sign.sh; the warm-sources detector treats any script named *build*.sh as a compile, but this step compiles nothing.
  • test_nightly_universal_build.sh now expects the fromJSON(vars.RUNNER_POOLS) pool reads for the decide gate, refresh-compilation-cache, and build-nightly-ghostty-cli-helper, matching the expressions ci: every runner selection reads its size's declared pool (no single-size pins, 1/2) #32457 wrote.

Written for commit 90676bf. Summary will update on new commits.

View guided diff Turn on auto-fix

…rsal nightly workflow)

- Validate nightly push throttle (test_ci_warm_sources): #32513 moved
  "Build and sign the release notes" into release-notes-build-sign.sh, and
  the warm-sources detector reads a script named *build*.sh as a compile.
  The step compiles nothing, so the script is renamed release-notes-sign.sh.
- Validate universal nightly workflow (test_nightly_universal_build.sh):
  #32457 turned literal runner labels into declared pool reads
  (fromJSON(vars.RUNNER_POOLS).<pool>, whose first member is the old
  literal) but left three exact-expression checks expecting the literals:
  the decide gate, refresh-compilation-cache and
  build-nightly-ghostty-cli-helper. They now expect the pool reads #32457
  wrote; each still matches the job's whole expression.

Base-red-job: cmux-next guards / nightly-guards / workflow-guard-tests / release-notary

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f724bb1ff9295c18fee7
@cursor

cursor Bot commented Nov 2, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 90676bf: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32529 -f ref=lane/nightly-release-notary-red -f platform=macos -f backend_mode=local

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-sonnet-5-5): SHIP at 90676bf

No reference to the old script name remains, and the script compiles nothing. The refresh and helper runs-on expectations match nightly.yml's whole expressions exactly, and the decide check stays a regex of the same shape it had before. test_nightly_universal_build.sh, test_ci_warm_sources and test_nightly_next_identity pass.

Follow-ups: none

@teamleaderleo
teamleaderleo merged commit cd4742f into feat-cmux-next Nov 2, 2026
78 of 89 checks passed
@teamleaderleo
teamleaderleo deleted the lane/nightly-release-notary-red branch November 2, 2026 19:12
@github-actions github-actions Bot added the risk:high Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 90676bfe Deployed Nov 2, 2026 by teamleaderleo via wait for same-key tree publisher #102354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant