Repository navigation
ci(nightly): clear the release-notary guard reds (warm sources, universal nightly workflow) - #32529
Conversation
…rsal nightly workflow) - Validate nightly push throttle (test_ci_warm_sources): #32513 moved "Build and sign the release notes" into release-notes-build-sign.sh, and the warm-sources detector reads a script named *build*.sh as a compile. The step compiles nothing, so the script is renamed release-notes-sign.sh. - Validate universal nightly workflow (test_nightly_universal_build.sh): #32457 turned literal runner labels into declared pool reads (fromJSON(vars.RUNNER_POOLS).<pool>, whose first member is the old literal) but left three exact-expression checks expecting the literals: the decide gate, refresh-compilation-cache and build-nightly-ghostty-cli-helper. They now expect the pool reads #32457 wrote; each still matches the job's whole expression. Base-red-job: cmux-next guards / nightly-guards / workflow-guard-tests / release-notary Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-f724bb1ff9295c18fee7
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
|
Review (subagent claude-sonnet-5-5): SHIP at 90676bf No reference to the old script name remains, and the script compiles nothing. The refresh and helper runs-on expectations match nightly.yml's whole expressions exactly, and the decide check stays a regex of the same shape it had before. test_nightly_universal_build.sh, test_ci_warm_sources and test_nightly_next_identity pass. Follow-ups: none |
Base red:
cmux-next guards / nightly-guards / workflow-guard-tests / release-notaryfails on feat-cmux-next (for example run 41504624858) and on four open PRs. Two steps fail.tests/test_ci_warm_sources.py:scripts/ci/nightly-steps/release-notes-build-sign.sh. The warm-sources detector treats any script named*build*.shas a compile, sosign-release-notesbecame a compile job with no warm sources.release-notes-sign.sh. The rule itself is unchanged.tests/test_nightly_universal_build.sh:fromJSON(vars.RUNNER_POOLS).<pool>, whose first member is the old literal). Three of this script's exact-expression checks still expected the literals: the decide gate,refresh-compilation-cacheandbuild-nightly-ghostty-cli-helper. The script exits at its first FAIL, so the later two only surfaced after the first was fixed.runs-onexpression, not a prefix. I checked the updated helper expectation against the expanded workflow.Locally, every command in both steps passes:
test_nightly_universal_build.sh,test_nightly_trusted_routing,test_nightly_build_state,test_ensure_setup_node, and the nine tests in the push throttle step (warm sources included).test_workflow_file_size,test_nightly_step_coverageandtest_nightly_next_identitypass too.Base-red-job: cmux-next guards / nightly-guards / workflow-guard-tests / release-notary
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Clears the
release-notarynightly-guard reds by updating two tests that broke after recent workflow changes.release-notes-build-sign.shtorelease-notes-sign.sh; the warm-sources detector treats any script named*build*.shas a compile, but this step compiles nothing.test_nightly_universal_build.shnow expects thefromJSON(vars.RUNNER_POOLS)pool reads for the decide gate,refresh-compilation-cache, andbuild-nightly-ghostty-cli-helper, matching the expressions ci: every runner selection reads its size's declared pool (no single-size pins, 1/2) #32457 wrote.Written for commit 90676bf. Summary will update on new commits.