Repository navigation
Cloud: cloud.machines reports the app server link's route - #32494
Conversation
…nk, and why Native fell back) v12 capture (CMUX_NEXT_CLOUD_NATIVE_LINK=1) showed only 'cmux link refused the dial', so nobody could tell whether the Native launcher fell back or never ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b3ddf8ea0a5ba6fad749
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41497919334 at f6b340f failed: cmux-next crash ends the app, cmux-next daemon tests. |
|
Review (subagent claude-opus-5-5 medium): SHIP at bca1fe1 |
…oudCredentials (tip arch red from ccb777f) (#32506) * Cloud: the app server link's launcher and route live in CmuxNextCloudCredentials (fixes the tip arch red from ccb777f) ccb777f (#32494) added +8 CmuxNextApp lines, which turned the tip arch-ratchet red ([app_lines] +8 over the last green bbb2b89). Fix forward, behavior identical: CloudService's choice of the app server link's launcher (none for the legacy link source, cmux link, or the Native-first launcher with cmux link as its fallback) and the `link_route` text each choice reports are CloudAppServerLink in CmuxNextCloudCredentials, next to CloudNativeFirstLauncher. The Native route holder is still made only for the Native choice of an app server link, and a Native fallback is still logged on app.cloud. CloudNativeFirstLauncherTests.theAppServerLinkReportsTheRouteItLaunched covers each branch: the launcher, the route text, and the route after a fallback. * CloudAppServerLink: one assignment per branch
The app server link's launcher (
CloudService) now records its route, andcloud.machinesreports it aslink_route:legacy,link,native, orlink (native failed: <error>)whenCloudNativeFirstLauncherfell back tocmux link.Why: the item-14 capture v12 baked
CMUX_NEXT_CLOUD_NATIVE_LINK=1and still showed only "cmux link refused the dial: unreachable", so nobody could tell whether Native fell back or never started. Captures recordcloud.machinesinto result.json, so the next run says which path it took.This is diagnostics only and doesn't change behaviour.
🤖 Generated with Claude Code
Agent session: agent session
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Reports which route the app server link launched so
cloud.machinesshows it aslink_route:legacy,link,native, orlink (native failed: <error>)when the Native-first launcher fell back.Previously the v12 capture with
CMUX_NEXT_CLOUD_NATIVE_LINK=1only logged "cmux link refused the dial: unreachable", so it was impossible to tell whether Native fell back or never started. Captures recordcloud.machinesintoresult.json, so the next run will show the path taken. Diagnostics only; no behavior change.Written for commit bca1fe1. Summary will update on new commits.