Skip to content

acpmux tests: usage_stats expects the default 400K autocompact cap (base red from #31936) - #32310

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
lane/usage-stats-autocompact-default
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
lane/usage-stats-autocompact-default

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Base-red-job: cmux-tui spec inventory / acpmux tests (lib, hub_integration)

fork_through::usage_stats::the_session_list_and_info_carry_what_the_chats_transcript_says fails on feat-cmux-next with left: "capped", right: "none" (usage_stats.rs:32). #31936 made acpmux start a Claude session whose Claude home sets no window with CLAUDE_CODE_AUTO_COMPACT_WINDOW=400000 (harness_limits::CLAUDE_AUTOCOMPACT_WINDOW). This test still expected the old uncapped state. It now expects capped and autocompactCap: 400000. Only the test changes.

🤖 Generated with Claude Code

Agent session: agent session


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Updates the acpmux usage_stats integration test to match the new default 400K autocompact cap introduced in #31936.

  • The test previously expected autocompact to be "none" and autocompactCap to be null, which no longer holds since acpmux now starts Claude sessions with a default 400K window (CLAUDE_CODE_AUTO_COMPACT_WINDOW=400000).
  • The test now asserts "capped" and autocompactCap: 400000. Only test expectations changed.

Written for commit cc98c2d. Summary will update on new commits.

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review cc98c2d: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32310 -f ref=lane/usage-stats-autocompact-default -f platform=macos -f backend_mode=local

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (subagent claude-opus-5-5 medium): SHIP at cc98c2d

Review (subagent claude-opus-5-5 medium): SHIP at cc98c2d
Visual verdict: unchanged by this diff (no UI).
The new expectation is deterministic. claude_setup uses an empty CLAUDE_CONFIG_DIR, so claude_autocompact_unset is true and the default 400K window from #31936 is both what the session starts with and what is reported. The test still checks that the reported value matches what the daemon started.
Follow-ups: the test reads the runner env (CLAUDE_CODE_AUTO_COMPACT_WINDOW) too; autocompact() ignores project .claude/settings while claude_autocompact_unset honours them (usage_stats.rs ~L883, already on base).

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing as superseded: #32312 (d6546f5) landed the same fix to the usage_stats expectation on feat-cmux-next first.

This branch was previously deployed

3 inactive deployments
ci-routing-agent — cc98c2d2 Deployed Nov 2, 2026 by github-actions[bot] via cmux-next macOS placement #62958
artifacts — cc98c2d2 Deployed Nov 2, 2026 by teamleaderleo via publish tree-addressed cmux-tui #101377
sentry-dsyms — cc98c2d2 Deployed Nov 2, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #101377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant