Repository navigation
base red: gallery spacing plays follow the layout grid - #32265
Conversation
transcript-spacing, composer-rest-gap, queued-user-footer and the live-line plays in transcript.gallery.ts asserted the pre-grid rhythm: --cv-turn-gap overrides, a 16px turn gap kept in each row's box, a waiting steer row flush with the bubble's right edge, and a live line 14px clear of the run over it. The grid (#27580), the reply footer row (#31690), the waiting steer row (#31683) and the flush live line (#31497) changed those by design; the plays now read the same grid tokens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0
|
Review (subagent opus-5.5 medium): SHIP at b41b214 Visual verdict: unchanged by this diff (gallery plays only, no UI code). Checked each new expectation against transcriptGrid.ts (FOOTER_ROW → block gap 24, step → live line flush), model.ts (TURN_GAP 0, restBand 0 under a footer row) and conversation.css (the empty footer is 0 tall with 28-tall controls, the last empty footer draws nothing, the action row overhangs by (28 - 16) / 2). Every import is exported, and nothing still refers to FOOTER_DROP. Follow-ups:
|
|
Owned by an agent session · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41454213833 at 986d466 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
Found 1 test failure on Blacksmith runners: Failure
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub Actions
Inactive
|
Review (subagent opus-5.5 medium): SHIP at 5bccce8 Carried from the SHIP at b41b214. 5bccce8 is a clean merge of feat-cmux-next with no hand-resolved conflicts, and the PR's diff against base is unchanged. The merge brings in #32240, which fixes the footer icon-column findings that the first run reported once these plays passed. |
GitHub Actions
Inactive
What was red
gallery healthis red on every full base render. These states' plays threw because they asserted the transcript rhythm from before the layout grid. The component draws the intended design in every case; the plays now read the same grid tokens the CSS and the virtual stack use (schemas/layout-grid/layout-grid.jsonviatranscriptGrid.ts).shipped,compact,balanced,relaxed,before,empty-footer): "Footer-to-sender gap 24px". Since fix(chat): align transcript columns and block spacing #27580 the virtual stack places rows by the grid gaps, and--cv-turn-gap(the variants' override) is0pxand places nothing. Since Transcript: reply footer at ChatGPT size, 8 under the reply #31690 a reply's footer is its own 32 row and the block gap (24) follows it. The play now expectsTRANSCRIPT_BLOCK_GAPfor every variant. The old variant notes now say they draw the same as shipped. The empty-footer checks expect what fix(chat): align transcript columns and block spacing #27580 documents: an empty footer row takes no height, its hover controls are one action control tall over the turn gap, and the last one draws nothing.gap-40,gap-56,gap-72): "The rest gap is 56.0px, not 40px". The play took a 16px turn gap off the last row's box. On the grid a row keeps no gap of its own (fix(chat): align transcript columns and block spacing #27580, model.tsTURN_GAP = 0), and the newest row is now the footer row (Transcript: reply footer at ChatGPT size, 8 under the reply #31690), so the rest gap starts at its bottom edge.compact,balanced,roomy): "waiting steer footer is not under the bubble's right edge". The prompt's action row overhangs the bubble's right edge by--cv-action-overhang((action control - icon box) / 2 = 6), so the last glyph's ink sits on the edge (fix(chat): align transcript columns and block spacing #27580). fix(chat): a waiting steer's action row takes no layout height, as a sent prompt's (#27580 regression) #31683 made the waiting steer's row absolute like a sent prompt's. The play now allows for that overhang.codex-turn-command-under-messages,codex-turn-raw-commands): "the live line sits 1.0px under the row over it, not 14px or more". fix(chat): one-line activity rows sit 22 apart again (#27580 regression) #31497 made the live line under a run of one-line rows flush, one more 22px line of the run (design/chat-transcript.md "One-line row pitch"). The play now requires it to be flush under a run: no overlap and less than the run gap. Under prose it still requires at leastTRANSCRIPT_FOOTER_GAP.Regressing PRs (each changed the drawing on purpose; the plays were not updated): #27580, #31690, #31683, #31497.
Only gallery files change; no product code.
Overlap: open #29888 also edits
TranscriptSpacing.gallery.tsxand is already conflicting with base.Base-red-job: cmux-next / gallery health (0)
Base-red-job: cmux-next / gallery health (1)
Base-red-job: cmux-next / gallery health (2)
Base-red-job: cmux-next / gallery health (3)
Base-red-job: cmux-next / gallery health (4)
Base-red-job: cmux-next / gallery health (5)
Base-red-job: cmux-next / gallery health (6)
Base-red-job: cmux-next / gallery health (7)
Agent session: agent session
🤖 Generated with Claude Code