Repository navigation
fix(app): register debug.creation.hold and debug.close.hold again (lost in #28295's merge) - #32238
Conversation
…st in #28295's merge) #29409 registered the local daemon's creation-hold and close-read-hold methods (debug.creation.hold/release, debug.close.hold/release) beside debug.daemon in AppControl. #28295 (debug.daemon_requests) landed after it with its own version of that line, which dropped both, so a Debug build answers those methods with an unknown-method error (scripts/cmux-next/typeahead-gate.sh and the journey fuzz use them). This restores them next to debug.daemon_requests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9124da39adbff74677d9
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (claude-opus-5-5): SHIP at e467a95
Review (subagent claude-opus-5-5): SHIP at e467a95
Restores #29409's + services.daemon.creationHold.methods + services.daemon.closeReadHold.methods tail exactly as b9abd53 dropped it, now after the newer debugRequestLatencyMethod() element; both are [ControlMethod] on @mainactor classes (unchanged since the drop) and debug.creation.*/debug.close.* are registered nowhere else, so nothing is registered twice.
Follow-ups: [follow-up] the one-line register expression is long; splitting the holds into their own service.router.register(...) call would make a future merge less likely to drop them again.
debug.creation.hold/debug.creation.releaseanddebug.close.hold/debug.close.releaseare registered again on a Debug build's control socket.#29409 (P0 close-then-type) registered the local daemon's creation-hold and close-read-hold methods beside
debug.daemoninAppControl:#28295 (
debug.daemon_requests, b9abd53) landed after it with its own copy of that line, which addeddebugRequestLatencyMethod()and dropped both hold lists. Nothing else onfeat-cmux-nextregisters them (git grep "creationHold.methods"finds no caller), so a Debug app answers those four methods with an unknown-method error.scripts/cmux-next/typeahead-gate.shand the journey fuzz (scripts/journeys/ext_fuzz.py) drive them. #28295's own description doesn't mention removing them, so this looks like a merge loss. This PR puts them back besidedebug.daemon_requests. It's a one-line change.Found while investigating the
cmux-next crash ends the appbase red. That red is not caused by this, and this PR does not fix it. See the follow-up evidence on the crash-gate diagnostic PR.Checks: app compile check passed at e467a95;
scripts/cmux-next/prepush-gate.pyreports no new violations.Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Restores
debug.creation.hold/releaseanddebug.close.hold/releaseon a Debug build's control socket. #28295 replaced the registration line inAppControland dropped both hold lists, so Debug builds answered those four methods with an unknown-method error. This puts them back besidedebug.daemon_requests. It's a one-line change; this does not fix thecmux-next crash ends the appred it was found investigating.Written for commit e467a95. Summary will update on new commits.