Repository navigation
base red: continuation spacing test reads the run gap for another agent's line (#31879) - #32138
Conversation
…nt's line #31879 made every status row (model.ts isStatusRow, which includes another agent's received message) sit the run gap (16) from the reply around it. transcript-continuation-spacing still expected the block gap (24) under the reply for the gallery's peer line. Read transcriptGap(MARK_MESSAGE, MARK_STATUS) instead of a literal token. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
|
Review (subagent claude-opus-5-5 medium): SHIP at 05bff4b The 16 gap is meant, not swept in by accident. An incoming The test still checks these against the live page: same reply to reply = gap-block, the hover glyphs clear the foot gap, footer = gap-footer, prompt = gap-turn, and zero paddings. The peer check is not vacuous: the expected value (16) differs from the old 24. Follow-ups: design/grid.md 5.5 still says another agent's line takes the block gap. Update it to the run gap so it matches transcript-spacing.md rule 4. |
Base-red-job: web / react-apps-check
Base-red-job: web / react-apps-check (5)
Red
test/transcript-continuation-spacing.test.ts, "the same assistant's next reply and another agent's line take the block gap; a prompt keeps the turn gap", fails on base atexpect(actual.peer).toBeCloseTo(gridLength("gap-block"), 1): Expected 24, Received 16 (base run 41425459815, job 125211076111, shard 5).Culprit
#31879 ("Agent chat: a run of rows and status lines sit 16 from the prose around them"). Its second commit gave every status row (
model.tsisStatusRow)MARK_STATUS, andtranscriptGap(MARK_MESSAGE, MARK_STATUS)is the run gap (16).isStatusRowlists another agent's received message (kind === "user"withincoming.kind === "message"), which is exactly the gallery'scontinuation-peerrow. #31946 had retargeted this test to the block gap 15 minutes before #31879 landed.Is 16 intended?
Yes, and it is no overlap: the peer line's top sits 16px under the reply's bottom, a positive gap. The grid helper says so (
transcriptGap(MARK_MESSAGE, MARK_STATUS) === TRANSCRIPT_RUN_GAP, asserted incontinuationSpacing.test.ts), and the specs:design/transcript-spacing.md, Rules 3 and 4: received message lines are one-line activity rows, and "a run of rows is 16 from the prose around them"; The table,prose-to-step/step-to-prose.design/chat-transcript.md, Always rules: "another agent's received line" is a one-line activity row; "Rows between replies": another agent's message is anisStatusRowrow.design/grid.md5.5 still lists a status line under the 24 block gap; transcript-spacing.md (Agent chat: a run of rows and status lines sit 16 from the prose around them #31879) is the newer rule for runs and status lines.Change
Test only. The peer assertion reads
transcriptGap(MARK_MESSAGE, MARK_STATUS)instead of a literal token, as #31791 and #31946 did for the other gaps. No product CSS ortranscriptGrid.tschange. The same-assistant gap (block gap), footer gap, turn gap and padding assertions are unchanged.Evidence
Fast-checks runs at head
05bff4b6037cda74be0830e1b98cf97d040e3c1b,cd webviews && bun run test test/transcript-continuation-spacing.test.ts:Expected: 24, Received: 16on the peer gap (run 41429591328).web / react-apps-check (5), job 125211076111 (run 41425459815).Agent session: agent session
🤖 Generated with Claude Code